[shrinkwrap-issues] [JBoss JIRA] (SHRINKDESC-155) Missing methods in generated common parents

[Ralf Battenfeld (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965943#comment-12965943 ] 

Ralf Battenfeld commented on SHRINKDESC-155:
--------------------------------------------

How do you merge different enum types into one? Probably mean here the string setters and getters. Ok, that's possible. With the boolean I had as well issues all the time. I hoped what is generated as common interfaces are good enough. So, I left this out by purpose too.

Besides this, do you agree that this here is never a 100% match of all possible common fields? I hope you agree:-)

Now, I will try to introduce boolean and enums (only as strings). In addition, I will create a test case which is hopefully a kind of an acceptance test.

> Missing methods in generated common parents
> -------------------------------------------
>
>                 Key: SHRINKDESC-155
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-155
>             Project: ShrinkWrap Descriptors
>          Issue Type: Feature Request
>          Components: api-javaee
>    Affects Versions: 2.0.0-alpha-6
>            Reporter: George Gastaldi
>            Assignee: Ralf Battenfeld
>
> Some common parents generated from SHRINKDESC-151 do not have all the required methods declared in the common interface. 
> For example: 
> - JavaeeServletMappingCommonType
> -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webcommon/ServletMappingCommonType.java
> - WebAppCommonDescriptor
> -- see https://github.com/forge/javaee-descriptors/blob/master/api/src/main/java/org/jboss/shrinkwrap/descriptor/api/webapp/WebAppCommonDescriptor.java
> Other parent interfaces might be missing methods as well, they should be reviewed and have the common methods created. 



--
This message was sent by Atlassian JIRA
(v6.2.3#6260)