[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-186) MavenResolverSystemBase deprecates offline() but JavaDoc refer to wrong new usage

[Karel Piwko (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKRES-186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997348#comment-12997348 ] 

Karel Piwko commented on SHRINKRES-186:
---------------------------------------

Landed in https://github.com/shrinkwrap/resolver/commit/51c6429cae0187892b255580eac6c6c2581c2f5f, thanks [~mmatloka]

> MavenResolverSystemBase deprecates offline() but JavaDoc refer to wrong new usage 
> ----------------------------------------------------------------------------------
>
>                 Key: SHRINKRES-186
>                 URL: https://issues.jboss.org/browse/SHRINKRES-186
>             Project: ShrinkWrap Resolvers
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: api-maven
>    Affects Versions: 2.1.1
>            Reporter: Aslak Knutsen
>            Assignee: Michal Matloka
>             Fix For: 2.2.0-alpha-3
>
>
> MavenResolverSystemBase deprecates the methods offline() and offline(boolean), but the JavaDoc suggests the new way to set this flag is via ConfigurableMavenResolverSystem#workOffline(). The link is correct, but the suggest path seems off; Maven.resolver().workOffline()
> Maven.resolver() will return a MavenResolverSystem, while Maven.configureResolver() returns the ConfigurableMavenResolverSystem which has the new methods.. 
> Either the JavaDoc needs update, or the Maven.resolver() methods needs to return the new interface?



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)