[shrinkwrap-issues] [JBoss JIRA] (SHRINKDESC-163) Deal with descriptors with multiple possible roots better

[Ralf Battenfeld (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKDESC-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121207#comment-13121207 ] 

Ralf Battenfeld commented on SHRINKDESC-163:
--------------------------------------------

Hi Toby and Bob, can you have a look at: https://github.com/rbattenfeld/descriptors/tree/SHRINKDESC-163

I added to the three module descriptors an interface called WrapperModuleDescriptor<T>. The corresponding implementation class is called: WrapperModuleDescriptorImpl. 

As the name indicates, the idea is to wrap, or was at the beginning. I didn't saw a reason for making a base descriptor class. I also couldn't find a reason for making a real base descriptor with all features.

But maybe I am wrong and didn't get all of your points. Just let me know what you think and I will work more on this.

> Deal with descriptors with multiple possible roots better
> ---------------------------------------------------------
>
>                 Key: SHRINKDESC-163
>                 URL: https://issues.jboss.org/browse/SHRINKDESC-163
>             Project: ShrinkWrap Descriptors
>          Issue Type: Feature Request
>    Affects Versions: 2.0.0-alpha-8
>            Reporter: Toby Crawley
>            Assignee: Ralf Battenfeld
>
> When implementing SHRINKDESC-162, I created three different
> descriptors for module.xml ({{ModuleDescriptor}},
> {{ModuleAliasDescriptor}}, {{ModuleAbsentDescriptor}}) corresponding to
> the three root elements listed in the xsd ({{module}}, {{module-alias}},
> {{module-absent}}). This works fine if you are generating a module.xml,
> but if you are loading in an existing file, you don't know without
> looking at the file contents to know which type to instantiate.
> It would be swell if there was a way for descriptors to support
> multiple roots and do the correct thing. Or does that already exist
> and I missed it?



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)