[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-252) Build Failing Locally in AdditionalRemoteRepositoryTestCase

[Andrew Rubinger (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKRES-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283035#comment-13283035 ] 

Andrew Rubinger edited comment on SHRINKRES-252 at 8/23/16 3:50 PM:
--------------------------------------------------------------------

It's the ISP I'm on, Verizon:

{code}
[alr at tubescreamer apache-maven-3.3.9]$ dig doesnotexistXhHT98.com

; <<>> DiG 9.10.4-P2-RedHat-9.10.4-1.P2.fc24 <<>> doesnotexistXhHT98.com
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 11952
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4000
;; QUESTION SECTION:
;doesnotexistXhHT98.com.		IN	A

;; ANSWER SECTION:
doesnotexistXhHT98.com.	0	IN	A	92.242.140.21
{code}

Instead of returning that the DNS entry does not exist, it pretends it does so that it can return a search results page:

http://searchassist.verizon.com/main?ParticipantID=euekiz39ksg8nwp7iqj2fp5wzfwi5q76&FailedURI=http%3A%2F%2Fdoesnotexistxhht98.com%2F&FailureMode=1&Implementation=&AddInType=4&Version=pywr1.0&ClientLocation=us

Breaking contracts everywhere.  The question is if we can/should alter the test suite to not break when ISPs do some stuff like this.

Thoughts [~mjobanek]?


was (Author: alrubinger):
It's the ISP I'm on, Verizon:

{code}
[alr at tubescreamer apache-maven-3.3.9]$ dig doesnotexistXhHT98.com

; <<>> DiG 9.10.4-P2-RedHat-9.10.4-1.P2.fc24 <<>> doesnotexistXhHT98.com
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 11952
;; flags: qr rd ra; QUERY: 1, ANSWER: 1, AUTHORITY: 0, ADDITIONAL: 1

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4000
;; QUESTION SECTION:
;doesnotexistXhHT98.com.		IN	A

;; ANSWER SECTION:
doesnotexistXhHT98.com.	0	IN	A	92.242.140.21
{code}

Instead of returning that the DNS entry does not exist, it pretends it does so that it can return an search results page:

http://searchassist.verizon.com/main?ParticipantID=euekiz39ksg8nwp7iqj2fp5wzfwi5q76&FailedURI=http%3A%2F%2Fdoesnotexistxhht98.com%2F&FailureMode=1&Implementation=&AddInType=4&Version=pywr1.0&ClientLocation=us

Breaking contracts everywhere.  The question is if we can/should alter the test suite to not break when ISPs do some stuff like this.

Thoughts [~mjobanek]?

> Build Failing Locally in AdditionalRemoteRepositoryTestCase
> -----------------------------------------------------------
>
>                 Key: SHRINKRES-252
>                 URL: https://issues.jboss.org/browse/SHRINKRES-252
>             Project: ShrinkWrap Resolvers
>          Issue Type: Bug
>          Components: maven
>         Environment: ALR's local machine; does not appear to be an issue on CI server
>            Reporter: Andrew Rubinger
>            Assignee: Matous Jobanek
>
> {{shouldOverloadRepository(org.jboss.shrinkwrap.resolver.impl.maven.integration.AdditionalRemoteRepositoryTestCase)  Time elapsed: 0.611 sec  <<< FAILURE!
> java.lang.AssertionError: Expected exception: org.jboss.shrinkwrap.resolver.api.NoResolvedResultException
> 	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:32)
> 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> 	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
> 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
> 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)
> shouldOverloadCentral(org.jboss.shrinkwrap.resolver.impl.maven.integration.AdditionalRemoteRepositoryTestCase)  Time elapsed: 0.523 sec  <<< FAILURE!
> java.lang.AssertionError: Expected exception: org.jboss.shrinkwrap.resolver.api.NoResolvedResultException
> 	at org.junit.internal.runners.statements.ExpectException.evaluate(ExpectException.java:32)
> 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:367)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:274)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> 	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:161)
> 	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:290)
> 	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:242)
> 	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:121)}}
> However not present on authoritative CI Server:
> https://shrinkwrap.ci.cloudbees.com/job/ShrinkWrap_Resolver_upstream-master-JDK7/211/testReport/org.jboss.shrinkwrap.resolver.impl.maven.integration/AdditionalRemoteRepositoryTestCase/
> Anyone else can reproduce?



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)