[shrinkwrap-issues] [JBoss JIRA] (SHRINKWRAP-511) ArchiveFactory fails to close ZipFile and retains a Windows file lock

[George Gastaldi (JIRA)]

    [ https://issues.jboss.org/browse/SHRINKWRAP-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13352497#comment-13352497 ] 

George Gastaldi commented on SHRINKWRAP-511:
--------------------------------------------

It seems that even with the proposed fix the lock is still retained. Calls to new ZipFile() should be explicitly closed.

> ArchiveFactory fails to close ZipFile and retains a Windows file lock
> ---------------------------------------------------------------------
>
>                 Key: SHRINKWRAP-511
>                 URL: https://issues.jboss.org/browse/SHRINKWRAP-511
>             Project: ShrinkWrap
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 1.2.6
>         Environment: Windows only - All versions
>            Reporter: Andy Gumbrecht
>             Fix For: 1.2.7
>
>
> org/jboss/shrinkwrap/api/ArchiveFactory.java:187
> The ZipFile is never closed and results in a file lock on Windows only platforms.
> https://github.com/shrinkwrap/shrinkwrap/pull/102



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)