[shrinkwrap-issues] [JBoss JIRA] (SHRINKRES-299) ClasspathWorkspaceReader does not support "Maven CI Friendly Versions" (e.g. ${revision})

[Bartosz Majsak (Jira)]

     [ https://issues.redhat.com/browse/SHRINKRES-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bartosz Majsak updated SHRINKRES-299:
-------------------------------------
    Fix Version/s: 3.1.4


> ClasspathWorkspaceReader does not support "Maven CI Friendly Versions" (e.g. ${revision})
> -----------------------------------------------------------------------------------------
>
>                 Key: SHRINKRES-299
>                 URL: https://issues.redhat.com/browse/SHRINKRES-299
>             Project: ShrinkWrap Resolvers
>          Issue Type: Bug
>          Components: maven
>    Affects Versions: 3.1.3
>            Reporter: Falko Modler
>            Priority: Major
>             Fix For: 3.1.4
>
>
> Maven 3.5.0 introduced [Maven CI Friendly Versions|https://maven.apache.org/maven-ci-friendly.html].
> A version element with such a setup can look like this:
> {code:xml}
> <version>${revision}</version>
> {code}
> Via debugging I found out that {{ClasspathWorkspaceReader}} will never be able to match a given {{artifact}} (which contains the interpolated, final version) with the respective workspace/classpath entry because in {{ClasspathWorkspaceReader.createFoundArtifact(File)}} it just loads the XML document, without any interpolation or even {{parent}} lookup.
> This issuse is very similar to SHRINKRES-223. Nevertheless, I saw/see two reasons for a separate issue:
> - I am not sure that the setup in SHRINKRES-223 is even officially supported by Maven (in contrast to "CI Friendly Versions")
> - I will come up with a PR that re-uses {{.flattened-pom.xml}} (created by {{flatten-maven-plugin}}, see "Install / Deploy" part on the "CI Friendly Versions" page) and that will be of no use for SHRINKRES-223



--
This message was sent by Atlassian Jira
(v7.13.8#713008)