[teiid-commits] teiid SVN: r929 - in trunk/connectors/connector-jdbc/src: test/java/org/teiid/connector/jdbc/mysql and 1 other directory.

teiid-commits at lists.jboss.org teiid-commits at lists.jboss.org
Wed May 13 13:45:21 EDT 2009


Author: li.liang
Date: 2009-05-13 13:45:21 -0400 (Wed, 13 May 2009)
New Revision: 929

Modified:
   trunk/connectors/connector-jdbc/src/main/java/org/teiid/connector/jdbc/mysql/MySQLTranslator.java
   trunk/connectors/connector-jdbc/src/test/java/org/teiid/connector/jdbc/mysql/TestMySQLTranslator.java
Log:
TEIID-591 Remove optional parenthesis for joins for all but MySql connector.

Modified: trunk/connectors/connector-jdbc/src/main/java/org/teiid/connector/jdbc/mysql/MySQLTranslator.java
===================================================================
--- trunk/connectors/connector-jdbc/src/main/java/org/teiid/connector/jdbc/mysql/MySQLTranslator.java	2009-05-13 17:45:04 UTC (rev 928)
+++ trunk/connectors/connector-jdbc/src/main/java/org/teiid/connector/jdbc/mysql/MySQLTranslator.java	2009-05-13 17:45:21 UTC (rev 929)
@@ -103,4 +103,7 @@
 		return MySQLCapabilities.class;
 	}
 	
+    public boolean useParensForJoins() {
+    	return true;
+    }
 }

Modified: trunk/connectors/connector-jdbc/src/test/java/org/teiid/connector/jdbc/mysql/TestMySQLTranslator.java
===================================================================
--- trunk/connectors/connector-jdbc/src/test/java/org/teiid/connector/jdbc/mysql/TestMySQLTranslator.java	2009-05-13 17:45:04 UTC (rev 928)
+++ trunk/connectors/connector-jdbc/src/test/java/org/teiid/connector/jdbc/mysql/TestMySQLTranslator.java	2009-05-13 17:45:21 UTC (rev 929)
@@ -200,5 +200,13 @@
             input, 
             output, TRANSLATOR);        
     }
-          
+
+    @Test public void testJoins() throws Exception {
+        String input = "select smalla.intkey from bqt1.smalla inner join bqt1.smallb on smalla.stringkey=smallb.stringkey cross join bqt1.mediuma"; //$NON-NLS-1$
+        String output = "SELECT SmallA.IntKey FROM (SmallA INNER JOIN SmallB ON SmallA.StringKey = SmallB.StringKey) CROSS JOIN MediumA"; //$NON-NLS-1$
+          
+        TestMySQLTranslator.helpTestVisitor(MetadataFactory.BQT_VDB,
+            input, 
+            output, TRANSLATOR);        
+    }
 }




More information about the teiid-commits mailing list