[teiid-commits] teiid SVN: r932 - trunk/connector-api/src/main/java/org/teiid/connector/visitor/util.

[teiid-commits at lists.jboss.org]

Author: li.liang
Date: 2009-05-13 15:38:15 -0400 (Wed, 13 May 2009)
New Revision: 932

Modified:
   trunk/connector-api/src/main/java/org/teiid/connector/visitor/util/SQLStringVisitor.java
Log:
TEIID-591 Remove optional parenthesis for joins for all but MySql connector.

Modified: trunk/connector-api/src/main/java/org/teiid/connector/visitor/util/SQLStringVisitor.java
===================================================================
--- trunk/connector-api/src/main/java/org/teiid/connector/visitor/util/SQLStringVisitor.java	2009-05-13 19:28:55 UTC (rev 931)
+++ trunk/connector-api/src/main/java/org/teiid/connector/visitor/util/SQLStringVisitor.java	2009-05-13 19:38:15 UTC (rev 932)
@@ -597,7 +597,7 @@
      */
     public void visit(IJoin obj) {
         IFromItem leftItem = obj.getLeftItem();
-        if(leftItem instanceof IJoin) {
+        if(useParensForJoins() && leftItem instanceof IJoin) {
             buffer.append(LPAREN);
             append(leftItem);
             buffer.append(RPAREN);
@@ -635,7 +635,7 @@
               .append(SPACE);
         
         IFromItem rightItem = obj.getRightItem();
-        if(rightItem instanceof IJoin) {
+        if(rightItem instanceof IJoin && (useParensForJoins() || obj.getJoinType() == IJoin.JoinType.CROSS_JOIN)) {
             buffer.append(LPAREN);
             append(rightItem);
             buffer.append(RPAREN);
@@ -1030,5 +1030,8 @@
         visitor.append(obj);
         return visitor.toString();
     }
-
+    
+    protected boolean useParensForJoins() {
+    	return false;
+    }
 }