[teiid-designer-dev] [Teiid-Designer/teiid-designer] 5e279e: TEIIDDES-1697: Replace project loop-throughs with ...

Barry LaFond blafond at redhat.com
Thu May 2 08:34:28 EDT 2013 

  Branch: refs/heads/master
  Home:   https://github.com/Teiid-Designer/teiid-designer
  Commit: 5e279e2c44df502721d5f801768d9ada1a05e470
      https://github.com/Teiid-Designer/teiid-designer/commit/5e279e2c44df502721d5f801768d9ada1a05e470
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2013-05-02 (Thu, 02 May 2013)

  Changed paths:
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/ModelerCore.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/DotProjectUtils.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/ModelWorkspace.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/ModelWorkspaceImpl.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/ModelWorkspaceInfo.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImporterWizard.java
    M plugins/org.teiid.designer.dqp/src/org/teiid/designer/runtime/preview/PreviewManager.java
    M plugins/org.teiid.designer.extension.ui/src/org/teiid/designer/extension/ui/wizards/NewMedWizard.java
    M plugins/org.teiid.designer.jdbc.ui/src/org/teiid/designer/jdbc/ui/wizards/JdbcSourceSelectionPage.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/SelectTranslatorAndTargetPage.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/TeiidImportWizard.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/TeiidMetadataImportSourcePage.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/viewsupport/DesignerPropertiesUtil.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/wizards/ImportVdbMainPage.java
    M tests/org.teiid.designer.core.test.framework/src/org/teiid/designer/core/workspace/FakeModelWorkspace.java
    M tests/org.teiid.designer.core.test/src/org/teiid/designer/core/workspace/TestDotProjectUtil.java

  Log Message:
  -----------
  TEIIDDES-1697: Replace project loop-throughs with utility methods

* DotProjectUtils provides a helpful method for returning the collection of
  open modelling projects. Instead of code iterating through all projects
  and determining the same result, delegate to the utility method.

* DotProjectUtils
 * Throw single Exception rather than the singular versions as it then
   avoids the need for client code to depend on the jdom plugin.
 * Migrate hasNature method from ModelerCore since this is a better logical
   home for it.

* [Fake]ModelWorkspace[Impl,Info]
 * Remove the getNonModellingResources method since it is performant
   expensive and ultimately pointless


  Commit: e04c42330547068c2f8d5d8a9cc868b22c1d5f58
      https://github.com/Teiid-Designer/teiid-designer/commit/e04c42330547068c2f8d5d8a9cc868b22c1d5f58
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2013-05-02 (Thu, 02 May 2013)

  Changed paths:
    M tests/org.teiid.designer.core.test.framework/src/org/teiid/designer/core/workspace/MockFileResource.java
    A tests/org.teiid.designer.core.test.framework/src/org/teiid/designer/core/workspace/MockProject.java
    M tests/org.teiid.designer.core.test/src/org/teiid/designer/core/workspace/TestDotProjectUtil.java

  Log Message:
  -----------
  TEIIDDES-1697: Fixes tests as a consequence of further use of DotProjectUtils

* MockFileResource
* MockProject
 * Improve the sanity of these classes and implement enough methods for
   a fake project to be returned by any MockFileResource
 * By default, a temp file is instantiated (although not actually created)
   to represent the .project file and the project is set to both open and
   accessible.

* TestDotProjectUtil
 * Due to making the mock project accessible and open, a different path is
   taken by the code to check for the project's nature. Thus, the test
   must be slightly modified to correctly mirror the changes.


  Commit: 301b01b510426e7133f4d61c2288d5b6dacb7df2
      https://github.com/Teiid-Designer/teiid-designer/commit/301b01b510426e7133f4d61c2288d5b6dacb7df2
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2013-05-02 (Thu, 02 May 2013)

  Changed paths:
    M plugins/org.teiid.designer.advisor.ui/src/org/teiid/designer/advisor/ui/views/status/StatusValidationHelper.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/builder/ModelBuildUtil.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/builder/ModelBuilder.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/OrganizeImportCommandFinderHelper.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/RelatedResourceFinder.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/ResourceRefactorCommand.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/ModelWorkspaceImpl.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/WorkspaceResourceFinderUtil.java
    M plugins/org.teiid.designer.metamodels.builder.execution/src/org/teiid/designer/metamodels/builder/execution/addingExtensionsToModel.jpage
    M plugins/org.teiid.designer.metamodels.xsd/src/org/teiid/designer/metamodels/xsd/aspects/imports/XsdSchemaDerivativeAspect.java
    M plugins/org.teiid.designer.udf/src/org/teiid/designer/udf/UdfManager.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/actions/BuildImportsAllAction.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/actions/DeleteEObjectAction.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/RefactorResourcesUtils.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/viewsupport/DesignerProperties.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/viewsupport/DesignerPropertiesUtil.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/viewsupport/ModelUtilities.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/util/VdbUiRefactorHandler.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbUtil.java

  Log Message:
  -----------
  TEIIDDES-1697: Refactor the WorkspaceResourceFinderUtil class

* WorkspaceResourceFinderUtil
 * Returns collections of resources rather than arrays since most uses
   simply iterate over the collection
 * Ensures collections have been genericised
 * Fixes missing comments
 * Rather than searching for all possible resources in the workspace,
  ** If a resource is given then use its project as a search limiter;
  ** With no resource paramater, search only open modelling projects and
     to avoid looping twice use a visitor where possible to analyse the
     resources as they are found
 * Improves readability by avoiding large if-clauses
 * Combines 2 versions of getResourcesThatUse (singular and recursive) into
   1 method with a depth parameter


  Commit: 0db98121aa3482e888607a490cccb3cd6a65648c
      https://github.com/Teiid-Designer/teiid-designer/commit/0db98121aa3482e888607a490cccb3cd6a65648c
  Author: Barry LaFond <blafond at redhat.com>
  Date:   2013-05-02 (Thu, 02 May 2013)

  Changed paths:
    M plugins/org.teiid.designer.advisor.ui/src/org/teiid/designer/advisor/ui/views/status/StatusValidationHelper.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/ModelerCore.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/builder/ModelBuildUtil.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/builder/ModelBuilder.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/OrganizeImportCommandFinderHelper.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/RelatedResourceFinder.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/ResourceRefactorCommand.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/DotProjectUtils.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/ModelWorkspace.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/ModelWorkspaceImpl.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/ModelWorkspaceInfo.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/workspace/WorkspaceResourceFinderUtil.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImporterWizard.java
    M plugins/org.teiid.designer.dqp/src/org/teiid/designer/runtime/preview/PreviewManager.java
    M plugins/org.teiid.designer.extension.ui/src/org/teiid/designer/extension/ui/wizards/NewMedWizard.java
    M plugins/org.teiid.designer.jdbc.ui/src/org/teiid/designer/jdbc/ui/wizards/JdbcSourceSelectionPage.java
    M plugins/org.teiid.designer.metamodels.builder.execution/src/org/teiid/designer/metamodels/builder/execution/addingExtensionsToModel.jpage
    M plugins/org.teiid.designer.metamodels.xsd/src/org/teiid/designer/metamodels/xsd/aspects/imports/XsdSchemaDerivativeAspect.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/SelectTranslatorAndTargetPage.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/TeiidImportWizard.java
    M plugins/org.teiid.designer.transformation.ui/src/org/teiid/designer/transformation/ui/wizards/file/TeiidMetadataImportSourcePage.java
    M plugins/org.teiid.designer.udf/src/org/teiid/designer/udf/UdfManager.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/actions/BuildImportsAllAction.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/actions/DeleteEObjectAction.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/RefactorResourcesUtils.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/viewsupport/DesignerProperties.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/viewsupport/DesignerPropertiesUtil.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/viewsupport/ModelUtilities.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/util/VdbUiRefactorHandler.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/wizards/ImportVdbMainPage.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbUtil.java
    M tests/org.teiid.designer.core.test.framework/src/org/teiid/designer/core/workspace/FakeModelWorkspace.java
    M tests/org.teiid.designer.core.test.framework/src/org/teiid/designer/core/workspace/MockFileResource.java
    A tests/org.teiid.designer.core.test.framework/src/org/teiid/designer/core/workspace/MockProject.java
    M tests/org.teiid.designer.core.test/src/org/teiid/designer/core/workspace/TestDotProjectUtil.java

  Log Message:
  -----------
  Merge pull request #148 from phantomjinx/performance-bottlenecks

Performance bottlenecks when building projects


Compare: https://github.com/Teiid-Designer/teiid-designer/compare/948a688a64f5...0db98121aa34

More information about the teiid-designer-dev mailing list