[teiid-designer-dev] [Teiid-Designer/teiid-designer] 77524f: TEIIDDES-2156: Ensures eclipse builder is not stop...

Barry LaFond blafond at redhat.com
Mon May 19 08:55:34 EDT 2014 

  Branch: refs/heads/8.3.x
  Home:   https://github.com/Teiid-Designer/teiid-designer
  Commit: 77524f0f03bbd67033e8d609fa4847dfbe75dd7c
      https://github.com/Teiid-Designer/teiid-designer/commit/77524f0f03bbd67033e8d609fa4847dfbe75dd7c
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2014-05-19 (Mon, 19 May 2014)

  Changed paths:
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/i18n.properties
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/util/FileUtils.java
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/util/OperationUtil.java
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/util/ZipUtil.java
    M plugins/org.teiid.designer.advisor.ui/src/org/teiid/designer/advisor/ui/dialogs/GenerateRestWarDialog.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/AbstractRefactorModelHandler.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/IRefactorModelHandler.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/RefactorModelExtensionManager.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImportDifferencesPage.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImporterUiI18n.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/i18n.properties
    M plugins/org.teiid.designer.ddl.importer/src/org/teiid/designer/ddl/importer/DdlImporter.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/actions/DeployVdbAction.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/actions/ExecuteVDBAction.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/actions/GenerateRestWarAction.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/preview/PreviewDataWorker.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/server/editor/TeiidServerEditor.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/vdb/ExecuteVdbAction.java
    M plugins/org.teiid.designer.dqp/src/org/teiid/designer/runtime/DqpPlugin.java
    M plugins/org.teiid.designer.dqp/src/org/teiid/designer/runtime/preview/PreviewManager.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/i18n.properties
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/rename/RenameResourceCompositeChange.java
    A plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/util/ErrorHandler.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/Messages.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/build/VdbExtractModelsSyncVdbMarkerResolution.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/build/VdbMigrateXsdFilesMarkerResolution.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/build/VdbModelPathResolution.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/editor/VdbEditor.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/messages.properties
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/util/VdbResourceFinder.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/Vdb.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbEntry.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbFileEntry.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbModelEntry.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbRefactorHandler.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbUtil.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/refactor/VdbResourceChange.java
    M tests/org.teiid.designer.vdb.test/src/org/teiid/designer/vdb/VdbEntryTest.java

  Log Message:
  -----------
  TEIIDDES-2156: Ensures eclipse builder is not stopped by runtime exceptions

* Executing an unreliable operation in OperationUtil can throw an exception
  Previously this was a runtime exception which stops the eclipse builder
  dead in its tracks.

* Fixes this issue by throwing a normal exception and ensuring that all
  clients properly handle the exception by exposing it to the user in some
  form of dialog.

* ErrorHandler
 * Catch-all for taking an exception and displaying it in the eclipse
   built-in error dialog.

* Where methods and functions are low-level, the exception is simply thrown

* Only when the class appears at the UI layer is the exception handled and
  displayed.

* VdbEditor
 * Since this is a UI editor, a correctly initialised Vdb is vital. Since
   the latter depends on OperationUtil, display an informative error panel
   if the editor's Vdb instance cannot be created.



* Test
 * GenerateRestWarDialog
 * Rename of vdb, model resource
 * DDLImporter
 * Deploy Vdb action
 * Execute Vdb action from runtime/ui/actions
 * Execute Vdb action from runtime/ui/vdb
 * GenerateRestWarAction
 * TeiidServerEditor initialising editor
 * VdbExtractModelsSyncVdbMarkerResolution
 * VdbModelPathResolution
 * VdbEditor
  ** save
  ** add model
  ** update UDF jars
  ** add udf jar

Conflicts:
	plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/actions/GenerateRestWarAction.java
	plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/Messages.java
	plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/editor/VdbEditor.java
	plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/messages.properties


  Commit: 750b5ae5fc2fbce793a22fb7e9b935070d7900cf
      https://github.com/Teiid-Designer/teiid-designer/commit/750b5ae5fc2fbce793a22fb7e9b935070d7900cf
  Author: Paul Richardson <p.g.richardson at redhat.com>
  Date:   2014-05-19 (Mon, 19 May 2014)

  Changed paths:
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/CoreModelerPlugin.java
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/util/FileUtils.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImporterPage.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImporterWizard.java
    M plugins/org.teiid.designer.ddl.importer/src/org/teiid/designer/ddl/importer/DdlImporter.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/TeiidImportManager.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/properties/extension/ChooseVdbFileFromWorkspaceDialog.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/build/VdbModelNotInProjectMarkerResolution.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/editor/VdbEditor.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/Vdb.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbModelEntry.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbUtil.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/manifest/ModelElement.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/manifest/ProblemElement.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/manifest/VdbElement.java

  Log Message:
  -----------
  TEIIDDES-2156: Eliminate use of CoreModelerPlugin.toRuntimeException

* The function CoreModelerPlugin.toRuntimeException, by throwing a runtime
  exception, has the potential to drastically upset Eclipse's normal
  operations, eg. stopping build dead.

* Removes uses of toRuntimeException and replace with appropriately handled
  normal exceptions either properly thrown or caught and conveyed to the
  display (logged or shown in a dialog).

Conflicts:
	plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/TeiidImportManager.java
	plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/editor/VdbEditor.java
	plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/wizards/NewVdbWizard.java
	plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbModelEntry.java
	plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbUtil.java


  Commit: 695ee742e1e1e396aebe73c74c28a1ddfe2274b4
      https://github.com/Teiid-Designer/teiid-designer/commit/695ee742e1e1e396aebe73c74c28a1ddfe2274b4
  Author: Barry LaFond <blafond at redhat.com>
  Date:   2014-05-19 (Mon, 19 May 2014)

  Changed paths:
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/CoreModelerPlugin.java
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/i18n.properties
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/util/FileUtils.java
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/util/OperationUtil.java
    M plugins/org.teiid.core.designer/src/org/teiid/core/designer/util/ZipUtil.java
    M plugins/org.teiid.designer.advisor.ui/src/org/teiid/designer/advisor/ui/dialogs/GenerateRestWarDialog.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/AbstractRefactorModelHandler.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/IRefactorModelHandler.java
    M plugins/org.teiid.designer.core/src/org/teiid/designer/core/refactor/RefactorModelExtensionManager.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImportDifferencesPage.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImporterPage.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImporterUiI18n.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/DdlImporterWizard.java
    M plugins/org.teiid.designer.ddl.importer.ui/src/org/teiid/designer/ddl/importer/ui/i18n.properties
    M plugins/org.teiid.designer.ddl.importer/src/org/teiid/designer/ddl/importer/DdlImporter.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/actions/DeployVdbAction.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/actions/ExecuteVDBAction.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/actions/GenerateRestWarAction.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/preview/PreviewDataWorker.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/server/editor/TeiidServerEditor.java
    M plugins/org.teiid.designer.dqp.ui/src/org/teiid/designer/runtime/ui/vdb/ExecuteVdbAction.java
    M plugins/org.teiid.designer.dqp/src/org/teiid/designer/runtime/DqpPlugin.java
    M plugins/org.teiid.designer.dqp/src/org/teiid/designer/runtime/preview/PreviewManager.java
    M plugins/org.teiid.designer.teiidimporter.ui/src/org/teiid/designer/teiidimporter/ui/wizard/TeiidImportManager.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/i18n.properties
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/properties/extension/ChooseVdbFileFromWorkspaceDialog.java
    M plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/refactor/rename/RenameResourceCompositeChange.java
    A plugins/org.teiid.designer.ui/src/org/teiid/designer/ui/util/ErrorHandler.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/Messages.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/build/VdbExtractModelsSyncVdbMarkerResolution.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/build/VdbMigrateXsdFilesMarkerResolution.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/build/VdbModelNotInProjectMarkerResolution.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/build/VdbModelPathResolution.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/editor/VdbEditor.java
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/messages.properties
    M plugins/org.teiid.designer.vdb.ui/src/org/teiid/designer/vdb/ui/util/VdbResourceFinder.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/Vdb.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbEntry.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbFileEntry.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbModelEntry.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbRefactorHandler.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/VdbUtil.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/manifest/ModelElement.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/manifest/ProblemElement.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/manifest/VdbElement.java
    M plugins/org.teiid.designer.vdb/src/org/teiid/designer/vdb/refactor/VdbResourceChange.java
    M tests/org.teiid.designer.vdb.test/src/org/teiid/designer/vdb/VdbEntryTest.java

  Log Message:
  -----------
  Merge pull request #354 from phantomjinx/8.3.x

8.3.x


Compare: https://github.com/Teiid-Designer/teiid-designer/compare/4f4389a1db3b...695ee742e1e1

More information about the teiid-designer-dev mailing list