[teiid-issues] [JBoss JIRA] (TEIID-2567) issues with permission element in vdb-deployer.xsd contains problematic choice node

[Barry LaFond (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12787971#comment-12787971 ] 

Barry LaFond commented on TEIID-2567:
-------------------------------------

We can manage the limitations/issues with allowable choices for attributes in Designer/VDB Editor, if attributes are a cleaner for you guys.

As far as keeping a choice node option, I'd push for creating a complex type <data-access> so the xsd would read as below. This would allow additional choices in the future if you envisioned them... being added.

{code:xml}
<xs:element name="permission" minOccurs="0" maxOccurs="unbounded">
    <xs:complexType>
      <xs:sequence>                            
	    <xs:element name="resource-name" type="xs:string"/>
	    <xs:choice>
	    	<element name="data-access" type="dataaccess"/>
	    	<element name="allow-language" type="xs:boolean"/>
	    </xs:choice>
      </xs:sequence>      
  </xs:complexType>
</xs:element>  
	  
<xs:complexType name="dataaccess">
	<xs:sequence> 
	     <xs:element name="allow-create" type="xs:boolean" minOccurs="0"/>
	     <xs:element name="allow-read" type="xs:boolean" minOccurs="0"/>
	     <xs:element name="allow-update" type="xs:boolean" minOccurs="0"/>
		 <xss:element name="allow-delete" type="xs:boolean" minOccurs="0"/>
		 <xs:element name="allow-execute" type="xs:boolean" minOccurs="0"/>
		 <xs:element name="allow-alter" type="xs:boolean" minOccurs="0"/>	
		 <xs:element name="condition" minOccurs="0">
		  <xs:complexType>
			<xs:simpleContent>
      			  <xs:extension base="xs:string">
        			<xs:attribute name="constraint" type="xs:boolean" default="true"/>
        		  </xs:extension>
    			</xs:simpleContent>
    		</xs:complexType>
		</xs:element>
		<xs:element name="mask" minOccurs="0">
		  <xs:complexType>
			<xs:simpleContent>
      			  <xs:extension base="xs:string">
        		    <xs:attribute name="order" type="xs:string"/>
        		  </xs:extension>
    			</xs:simpleContent>
    		  </xs:complexType>
		</xs:element>
	</xs:sequence>     
</xs:complexType> 
{code}  
                
> issues with permission element in vdb-deployer.xsd contains problematic choice node
> -----------------------------------------------------------------------------------
>
>                 Key: TEIID-2567
>                 URL: https://issues.jboss.org/browse/TEIID-2567
>             Project: Teiid
>          Issue Type: Task
>    Affects Versions: 8.4
>            Reporter: Barry LaFond
>            Assignee: Steven Hawkins
>             Fix For: 8.4.1
>
>
> Having a lot of trouble trying to tweak our JaxB VDB element classes to accommodate the permission's choice node which contains a <sequence> and an <element>.
> This structure is basically impossible to unmarshall using JAXB annotations (i.e. @XmlElements(value= {}) )
> Would clean things up to convert the <allow-language> element to an attribute:  <xs:attribute name="allow-language" type="xs:boolean"/> and place it on the <permission> element AND remove the <choice> node entirely

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira