[teiid-issues] [JBoss JIRA] (TEIID-2660) OData procedure issues

Thu Sep 12 09:22:03 EDT 2013

    [ https://issues.jboss.org/browse/TEIID-2660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803872#comment-12803872 ] 

Steven Hawkins commented on TEIID-2660:
---------------------------------------

> Yes, I am not sure why I did not choose named parameters, that was wrong.

The parser needed updated as we would have only supported named parameters without a return parameter.  Now we should be good.  This also allows for parameters to be omitted/defaultable.

>  I can not say I understand negate one fully.

It looked to me like combining the negation with numerical constants was not needed - as long as the literal is entered without a space -2.0f for example it will be parsed as -2.0.  Also the handling of the negation was only being done in the non prepared case.  In the prepared case it was silently dropped (it's a little weird but if for example the user entered x=- 2 we'd treat that as x=? but not apply negation to the parameter value).

> OData procedure issues
> ----------------------
>
>                 Key: TEIID-2660
>                 URL: https://issues.jboss.org/browse/TEIID-2660
>             Project: Teiid
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 8.3
>            Reporter: Steven Hawkins
>            Assignee: Steven Hawkins
>            Priority: Critical
>             Fix For: 8.5
>
>
> Calling a procedure through Teiid's odata interface has several issues.  First is that joda time values are passed directly - which the runtime will not be able to convert to analogous Teiid time types.  Ultimately this appears as a classcastexception, which is due to logic in the joda time AbstractPartial.compareTo method (which may be reported with an erroneous message and seems odd in general, but is their way of saying the comparison is invalid).
> Another is that the logic assumes that the url will be called with the positional ordering of the parameters preserved.  We should use named parameters instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira