[teiid-issues] [JBoss JIRA] (TEIID-4126) PlanToProcessConverter logical conjunction contains condition with no effect (x==x)

[Steven Hawkins (JIRA)]

     [ https://issues.jboss.org/browse/TEIID-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Hawkins resolved TEIID-4126.
-----------------------------------
    Resolution: Done


Thanks Jan.  Corrected the check to be against the parent.  In this case the case the check for use_all was effectively sufficient as except/intersect all is not supported, but it's good to have the set operation check correct as well.

> PlanToProcessConverter logical conjunction contains condition with no effect (x==x)
> -----------------------------------------------------------------------------------
>
>                 Key: TEIID-4126
>                 URL: https://issues.jboss.org/browse/TEIID-4126
>             Project: Teiid
>          Issue Type: Quality Risk
>          Components: Query Engine
>    Affects Versions: 8.9
>            Reporter: Jan Stastny
>            Assignee: Steven Hawkins
>            Priority: Minor
>             Fix For: 9.0
>
>
> There is a condition with no effect on resulting boolean value:
> https://github.com/teiid/teiid/blob/6e31f7c3a576ae85fd96dd4003790064552b9110/engine/src/main/java/org/teiid/query/optimizer/relational/PlanToProcessConverter.java#L163
> The code in question is:
> {code:java}
> childNode.getProperty(Info.SET_OPERATION) == childNode.getProperty(Info.SET_OPERATION)
> {code}
> which is always true (comparation of exactly the same objects).
> Given the fact that the boolean expression is a conjunction, it does not affect the accessibility of the following code.
> But if it should be another condition instead, it might be a problem.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)