[teiid-issues] [JBoss JIRA] (TEIID-4437) Convert Teiid build to use "feature-pack"

[Kylin Soong (JIRA)]

    [ https://issues.jboss.org/browse/TEIID-4437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13319218#comment-13319218 ] 

Kylin Soong edited comment on TEIID-4437 at 11/9/16 1:03 AM:
-------------------------------------------------------------

Arquillian tests results:
{code}
Results :

Failed tests: 
  IntegrationTestDeployment.testGetRequests:372 expected:<0> but was:<1>
  IntegrationTestDeployment.testTraslators:195 [jpa2, prestodb, mysql5, swagger, salesforce, metamatrix, ingres, ldap, sap-gateway, derby, mysql, ingres93, salesforce-34, jdbc-simple, loopback, teiid, oracle, sybase, odata4, impala, ucanaccess, cassandra, hive, simpledb, access, vertica, map-cache, google-spreadsheet, h2, modeshape, osisoft-pi, jdbc-ansi, accumulo, odata, file, postgresql, sqlserver, redshift, hsql, greenplum, solr, hana, ws, mongodb, hbase, sybaseiq, netezza, teradata, sap-nw-gateway, informix, excel, intersystems-cache, db2, actian-vector, olap] expected:<56> but was:<55>
  IntegrationTestRestWebserviceGeneration.testSemanticVersion:260 sample_2.1.1.war not found
Tests in error: 
  IntegrationTestDeployment.testGeometry:754 » TeiidSQL TEIID30328 Unable to eva...

Tests run: 42, Failures: 3, Errors: 1, Skipped: 4
{code}

h2. IntegrationTestDeployment.testTraslators()
For the feature pack merge, the below line be removed
{code}
<translator name="delegator" module="org.jboss.teiid.api"/>
{code} 
Do we need keep this? if no we need update the arquillian test


was (Author: kylin):
Arquillian tests results:
{code}
Results :

Failed tests: 
  IntegrationTestDeployment.testGetRequests:372 expected:<0> but was:<1>
  IntegrationTestDeployment.testTraslators:195 [jpa2, prestodb, mysql5, swagger, salesforce, metamatrix, ingres, ldap, sap-gateway, derby, mysql, ingres93, salesforce-34, jdbc-simple, loopback, teiid, oracle, sybase, odata4, impala, ucanaccess, cassandra, hive, simpledb, access, vertica, map-cache, google-spreadsheet, h2, modeshape, osisoft-pi, jdbc-ansi, accumulo, odata, file, postgresql, sqlserver, redshift, hsql, greenplum, solr, hana, ws, mongodb, hbase, sybaseiq, netezza, teradata, sap-nw-gateway, informix, excel, intersystems-cache, db2, actian-vector, olap] expected:<56> but was:<55>
  IntegrationTestRestWebserviceGeneration.testSemanticVersion:260 sample_2.1.1.war not found
Tests in error: 
  IntegrationTestDeployment.testGeometry:754 » TeiidSQL TEIID30328 Unable to eva...

Tests run: 42, Failures: 3, Errors: 1, Skipped: 4
{code}

For the feature pack merge, the below line be removed
{code}
<translator name="delegator" module="org.jboss.teiid.api"/>
{code} 
Do we need keep this? if no we need update the arquillian test

> Convert Teiid build to use "feature-pack"
> -----------------------------------------
>
>                 Key: TEIID-4437
>                 URL: https://issues.jboss.org/browse/TEIID-4437
>             Project: Teiid
>          Issue Type: Task
>          Components: Build/Kits
>            Reporter: Ramesh Reddy
>            Assignee: Kylin Soong
>             Fix For: 9.2
>
>
> Change the current build process to build "feature-packs" for project, and then based on feature pack, build 
> - WildFly Server distribution
> -WildFly Server Overlay distribution
> Teiid currently have distributions, but not based on feature-packs, they need to be. Other distributions like AdminShell do not fall into this category. Only distributions that has WF involvement need a feature -pack (this is important to remember).
> Currently Teiid uses "kit" directory in many different projects along with "wildfly-dist.xml" to populate "modules" directory. A feature-pack does EXACTLY same thing, but more with checks and balances. A feature pack, makes sure all the dependencies are met based on module.xml and module.xml defines the maven artifact rather than JAR file. i.e. it defines a metadata file, from which it can be build the zip file that "wildfly-dist.xml" assembly is currently doing. It also can has capabilities to "configure" the WF subsystem. That is manually done or done through CLI currently, using this part will be new.
> Implementation Rules 
> 1) Every where we have "kit" directory, that module REQUIRES a "feature-pack" module. That means, every translator and resource-adapter gets it's own, and Teiid engine modules separately gets its own module. The reason to keep/create multiple modules is STRICTLY to keep the "modules" directory in feature-pack aligned ONE TO ONE with project that feature-pack represents. Otherwise, as developer we will NOT know which project is bringing in certain dependency, if all the modules are in single place. So, this is more about management of dependencies in a sane way. (Teiid did have all the modules in once place before in 7.x/8.x time, it is a nightmare to handle growing dependencies with our translators)
> 2) NONE of the work we have is useless/or need to be redone, most everything we have PERFECTLY maps to this effort, except for for configuration part.
> 3) For translator and resource adapter pair, I recommend that we pull them into single sub folder, and create a single feature pack for it. For example:
> we have
> {code}
> connectors/translator-mongodb
> connectors/connector-mongodb
> {code}
> I would like see we design as
> {code}
> connectors
>          /mongdb
>               /translator-mongodb
>               /connector-mongodb
>               /feature-pack-mongodb
> {code}
> No need to create "dist" packages for any resource-adapters or translators. As I mentioned in the beginning of the issue, there are two distributions, they are built using these various feature-packs.
> 4) I would like to see a clean move of "kit/wildfly/modules" to "feature-packs" using "git", NOT CUT n PASTE where we loose the GIT history.  This will preserve the confidence that what we have currently is EXACTLY same as in future with feature-packs.
> 5) When designing the "feature-pack" projects, they ABSOLUTELY MUST NOT define any dependencies in their pom.xml other than Teiid project(s) they represent and any other feature-pack they refer to. (Kylin this is what cause most concern from your design for me)



--
This message was sent by Atlassian JIRA
(v7.2.3#72005)