[teiid-issues] [JBoss JIRA] (TEIID-5574) Clarify buffer manager property names

[Steven Hawkins (Jira)]

    [ https://issues.jboss.org/browse/TEIID-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676053#comment-13676053 ] 

Steven Hawkins commented on TEIID-5574:
---------------------------------------

To expand on the last comment.

old:
{code}
	BUFFER_SERVICE_ELEMENT("buffer-service"),
	USE_DISK_ATTRIBUTE("use-disk", "buffer-service-use-disk"),
	PROCESSOR_BATCH_SIZE_ATTRIBUTE("processor-batch-size", "buffer-service-processor-batch-size"),
	MAX_PROCESSING_KB_ATTRIBUTE("max-processing-kb", "buffer-service-max-processing-kb"),
	MAX_RESERVED_KB_ATTRIBUTE("max-reserve-kb", "buffer-service-max-reserve-kb"),
	MAX_FILE_SIZE_ATTRIBUTE("max-file-size", "buffer-service-max-file-size"),
	MAX_BUFFER_SPACE_ATTRIBUTE("max-buffer-space", "buffer-service-max-buffer-space"),
	MAX_OPEN_FILES_ATTRIBUTE("max-open-files", "buffer-service-max-open-files"),
	MEMORY_BUFFER_SPACE_ATTRIBUTE("memory-buffer-space", "buffer-service-memory-buffer-space"),
	MEMORY_BUFFER_OFFHEAP_ATTRIBUTE("memory-buffer-off-heap", "buffer-service-memory-buffer-off-heap"),
	MAX_STORAGE_OBJECT_SIZE_ATTRIBUTE("max-storage-object-size", "buffer-service-max-storage-object-size"),
	INLINE_LOBS("inline-lobs", "buffer-service-inline-lobs"),
	ENCRYPT_FILES_ATTRIBUTE("encrypt-files", "buffer-service-encrypt-files"),
{code}
	
New:
{code}
        BUFFER_SERVICE_ELEMENT("buffer-manager"),
        PROCESSOR_BATCH_SIZE_ATTRIBUTE("processor-batch-size", "buffer-manager-processor-batch-size"),
        INLINE_LOBS("inline-lobs", "buffer-manager-inline-lobs"),
    
        MAX_PROCESSING_KB_ATTRIBUTE("heap-max-processing-kb", "buffer-manager-heap-max-processing-kb"),
        MAX_RESERVED_KB_ATTRIBUTE("heap-max-reserve-kb", "buffer-manager-heap-max-reserve-kb"),

	USE_DISK_ATTRIBUTE("storage-enabled", "buffer-manager-storage-enabled"),
        MAX_STORAGE_OBJECT_SIZE_ATTRIBUTE("storage-max-object-size", "buffer-manager-storage-max-object-size"),
    
        MEMORY_BUFFER_SPACE_ATTRIBUTE("fixed-memory-space-mb", "buffer-manager-fixed-memory-space-mb"),
        MEMORY_BUFFER_OFFHEAP_ATTRIBUTE("fixed-memory-off-heap", "buffer-manager-fixed-memory-off-heap"),
    
        MAX_FILE_SIZE_ATTRIBUTE("disk-max-file-size", "buffer-manager-disk-max-file-size"),
        MAX_BUFFER_SPACE_ATTRIBUTE("disk-max-space-mb", "buffer-manager-disk-max-space-mb"),
        MAX_OPEN_FILES_ATTRIBUTE("disk-max-open-files", "buffer-manager-disk-max-open-files"),
        ENCRYPT_FILES_ATTRIBUTE("disk-encrypt-files", "buffer-manager-disk-encrypt-files"),
{code}

There's probably a fancy way to do this with versioned configurations, but it seems just as easy to just add handling for both and deprecate the old.

There would be a corresponding change to EmbeddedConfiguration, and clarifications to the EngineStatisticsBean.

> Clarify buffer manager property names
> -------------------------------------
>
>                 Key: TEIID-5574
>                 URL: https://issues.jboss.org/browse/TEIID-5574
>             Project: Teiid
>          Issue Type: Quality Risk
>          Components: Query Engine, Server
>            Reporter: Steven Hawkins
>            Assignee: Steven Hawkins
>            Priority: Major
>             Fix For: 12.0
>
>
> Where possible the buffer manager properties should be better differentiated.  Instead of max-buffer-space for example, we could have max-buffer-disk-space-mb.



--
This message was sent by Atlassian Jira
(v7.12.1#712002)