[teiid-issues] [JBoss JIRA] (TEIIDSB-197) Add a module for each external source

[Steven Hawkins (Jira)]

    [ https://issues.redhat.com/browse/TEIIDSB-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082797#comment-14082797 ] 

Steven Hawkins commented on TEIIDSB-197:
----------------------------------------

> This is already done too, there is no particular logic about data sources in Operator, it is currently driven through the config file or given name in the CR. I guess the version number is still not, will see how to improve that!

I don't think you follow me.  I'm not specifically talking about code vs. configuration.  Just the fact that the operator has knowledge like: https://github.com/teiid/teiid-operator/blob/master/build/conf/config.yaml is problematic.  If you represented each jdbc source as a maven artifact, then those versions would be managed as maven dependencies.

> This is already the case with the latest changes.

That is not correct either.  You mean to say that it is embedded in the generated json file https://github.com/teiid/teiid-operator/blob/01dd29e95e14ba2dcbc5e750bb9d6ed73651025b/build/conf/connection_factories.json#L10

That however is also not necessary.  Spring has property handling logic, for example https://www.baeldung.com/spring-boot-environmentpostprocessor, that would allow you modify the env properties as needed on startup before they are consumed by other components.

Essentially what I'm getting at is that the operator doesn't really need intimate or generated configuration to do it's job.

> Add a module for each external source
> -------------------------------------
>
>                 Key: TEIIDSB-197
>                 URL: https://issues.redhat.com/browse/TEIIDSB-197
>             Project: Teiid Spring Boot
>          Issue Type: Enhancement
>            Reporter: Steven Hawkins
>            Assignee: Ramesh Reddy
>            Priority: Major
>
> To simplify the logic in the operator each external source should be represented by a maven artifact - org.teiid:spring-data-x.  Any dependency management would be handled in that module and not in the operator - to remove the need for a config file containing driver versions.  Additionally property handling should be moved into Teiid Spring Boot such that the operator does not need to know what property prefix is expected.



--
This message was sent by Atlassian Jira
(v7.13.8#713008)