<div dir="ltr">Hi Jason,<div><br></div><div>thanks for your feedback, there seems to be several solutions better than mine :)</div><div><br></div><div>Cheers</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 25, 2014 at 2:02 AM, Jason Greene <span dir="ltr"><<a href="mailto:jason.greene@redhat.com" target="_blank">jason.greene@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This looks nice to me. Although for efficiency you would want to initialize the methods and cache them. If you prefer you could use the servlet API which allows you to filter methods with annotations as well.<br>
<div><div class="h5"><br>
On Sep 24, 2014, at 3:04 AM, Luke Ambrogio <<a href="mailto:gryzlaw@hotmail.com">gryzlaw@hotmail.com</a>> wrote:<br>
<br>
> So I've decided to start using Undertow, both as an experiment and due to the great results it achieved in benchmark tests. And while I think it's fantastic there's a feature which is either missing or I can't find.<br>
><br>
> I want to develop a RESTful web service so it's important for me to identify which HTTP method is being called. Now I can get this from RequestMethod in the HttpServerExchange parameter but if had to that for every handler that would become tedious.<br>
><br>
> My solution, which works but feels wrong, is this:<br>
><br>
> Created an annotation interface called HTTPMethod:<br>
><br>
> @Retention(RetentionPolicy.RUNTIME)<br>
> @Target(ElementType.METHOD)<br>
><br>
><br>
> public @interface HTTPMethod {<br>
><br>
><br>
><br>
> public enum Method {<br>
><br>
><br>
> OTHER<br>
> , GET, PUT, POST,<br>
> DELETE<br>
><br>
> }<br>
><br>
><br>
><br>
> Method method() default Method.OTHER;<br>
> an "abstract" class (which is not abstract):<br>
><br>
> public abstract class RESTfulHandler implements HttpHandler {<br>
><br>
><br>
><br>
> @Override<br>
> public void handleRequest(HttpServerExchange hse) throws Exception {<br>
><br>
><br>
><br>
> for (Method method : this.getClass().getDeclaredMethods()) {<br>
><br>
><br>
><br>
> // if method is annotated with @Test<br>
><br>
><br>
> if (method.isAnnotationPresent(HTTPMethod.class)) {<br>
><br>
><br>
><br>
> Annotation annotation = method.getAnnotation(HTTPMethod.class);<br>
><br>
><br>
> HTTPMethod test = (HTTPMethod) annotation;<br>
><br>
><br>
><br>
> switch (test.method()) {<br>
><br>
><br>
> case PUT:<br>
><br>
><br>
> if (hse.getRequestMethod().toString().equals("PUT")) {<br>
><br>
> method<br>
> .invoke(this);<br>
><br>
><br>
> }<br>
><br>
><br>
> break;<br>
><br>
><br>
><br>
> case POST:<br>
><br>
><br>
> if (hse.getRequestMethod().toString().equals("POST")) {<br>
><br>
> method<br>
> .invoke(this);<br>
><br>
><br>
> }<br>
><br>
><br>
> break;<br>
><br>
><br>
><br>
> case GET:<br>
><br>
><br>
> if (hse.getRequestMethod().toString().equals("GET")) {<br>
><br>
> method<br>
> .invoke(this);<br>
><br>
><br>
> }<br>
><br>
><br>
> break;<br>
><br>
><br>
><br>
> case DELETE:<br>
><br>
><br>
> if (hse.getRequestMethod().toString().equals("DELETE")) {<br>
><br>
> method<br>
> .invoke(this);<br>
><br>
><br>
> }<br>
><br>
><br>
> break;<br>
><br>
><br>
> case OTHER:<br>
><br>
><br>
> if (hse.getRequestMethod().toString().equals("OTHER")) {<br>
><br>
> method<br>
> .invoke(this);<br>
><br>
><br>
> }<br>
><br>
><br>
> break;<br>
><br>
><br>
> }<br>
><br>
><br>
> if (test.method() == HTTPMethod.Method.PUT) {<br>
><br>
> method<br>
> .invoke(this);<br>
><br>
><br>
> }<br>
><br>
><br>
> }<br>
><br>
><br>
> }<br>
> }<br>
> }<br>
><br>
> and an implementation of both the above:<br>
><br>
> public class ItemHandler extends RESTfulHandler{<br>
><br>
><br>
><br>
> @HTTPMethod(method=GET)<br>
> public void getAllItems()<br>
> {<br>
><br>
><br>
> System.out.println("GET");<br>
> }<br>
><br>
><br>
><br>
> @HTTPMethod(method=POST)<br>
> public void addItem()<br>
> {<br>
><br>
><br>
> System.out.println("POST");<br>
><br>
><br>
> }<br>
><br>
><br>
><br>
> @HTTPMethod<br>
> public void doNothing()<br>
> {<br>
><br>
><br>
> System.out.println("OTHERS");<br>
><br>
><br>
> }<br>
> }<br>
><br>
> Now as I said, it works, but I'm sure that the abstract class and it's implementation have something missing so that they glue correctly. So my question is two fold:<br>
><br>
> 1) Is there a better / proper way to filter HTTP requests in Undertow? 2) What is the correct way of using annotations correctly correctly in the above case?<br>
><br>
> Thanks<br>
><br>
><br>
><br>
</div></div><span class="">> _______________________________________________<br>
> undertow-dev mailing list<br>
> <a href="mailto:undertow-dev@lists.jboss.org">undertow-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/undertow-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/undertow-dev</a><br>
<br>
</span>--<br>
Jason T. Greene<br>
WildFly Lead / JBoss EAP Platform Architect<br>
JBoss, a division of Red Hat<br>
<br>
<br>
</blockquote></div><br></div>