<div dir="ltr">Just to follow up on this would it need a separate git repo or could it just be a new maven sub project?<div><br></div><div>I don't know much about extending JUnit runners but it sounds like the DefaultServer class can be renamed to UndertowRunner and moved to a new sub project. Each other project could then add it as a test dependency and update imports accordingly.</div><div><br></div><div>Is that all that would be required? Maybe it could be split up a bit or move more testing related utils as well.</div><div><br></div><div>Bill</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 16, 2017 at 8:59 PM, Bill O'Neil <span dir="ltr"><<a href="mailto:bill@dartalley.com" target="_blank">bill@dartalley.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Whatever you think is best. I'm fine following Steve's approach. Undertow starts up and shuts down pretty quick.</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Jan 15, 2017 at 5:32 PM, Stuart Douglas <span dir="ltr"><<a href="mailto:sdouglas@redhat.com" target="_blank">sdouglas@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We do publish tests-jars, so you can actually use DefaultServer,<br>
however I agree that this is not really ideal.<br>
<br>
I think the ideal solution would be to take the core functionality<br>
from DefaultServer and create a new repo (undertow-test-runner) and<br>
create some kind of UndertowRunner class that is based on<br>
DefaultServer. Does this sound reasonable?<br>
<span class="m_-8393814615695738216HOEnZb"><font color="#888888"><br>
<br>
Stuart<br>
</font></span><div class="m_-8393814615695738216HOEnZb"><div class="m_-8393814615695738216h5"><br>
On Sun, Jan 15, 2017 at 7:22 AM, Bill O'Neil <<a href="mailto:bill@dartalley.com" target="_blank">bill@dartalley.com</a>> wrote:<br>
> Hello,<br>
><br>
> How would you recommend testing custom HttpHanders? The DefaultServer class<br>
> in core part of the test code so it is not included in the jar for reuse.<br>
> Would it be reasonable to pull testing utils into their own project so it<br>
> can be reused? Or would you recommend just mocking a HttpServerExchange and<br>
> passing that to the HttpHandler?<br>
><br>
> Thanks,<br>
> Bill<br>
><br>
</div></div><div class="m_-8393814615695738216HOEnZb"><div class="m_-8393814615695738216h5">> ______________________________<wbr>_________________<br>
> undertow-dev mailing list<br>
> <a href="mailto:undertow-dev@lists.jboss.org" target="_blank">undertow-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/undertow-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailma<wbr>n/listinfo/undertow-dev</a><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>