<div dir="ltr">Adding this also to undertow-dev ML.</div><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 11, 2018 at 7:09 PM Pavol Loffay <<a href="mailto:ploffay@redhat.com">ploffay@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Wed, Jul 11, 2018 at 6:51 PM Alessio Soldano <<a href="mailto:asoldano@redhat.com" target="_blank">asoldano@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div>I've pushed a fix for the ResteasyServletInitializer to master <a href="https://github.com/resteasy/Resteasy/commit/1b3870b0b7210a8b4ab70eb51fc903abdaac9b41" target="_blank">https://github.com/resteasy/Resteasy/commit/1b3870b0b7210a8b4ab70eb51fc903abdaac9b41</a> ; we'll double check it with tck before next release, anyway.</div><div><br></div><div>Going back to the issue, 3.0.24 basically removes any doubt I had regarding recent asyn changes, it's quite an old version.</div><div>The AsyncListener ... is this <a href="https://github.com/pavolloffay/smallrye-opentracing/blob/00f6c4dced4990b4e7ec0af57671399b6877f8a4/tck/src/test/java/io/smallrye/opentracing/ServletContextTracingInstaller.java#L27-L31" target="_blank">https://github.com/pavolloffay/smallrye-opentracing/blob/00f6c4dced4990b4e7ec0af57671399b6877f8a4/tck/src/test/java/io/smallrye/opentracing/ServletContextTracingInstaller.java#L27-L31</a> what you're referring to and which you believe is not working? it's really a servlet/undertow thing btw...<br></div></div></blockquote><div><br></div><div>Yes the AsyncListener is added in the filter which your link references. </div><div><br></div><div>Martin also commented here <a href="https://issues.jboss.org/browse/UNDERTOW-1258?focusedCommentId=13603809&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13603809" target="_blank">https://issues.jboss.org/browse/UNDERTOW-1258?focusedCommentId=13603809&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-13603809</a> on this issues.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 11, 2018 at 2:40 PM, Martin Kouba <span dir="ltr"><<a href="mailto:mkouba@redhat.com" target="_blank">mkouba@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Also note that we use a modified ResteasyServletInitializer to init resteasy in the TCK: <a href="https://github.com/smallrye/smallrye-opentracing/pull/4/files#diff-ec8fa59dbdd6534b47de691e766aff61" rel="noreferrer" target="_blank">https://github.com/smallrye/smallrye-opentracing/pull/4/files#diff-ec8fa59dbdd6534b47de691e766aff61</a><br>
<br>
M<br>
<br>
Dne 11.7.2018 v 13:29 Martin Kouba napsal(a):<div class="m_-7415894139823583454gmail-m_-5027692518097954309HOEnZb"><div class="m_-7415894139823583454gmail-m_-5027692518097954309h5"><br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
You're right, 3.0.24.Final.<br>
<br>
Dne 11.7.2018 v 13:09 Pavol Loffay napsal(a):<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
Hi Alessio,<br>
<br>
resteasy version in Thorntail and SmallRye should be the same - 3.0.24.Final. I have added Ken and Martin in case I am wrong.<br>
<br>
Regards,<br>
<br>
On Wed, Jul 11, 2018 at 11:30 AM Alessio Soldano <<a href="mailto:asoldano@redhat.com" target="_blank">asoldano@redhat.com</a> <mailto:<a href="mailto:asoldano@redhat.com" target="_blank">asoldano@redhat.com</a>>> wrote:<br>
<br>
CC-ing Pavol, not sure he's subscribed to the list<br>
<br>
On Wed, Jul 11, 2018 at 11:29 AM, Alessio Soldano<br>
<<a href="mailto:asoldano@redhat.com" target="_blank">asoldano@redhat.com</a> <mailto:<a href="mailto:asoldano@redhat.com" target="_blank">asoldano@redhat.com</a>>> wrote:<br>
<br>
Hi Pavol,<br>
I'm forwarding this to the dev-list, so that the whole team can<br>
read and help.<br>
Can you start by telling which version of RESTEasy was used in<br>
the previous and current integration?<br>
There's been a bunch of changes around async lately, which might<br>
possibly be related to the issue you're seeing.<br>
<br>
Cheers<br>
<br>
---------- Forwarded message ----------<br>
From: *Pavol Loffay* <<a href="mailto:ploffay@redhat.com" target="_blank">ploffay@redhat.com</a><br>
<mailto:<a href="mailto:ploffay@redhat.com" target="_blank">ploffay@redhat.com</a>>><br>
Date: Tue, Jul 10, 2018 at 6:15 PM<br>
Subject: Microprofile-OpenTracing Async issues in TCK when<br>
running on Wildfly<br>
To: Alessio Soldano <<a href="mailto:asoldano@redhat.com" target="_blank">asoldano@redhat.com</a><br>
<mailto:<a href="mailto:asoldano@redhat.com" target="_blank">asoldano@redhat.com</a>>><br>
Cc: jean-frederic clere <<a href="mailto:jclere@redhat.com" target="_blank">jclere@redhat.com</a><br>
<mailto:<a href="mailto:jclere@redhat.com" target="_blank">jclere@redhat.com</a>>><br>
<br>
<br>
Hi Alessio,<br>
<br>
Jean Frederic pointed me to you as the contact for issues<br>
related to Resteasy/undertow in Wildfly.<br>
<br>
I am migrating Microprofile-OpenTracing implementation from<br>
Thorntail [1] to SmallRye [2]. TCK in Thorntail was passing<br>
fine. Now when it's deployed on Wildfly a test for async<br>
endpoint is failing. Basically, the AsyncListener (added in<br>
filter) which reports some data is never called.<br>
<br>
The issue is described on the PR<br>
<a href="https://github.com/smallrye/smallrye-opentracing/pull/4#issuecomment-403847333" rel="noreferrer" target="_blank">https://github.com/smallrye/smallrye-opentracing/pull/4#issuecomment-403847333</a>. <br>
<br>
<br>
Could you please have a look and comment on the PR? Is it safe<br>
to rely on AsyncListener. Can it happen that the listener added<br>
in the filter will not be invoked?<br>
<br>
[1]:<br>
<a href="https://github.com/thorntail/thorntail/tree/master/fractions/microprofile/microprofile-opentracing" rel="noreferrer" target="_blank">https://github.com/thorntail/thorntail/tree/master/fractions/microprofile/microprofile-opentracing</a> <br>
[2]: <a href="https://github.com/smallrye/smallrye-opentracing/pull/4" rel="noreferrer" target="_blank">https://github.com/smallrye/smallrye-opentracing/pull/4</a><br>
<br>
Regards,<br>
--<br>
PAVOL LOFFAY<br>
<br>
SOFTWARE ENGINEER<br>
<br>
Red Hat<<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
<br>
M: +41791562647<br>
<br>
<<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
<br>
<br>
<br>
<br>
--<br>
Alessio Soldano<br>
<br>
Associate Manager<br>
<br>
Red Hat<br>
<br>
<<a href="https://www.redhat.com" rel="noreferrer" target="_blank">https://www.redhat.com</a>><br>
<br>
<<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
<br>
<br>
<br>
<br>
--<br>
Alessio Soldano<br>
<br>
Associate Manager<br>
<br>
Red Hat<br>
<br>
<<a href="https://www.redhat.com" rel="noreferrer" target="_blank">https://www.redhat.com</a>><br>
<br>
<<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
<br>
<br>
<br>
-- <br>
<br>
PAVOL LOFFAY<br>
<br>
SOFTWARE ENGINEER<br>
<br>
Red Hat<<a href="https://www.redhat.com/" rel="noreferrer" target="_blank">https://www.redhat.com/</a>><br>
<br>
M: +41791562647 <javascript:void(0);><br>
<br>
<<a href="https://red.ht/sig" rel="noreferrer" target="_blank">https://red.ht/sig</a>><br>
<br>
</blockquote>
<br>
</blockquote>
<br>
-- <br>
Martin Kouba<br>
Senior Software Engineer<br>
Red Hat, Czech Republic<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="m_-7415894139823583454gmail-m_-5027692518097954309gmail_signature"><div dir="ltr"><div>
<p style="font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>Alessio</span> <span>Soldano</span></p>
<p style="font-weight:normal;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>Associate Manager</span><span style="font-weight:normal;color:rgb(170,170,170);margin:0px"></span></p>
<p style="font-weight:normal;margin:0px;font-size:10px;color:rgb(153,153,153)"><a style="color:rgb(0,136,206);font-size:10px;margin:0px;text-decoration:none;font-family:overpass,sans-serif" href="https://www.redhat.com" target="_blank">Red Hat <span><br><br></span></a></p>
<table border="0"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"> <img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a> </td>
</tr></tbody></table>
</div></div></div>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="m_-7415894139823583454gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>PAVOL</span> <span>LOFFAY</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SOFTWARE ENGINEER</span><span style="color:rgb(170,170,170);margin:0px"></span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat<span></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span>M: <a style="color:rgb(0,136,206);font-size:11px;margin:0px">+41791562647</a> </span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td></tr></tbody></table><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr></tr></tbody></table></div></div></div></div></div></div></div></div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-weight:bold;margin:0px;padding:0px;font-size:14px;text-transform:uppercase"><span>PAVOL</span> <span>LOFFAY</span></p><p style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:10px;margin:0px 0px 4px;text-transform:uppercase"><span>SOFTWARE ENGINEER</span><span style="color:rgb(170,170,170);margin:0px"></span></p><p style="font-family:overpass,sans-serif;margin:0px;font-size:10px;color:rgb(153,153,153)"><a href="https://www.redhat.com/" style="color:rgb(0,136,206);margin:0px" target="_blank">Red Hat<span></span></a></p><p style="font-family:overpass,sans-serif;margin:0px 0px 6px;font-size:10px;color:rgb(153,153,153)"><span>M: <a href="javascript:void(0);" style="color:rgb(0,136,206);font-size:11px;margin:0px" target="_blank">+41791562647</a> </span></p><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr><td width="100px"><a href="https://red.ht/sig" target="_blank"><img src="https://www.redhat.com/files/brand/email/sig-redhat.png" width="90" height="auto"></a></td></tr></tbody></table><table border="0" style="color:rgb(0,0,0);font-family:overpass,sans-serif;font-size:medium"><tbody><tr></tr></tbody></table></div></div></div></div></div></div></div>