<div dir="ltr"><div dir="ltr">Here is the Pull Request: <a href="https://github.com/undertow-io/undertow/pull/699">https://github.com/undertow-io/undertow/pull/699</a></div><div dir="ltr"><br></div><div>Let me know if you have questions or propose changes. Currently, TCP over IPv4 and IPv6 and the LOCAL protocol is supported. UDP and Unix sockets aren't. I tested this successfully on AWS with a Network Load Balancer and Proxy Protocol v2 enabled. It would be good to test with Proxy protocol v1 as well, just to make sure I didn't break that. The code will automatically determine which version is used.</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 10, 2018 at 3:47 PM Ulrich Herberg <<a href="mailto:ulrich.herberg@oath.com">ulrich.herberg@oath.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Great! Let me clean up the code a bit and then create a PR (assuming that is the process?)</div><br><div class="gmail_quote"><div dir="ltr">On Mon, Dec 10, 2018 at 3:32 PM Stuart Douglas <<a href="mailto:sdouglas@redhat.com" target="_blank">sdouglas@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">This sounds great, we would definitely be interested in supporting version 2 as well.<div><br></div><div>Stuart</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Dec 11, 2018 at 9:26 AM Ulrich Herberg <<a href="mailto:ulrich.herberg@oath.com" target="_blank">ulrich.herberg@oath.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>We want to use Undertow in our company (Oath/Yahoo/Verizon) in an AWS environment. Since we plan to use AWS Network Load Balancers (NLB) using Fargate, we need the proxy protocol in order to get the source IP address of an incoming HTTP(S) packet. However, Undertow only supports Proxy Protocol Version 1. I have implemented version 2 (for IPv4 and IPv6), including unit tests and it works fine. I wonder if I can contribute the code to the open source release of Undertow.</div><div><br></div><div>Let me know if you are interested, then I can provide the code.</div><div><br></div><div>Best regards</div><div>Ulrich</div></div>
_______________________________________________<br>
undertow-dev mailing list<br>
<a href="mailto:undertow-dev@lists.jboss.org" target="_blank">undertow-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/undertow-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/undertow-dev</a></blockquote></div>
</blockquote></div>
</blockquote></div>