<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 15, 2019 at 8:59 PM Darran Lofthouse <<a href="mailto:darran.lofthouse@jboss.com">darran.lofthouse@jboss.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">I have been looking at the steps required to migrate the WildFly Elytron integration to Undertow 3 from Undertow 2.<div><br></div><div>Overall it seems minimal changes are required but I was thinking if there could be an opportunity to evolve the API within Undertow 2 making migration to 3 easier in the future.</div><div><br></div><div>One example being on SSSessionInfo we make use of the following method: -</div><div><br></div><div>void renegotiate(HttpServerExchange exchange, SslClientAuthMode sslClientAuthMode) throws IOException;<br></div><div><br></div><div>which has now been changed to: -</div><div><br></div><div>void renegotiate(HttpServerExchange exchange, ClientAuth sslClientAuthMode) throws IOException;<br></div><div><br></div><div>The first form is making use of Xnio API and the second is using Netty API.</div><div><br></div><div>If this was deprecated in Undertow 2 and a pure Undertow variant added it could be usable both in 2 and 3.</div></div></div></blockquote><div><br></div><div>This is a good idea. If you see areas where this can be done can you file a JIRA (or better yet open a PR)?</div><div><br></div><div>In this case I think we should get rid of the Netty one entirely, and just have an agnostic one.</div><div><br></div><div>Maybe we also need an Undertow 2.1 branch, which will aim to improve compatibility by adding methods like this that will work in both versions.</div><div><br></div><div>Stuart</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div><br></div><div>I suspect a number of the other changes breaking API compatibility could be handled in a similar way.</div><div><br></div><div>Regards,</div><div>Darran Lofthouse.</div><div><br></div><div><br></div><div><br></div><div><br></div><div><br></div></div></div>
_______________________________________________<br>
undertow-dev mailing list<br>
<a href="mailto:undertow-dev@lists.jboss.org" target="_blank">undertow-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/undertow-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/undertow-dev</a></blockquote></div></div>