[webbeans-commits] Webbeans SVN: r3209 - in tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event: eventTypes and 1 other directories.

[webbeans-commits at lists.jboss.org]

Author: dallen6
Date: 2009-07-25 07:19:40 -0400 (Sat, 25 Jul 2009)
New Revision: 3209

Modified:
   tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/EventTest.java
   tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/eventTypes/EventTypesTest.java
   tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/fires/FireEventTest.java
Log:
Marked some tests broken which are not properly testing the assertions for events

Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/EventTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/EventTest.java	2009-07-25 11:18:51 UTC (rev 3208)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/EventTest.java	2009-07-25 11:19:40 UTC (rev 3209)
@@ -90,22 +90,24 @@
       getCurrentManager().fireEvent("string event", new AnnotationLiteral<NotABindingType>(){});
    }
 
-   @Test(groups = { "events" }, expectedExceptions = { IllegalArgumentException.class })
+   @Test(groups = { "events", "broken" }, expectedExceptions = { IllegalArgumentException.class })
    @SpecAssertions({
       @SpecAssertion(section = "10.1", id = "aa"),
       @SpecAssertion(section = "11.3.10", id = "c")
    })
+   //TODO This test does not have a template variable nor is there a way to write that in Java
    public void testManagerFireEventWithEventTypeParametersFails()
    {
       ATemplatedEventType<String> anEvent = new ATemplatedEventType<String>();
       getCurrentManager().fireEvent(anEvent);
    }
 
-   @Test(groups = { "events" }, expectedExceptions = { IllegalArgumentException.class })
-   @SpecAssertions({
-      @SpecAssertion(section = "10.1", id = "aa"),
-      @SpecAssertion(section = "11.3.10", id = "c")
-   })
+//   @Test(groups = { "events" }, expectedExceptions = { IllegalArgumentException.class })
+//   @SpecAssertions({
+//      @SpecAssertion(section = "10.1", id = "aa"),
+//      @SpecAssertion(section = "11.3.10", id = "c")
+//   })
+   // The spec no longer prohibits wildcards
    public void testBeanManagerFireEventWithEventTypeWildcardsFails()
    {
       ATemplatedEventType<?> anEventOnAnyType = new ATemplatedEventType<String>();

Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/eventTypes/EventTypesTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/eventTypes/EventTypesTest.java	2009-07-25 11:18:51 UTC (rev 3208)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/eventTypes/EventTypesTest.java	2009-07-25 11:19:40 UTC (rev 3209)
@@ -57,15 +57,17 @@
       assert observer.getTotalEventsObserved() == 4;
    }
    
-   @Test(groups = { "event", "review" }, expectedExceptions = IllegalArgumentException.class)
+   @Test(groups = { "event", "broken", "review" }, expectedExceptions = IllegalArgumentException.class)
    @SpecAssertion(section = "10.1", id = "cb")
+   //TODO There is still no type variable involved in this test nor is there a way to write this in Java
    public void testEventTypeFiredByEventInterfaceMayNotContainTypeVariable()
    {
       getInstanceByType(TuneSelect.class).soloArtistPlaying(new Artist<Solo>());
    }
    
-   @Test(groups = { "event", "review" }, expectedExceptions = IllegalArgumentException.class)
+   @Test(groups = { "event", "review", "broken" }, expectedExceptions = IllegalArgumentException.class)
    @SpecAssertion(section = "10.1", id = "cb")
+   //TODO There is still no type variable involved in this test nor is there a way to write this in Java
    public void testEventTypeFiredByBeanManagerMayNotContainTypeVariable()
    {
       getCurrentManager().fireEvent(new Artist<Solo>());

Modified: tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/fires/FireEventTest.java
===================================================================
--- tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/fires/FireEventTest.java	2009-07-25 11:18:51 UTC (rev 3208)
+++ tck/trunk/impl/src/main/java/org/jboss/jsr299/tck/tests/event/fires/FireEventTest.java	2009-07-25 11:19:40 UTC (rev 3209)
@@ -34,7 +34,7 @@
     * This test verifies that the {@link Event} object capable of firing
     * {@link Item} objects can be injected with the {@link @Any} binding type
     * and that the injected object can be used to fire an event. The
-    * functionality is verified by checking that the cooresponding observer gets
+    * functionality is verified by checking that the corresponding observer gets
     * invoked.
     */
    @Test(groups = "events")
@@ -199,8 +199,9 @@
       assert housekeeping.getItemsTainted().contains(water);
    }
    
-   @Test(groups = "events", expectedExceptions = IllegalArgumentException.class)
+   @Test(groups = {"events", "broken"}, expectedExceptions = IllegalArgumentException.class)
    @SpecAssertion(section = "10.3.1", id = "f")
+   //TODO There does not seem to be any way to write code that compiles and tests this assertion
    public void testEventFireThrowsExceptionIfEventObjectContainsTypeVariable()
    {
       MiniBar miniBar = getInstanceByType(MiniBar.class);