From emijiang6 at googlemail.com Sun Aug 2 17:45:18 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Sun, 2 Aug 2015 22:45:18 +0100 Subject: [weld-dev] Weld Performance improvement In-Reply-To: References: <5594E9CB.3090501@redhat.com> <55ACCA58.1040804@redhat.com> <55ACF527.4000104@redhat.com> Message-ID: Hi Jozef/Martin, Can you please commit the performance changes for this jar and release 2.2.15.Final as soon as possible? Thanks Emily On Tue, Jul 21, 2015 at 12:31 PM, Emily Jiang wrote: > Thank you Jozef and Martin! I am looking forward to consume 2.2.15.Final. > > On Mon, Jul 20, 2015 at 2:18 PM, Jozef Hartinger > wrote: > >> Hi Emily, >> >> thanks for the feedback. We're currently busy with other releases but >> I'll try to get 2.2.15.Final released soon. >> >> Jozef >> >> On 20.7.2015 14:43, Emily Jiang wrote: >> >>> The test applications we used were attached to the jira >>> https://developer.jboss.org/message/926035#926035. >>> >>> You can compare the responding time between two servlet requests. >>> >>> Can you commit the current changes in the release 2.2.15.Final because >>> I plan to consume this release for other jira fixes as well? >>> Thanks >>> Emily >>> >>> On Mon, Jul 20, 2015 at 11:15 AM, Martin Kouba >> > wrote: >>> >>> Hi Emily, >>> >>> it's great to hear there is a performance improvement (although 1% >>> is not that much). We're working on further performance improvements >>> in this area [1]. >>> >>> However, 23% additional overhead seems to me too much. Would it be >>> possible to share your performance test case / test application? We >>> could run similar tests in our environment and verify that there's >>> no integration problem. >>> >>> Martin >>> >>> [1] >>> https://issues.jboss.org/browse/WELD-1970 >>> >>> >>> Dne 20.7.2015 v 11:12 Emily Jiang napsal(a): >>> >>> Hi Jozef, Martin, >>> >>> Sorry for the delay! I have the performance figure collected >>> eventually. >>> With this Jira's changes, it shows 1% performance improvement. >>> This is a >>> step in the right direction but there is still a performance hit >>> (23% >>> worse) when turning on CDI. Would you like to commit this change >>> so that >>> I can reconsume this release? It will be great if a further >>> performance >>> improvement can be done. I am happy to collect the performance >>> benchmark >>> if needed. >>> >>> Thanks >>> Emily >>> >>> On Thu, Jul 2, 2015 at 8:35 AM, Jozef Hartinger >>> >>> >> >>> wrote: >>> >>> Hi Emily, >>> >>> that should not be a problem. Would it be possible for you >>> to test >>> the performance improvement before we actually do the >>> release? I can >>> prepare a separate branch or send you a binary. I would >>> like to see >>> how much improvement this makes in your benchmark. >>> >>> Jozef >>> >>> >>> On 07/01/2015 06:19 PM, Emily Jiang wrote: >>> >>> Is it possible to get the following jira fix committed >>> to >>> 2.2.15.Final? >>> >>> https://issues.jboss.org/browse/WELD-1931 >>> >>> I would like to consume this and see how much >>> improvement has been >>> made. >>> >>> -- >>> Thanks >>> Emily >>> ================= >>> Emily Jiang >>> ejiang at apache.org >>> > >>> >>> >>> >>> >>> >>> -- >>> Thanks >>> Emily >>> ================= >>> Emily Jiang >>> ejiang at apache.org >>> > >>> >>> >>> >>> >>> >>> -- >>> Thanks >>> Emily >>> ================= >>> Emily Jiang >>> ejiang at apache.org >>> >> > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150802/9003ed2d/attachment.html From mkouba at redhat.com Mon Aug 3 11:12:33 2015 From: mkouba at redhat.com (Martin Kouba) Date: Mon, 03 Aug 2015 17:12:33 +0200 Subject: [weld-dev] Weld Performance improvement In-Reply-To: References: <5594E9CB.3090501@redhat.com> <55ACCA58.1040804@redhat.com> <55ACF527.4000104@redhat.com> Message-ID: <55BF84E1.20300@redhat.com> Hi Emily, Weld 2.2.15 has been released (available in maven central, see also http://weld.cdi-spec.org/download/). Martin Dne 2.8.2015 v 23:45 Emily Jiang napsal(a): > Hi Jozef/Martin, > Can you please commit the performance changes for this jar and release > 2.2.15.Final as soon as possible? > Thanks > Emily > > On Tue, Jul 21, 2015 at 12:31 PM, Emily Jiang > wrote: > > Thank you Jozef and Martin! I am looking forward to consume > 2.2.15.Final. > > On Mon, Jul 20, 2015 at 2:18 PM, Jozef Hartinger > > wrote: > > Hi Emily, > > thanks for the feedback. We're currently busy with other > releases but I'll try to get 2.2.15.Final released soon. > > Jozef > > On 20.7.2015 14:43, Emily Jiang wrote: > > The test applications we used were attached to the jira > https://developer.jboss.org/message/926035#926035. > > You can compare the responding time between two servlet > requests. > > Can you commit the current changes in the release > 2.2.15.Final because > I plan to consume this release for other jira fixes as well? > Thanks > Emily > > On Mon, Jul 20, 2015 at 11:15 AM, Martin Kouba > > >> wrote: > > Hi Emily, > > it's great to hear there is a performance improvement > (although 1% > is not that much). We're working on further performance > improvements > in this area [1]. > > However, 23% additional overhead seems to me too much. > Would it be > possible to share your performance test case / test > application? We > could run similar tests in our environment and verify > that there's > no integration problem. > > Martin > > [1] > https://issues.jboss.org/browse/WELD-1970 > > > Dne 20.7.2015 v 11:12 Emily Jiang napsal(a): > > Hi Jozef, Martin, > > Sorry for the delay! I have the performance figure > collected > eventually. > With this Jira's changes, it shows 1% performance > improvement. > This is a > step in the right direction but there is still a > performance hit > (23% > worse) when turning on CDI. Would you like to > commit this change > so that > I can reconsume this release? It will be great if a > further > performance > improvement can be done. I am happy to collect the > performance > benchmark > if needed. > > Thanks > Emily > > On Thu, Jul 2, 2015 at 8:35 AM, Jozef Hartinger > > > > >>> wrote: > > Hi Emily, > > that should not be a problem. Would it be > possible for you > to test > the performance improvement before we actually > do the > release? I can > prepare a separate branch or send you a > binary. I would > like to see > how much improvement this makes in your benchmark. > > Jozef > > > On 07/01/2015 06:19 PM, Emily Jiang wrote: > > Is it possible to get the following jira > fix committed to > 2.2.15.Final? > > https://issues.jboss.org/browse/WELD-1931 > > I would like to consume this and see how much > improvement has been > made. > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > >> > > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > >> > > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org From emijiang6 at googlemail.com Mon Aug 3 16:34:50 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Mon, 3 Aug 2015 21:34:50 +0100 Subject: [weld-dev] Weld Performance improvement In-Reply-To: <55BF84E1.20300@redhat.com> References: <5594E9CB.3090501@redhat.com> <55ACCA58.1040804@redhat.com> <55ACF527.4000104@redhat.com> <55BF84E1.20300@redhat.com> Message-ID: Thanks Martin for your comments! The issue is that the current jira https://issues.jboss.org/browse/WELD-1931 was not committed to 2.2.15.Final release. Is it possible for you to commit the jira and do another release? Thank you very much! Emily On Mon, Aug 3, 2015 at 4:12 PM, Martin Kouba wrote: > Hi Emily, > > Weld 2.2.15 has been released (available in maven central, see also > http://weld.cdi-spec.org/download/). > > Martin > > Dne 2.8.2015 v 23:45 Emily Jiang napsal(a): > >> Hi Jozef/Martin, >> Can you please commit the performance changes for this jar and release >> 2.2.15.Final as soon as possible? >> Thanks >> Emily >> >> On Tue, Jul 21, 2015 at 12:31 PM, Emily Jiang > > wrote: >> >> Thank you Jozef and Martin! I am looking forward to consume >> 2.2.15.Final. >> >> On Mon, Jul 20, 2015 at 2:18 PM, Jozef Hartinger >> > wrote: >> >> Hi Emily, >> >> thanks for the feedback. We're currently busy with other >> releases but I'll try to get 2.2.15.Final released soon. >> >> Jozef >> >> On 20.7.2015 14:43, Emily Jiang wrote: >> >> The test applications we used were attached to the jira >> https://developer.jboss.org/message/926035#926035. >> >> You can compare the responding time between two servlet >> requests. >> >> Can you commit the current changes in the release >> 2.2.15.Final because >> I plan to consume this release for other jira fixes as well? >> Thanks >> Emily >> >> On Mon, Jul 20, 2015 at 11:15 AM, Martin Kouba >> >> >> wrote: >> >> Hi Emily, >> >> it's great to hear there is a performance improvement >> (although 1% >> is not that much). We're working on further performance >> improvements >> in this area [1]. >> >> However, 23% additional overhead seems to me too much. >> Would it be >> possible to share your performance test case / test >> application? We >> could run similar tests in our environment and verify >> that there's >> no integration problem. >> >> Martin >> >> [1] >> https://issues.jboss.org/browse/WELD-1970 >> >> >> Dne 20.7.2015 v 11:12 Emily Jiang napsal(a): >> >> Hi Jozef, Martin, >> >> Sorry for the delay! I have the performance figure >> collected >> eventually. >> With this Jira's changes, it shows 1% performance >> improvement. >> This is a >> step in the right direction but there is still a >> performance hit >> (23% >> worse) when turning on CDI. Would you like to >> commit this change >> so that >> I can reconsume this release? It will be great if a >> further >> performance >> improvement can be done. I am happy to collect the >> performance >> benchmark >> if needed. >> >> Thanks >> Emily >> >> On Thu, Jul 2, 2015 at 8:35 AM, Jozef Hartinger >> >> > >> > > >>> wrote: >> >> Hi Emily, >> >> that should not be a problem. Would it be >> possible for you >> to test >> the performance improvement before we actually >> do the >> release? I can >> prepare a separate branch or send you a >> binary. I would >> like to see >> how much improvement this makes in your >> benchmark. >> >> Jozef >> >> >> On 07/01/2015 06:19 PM, Emily Jiang wrote: >> >> Is it possible to get the following jira >> fix committed to >> 2.2.15.Final? >> >> https://issues.jboss.org/browse/WELD-1931 >> >> I would like to consume this and see how >> much >> improvement has been >> made. >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> > > >> >> >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> > > >> >> >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > > -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150803/01b11c39/attachment-0001.html From emijiang6 at googlemail.com Mon Aug 3 18:37:54 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Mon, 3 Aug 2015 23:37:54 +0100 Subject: [weld-dev] NPE on AbstractResourceInjection Message-ID: I am trying to use Weld to inject ManagedBean instance but got the following NPE. [javatest.batch] Caused by: java.lang.NullPointerException [javatest.batch] at org.jboss.weld.injection.AbstractResourceInjection.getResourceReference(AbstractResourceInjection.java:44) [javatest.batch] at org.jboss.weld.injection.AbstractResourceInjection.injectResourceReference(AbstractResourceInjection.java:53) [javatest.batch] at org.jboss.weld.util.Beans.injectEEFields(Beans.java:348) [javatest.batch] at org.jboss.weld.injection.producer.ResourceInjector$1.proceed(ResourceInjector.java:69) -- Is there anything wrong? For some reason, it does not call back to the ResourceReferenceFactory service to get hold of an instance of an factory. Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150803/2100d418/attachment.html From mkouba at redhat.com Tue Aug 4 02:34:32 2015 From: mkouba at redhat.com (Martin Kouba) Date: Tue, 04 Aug 2015 08:34:32 +0200 Subject: [weld-dev] Weld Performance improvement In-Reply-To: References: <5594E9CB.3090501@redhat.com> <55ACCA58.1040804@redhat.com> <55ACF527.4000104@redhat.com> <55BF84E1.20300@redhat.com> Message-ID: <55C05CF8.7070508@redhat.com> Hi Emily, WELD-1931 commits are really merged into 2.2 branch (see also https://github.com/weld/core/commits/2.2). I've updated the "Fix Version" in the JIRA. Martin Dne 3.8.2015 v 22:34 Emily Jiang napsal(a): > Thanks Martin for your comments! The issue is that the current jira > https://issues.jboss.org/browse/WELD-1931 was not committed to > 2.2.15.Final release. Is it possible for you to commit the jira and do > another release? > Thank you very much! > Emily > > On Mon, Aug 3, 2015 at 4:12 PM, Martin Kouba > wrote: > > Hi Emily, > > Weld 2.2.15 has been released (available in maven central, see also > http://weld.cdi-spec.org/download/). > > Martin > > Dne 2.8.2015 v 23:45 Emily Jiang napsal(a): > > Hi Jozef/Martin, > Can you please commit the performance changes for this jar and > release > 2.2.15.Final as soon as possible? > Thanks > Emily > > On Tue, Jul 21, 2015 at 12:31 PM, Emily Jiang > > >> wrote: > > Thank you Jozef and Martin! I am looking forward to consume > 2.2.15.Final. > > On Mon, Jul 20, 2015 at 2:18 PM, Jozef Hartinger > > >> wrote: > > Hi Emily, > > thanks for the feedback. We're currently busy with other > releases but I'll try to get 2.2.15.Final released soon. > > Jozef > > On 20.7.2015 14:43, Emily Jiang wrote: > > The test applications we used were attached to the jira > https://developer.jboss.org/message/926035#926035. > > You can compare the responding time between two servlet > requests. > > Can you commit the current changes in the release > 2.2.15.Final because > I plan to consume this release for other jira fixes > as well? > Thanks > Emily > > On Mon, Jul 20, 2015 at 11:15 AM, Martin Kouba > > > > >>> wrote: > > Hi Emily, > > it's great to hear there is a performance > improvement > (although 1% > is not that much). We're working on further > performance > improvements > in this area [1]. > > However, 23% additional overhead seems to me > too much. > Would it be > possible to share your performance test case / > test > application? We > could run similar tests in our environment and > verify > that there's > no integration problem. > > Martin > > [1] > https://issues.jboss.org/browse/WELD-1970 > > > Dne 20.7.2015 v 11:12 Emily Jiang napsal(a): > > Hi Jozef, Martin, > > Sorry for the delay! I have the > performance figure > collected > eventually. > With this Jira's changes, it shows 1% > performance > improvement. > This is a > step in the right direction but there is > still a > performance hit > (23% > worse) when turning on CDI. Would you like to > commit this change > so that > I can reconsume this release? It will be > great if a > further > performance > improvement can be done. I am happy to > collect the > performance > benchmark > if needed. > > Thanks > Emily > > On Thu, Jul 2, 2015 at 8:35 AM, Jozef > Hartinger > > > >> > > > > >>>> wrote: > > Hi Emily, > > that should not be a problem. Would it be > possible for you > to test > the performance improvement before we > actually > do the > release? I can > prepare a separate branch or send you a > binary. I would > like to see > how much improvement this makes in > your benchmark. > > Jozef > > > On 07/01/2015 06:19 PM, Emily Jiang > wrote: > > Is it possible to get the > following jira > fix committed to > 2.2.15.Final? > > https://issues.jboss.org/browse/WELD-1931 > > I would like to consume this and > see how much > improvement has been > made. > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > >> > > > > >>> > > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > >> > > > > >>> > > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > >> > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org From mkouba at redhat.com Tue Aug 4 03:58:17 2015 From: mkouba at redhat.com (Martin Kouba) Date: Tue, 04 Aug 2015 09:58:17 +0200 Subject: [weld-dev] NPE on AbstractResourceInjection In-Reply-To: References: Message-ID: <55C07099.4010007@redhat.com> Hi Emily, do you have ResourceInjectionServices implemented properly? Martin Dne 4.8.2015 v 00:37 Emily Jiang napsal(a): > I am trying to use Weld to inject ManagedBean instance but got the > following NPE. > [javatest.batch] Caused by: java.lang.NullPointerException > [javatest.batch] at > org.jboss.weld.injection.AbstractResourceInjection.getResourceReference(AbstractResourceInjection.java:44) > [javatest.batch] at > org.jboss.weld.injection.AbstractResourceInjection.injectResourceReference(AbstractResourceInjection.java:53) > [javatest.batch] at > org.jboss.weld.util.Beans.injectEEFields(Beans.java:348) > [javatest.batch] at > org.jboss.weld.injection.producer.ResourceInjector$1.proceed(ResourceInjector.java:69) > -- > > Is there anything wrong? For some reason, it does not call back to the > ResourceReferenceFactory service to get hold of an instance of an factory. > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > _______________________________________________ > weld-dev mailing list > weld-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/weld-dev > -- Martin Kouba Software Engineer Red Hat, Czech Republic From emijiang6 at googlemail.com Tue Aug 4 04:17:31 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Tue, 4 Aug 2015 09:17:31 +0100 Subject: [weld-dev] Weld Performance improvement In-Reply-To: <55C05CF8.7070508@redhat.com> References: <5594E9CB.3090501@redhat.com> <55ACCA58.1040804@redhat.com> <55ACF527.4000104@redhat.com> <55BF84E1.20300@redhat.com> <55C05CF8.7070508@redhat.com> Message-ID: Thank you Martin! Previously, I looked at the release note and jira targeted version but failed to spot this jira release. I see you have updated these accordingly. Thanks Emily On Tue, Aug 4, 2015 at 7:34 AM, Martin Kouba wrote: > Hi Emily, > > WELD-1931 commits are really merged into 2.2 branch (see also > https://github.com/weld/core/commits/2.2). I've updated the "Fix Version" > in the JIRA. > > Martin > > Dne 3.8.2015 v 22:34 Emily Jiang napsal(a): > >> Thanks Martin for your comments! The issue is that the current jira >> https://issues.jboss.org/browse/WELD-1931 was not committed to >> 2.2.15.Final release. Is it possible for you to commit the jira and do >> another release? >> Thank you very much! >> Emily >> >> On Mon, Aug 3, 2015 at 4:12 PM, Martin Kouba > > wrote: >> >> Hi Emily, >> >> Weld 2.2.15 has been released (available in maven central, see also >> http://weld.cdi-spec.org/download/). >> >> Martin >> >> Dne 2.8.2015 v 23:45 Emily Jiang napsal(a): >> >> Hi Jozef/Martin, >> Can you please commit the performance changes for this jar and >> release >> 2.2.15.Final as soon as possible? >> Thanks >> Emily >> >> On Tue, Jul 21, 2015 at 12:31 PM, Emily Jiang >> >> > >> wrote: >> >> Thank you Jozef and Martin! I am looking forward to consume >> 2.2.15.Final. >> >> On Mon, Jul 20, 2015 at 2:18 PM, Jozef Hartinger >> >> >> wrote: >> >> Hi Emily, >> >> thanks for the feedback. We're currently busy with other >> releases but I'll try to get 2.2.15.Final released soon. >> >> Jozef >> >> On 20.7.2015 14:43, Emily Jiang wrote: >> >> The test applications we used were attached to the >> jira >> https://developer.jboss.org/message/926035#926035. >> >> You can compare the responding time between two >> servlet >> requests. >> >> Can you commit the current changes in the release >> 2.2.15.Final because >> I plan to consume this release for other jira fixes >> as well? >> Thanks >> Emily >> >> On Mon, Jul 20, 2015 at 11:15 AM, Martin Kouba >> >> > >> > > >>> wrote: >> >> Hi Emily, >> >> it's great to hear there is a performance >> improvement >> (although 1% >> is not that much). We're working on further >> performance >> improvements >> in this area [1]. >> >> However, 23% additional overhead seems to me >> too much. >> Would it be >> possible to share your performance test case / >> test >> application? We >> could run similar tests in our environment and >> verify >> that there's >> no integration problem. >> >> Martin >> >> [1] >> https://issues.jboss.org/browse/WELD-1970 >> >> >> Dne 20.7.2015 v 11:12 Emily Jiang napsal(a): >> >> Hi Jozef, Martin, >> >> Sorry for the delay! I have the >> performance figure >> collected >> eventually. >> With this Jira's changes, it shows 1% >> performance >> improvement. >> This is a >> step in the right direction but there is >> still a >> performance hit >> (23% >> worse) when turning on CDI. Would you like >> to >> commit this change >> so that >> I can reconsume this release? It will be >> great if a >> further >> performance >> improvement can be done. I am happy to >> collect the >> performance >> benchmark >> if needed. >> >> Thanks >> Emily >> >> On Thu, Jul 2, 2015 at 8:35 AM, Jozef >> Hartinger >> > > > >> > > >> >> > >> > > > >> > >>>> wrote: >> >> Hi Emily, >> >> that should not be a problem. Would it >> be >> possible for you >> to test >> the performance improvement before we >> actually >> do the >> release? I can >> prepare a separate branch or send you a >> binary. I would >> like to see >> how much improvement this makes in >> your benchmark. >> >> Jozef >> >> >> On 07/01/2015 06:19 PM, Emily Jiang >> wrote: >> >> Is it possible to get the >> following jira >> fix committed to >> 2.2.15.Final? >> >> https://issues.jboss.org/browse/WELD-1931 >> >> I would like to consume this and >> see how much >> improvement has been >> made. >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> > > >> >> > >> > > > >> > >>>> >> >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> > > >> >> > >> > > > >> > >>>> >> >> >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> > > >> >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > > -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150804/64714e73/attachment-0001.html From emijiang6 at googlemail.com Tue Aug 4 04:19:00 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Tue, 4 Aug 2015 09:19:00 +0100 Subject: [weld-dev] NPE on AbstractResourceInjection In-Reply-To: <55C07099.4010007@redhat.com> References: <55C07099.4010007@redhat.com> Message-ID: How can I verify whether the ResourceInjectionServices implemented properly? I can verify it was called for other CDI bean resource injection but not by ManagedBean resource injections. Thanks Emily On Tue, Aug 4, 2015 at 8:58 AM, Martin Kouba wrote: > Hi Emily, > > do you have ResourceInjectionServices implemented properly? > > Martin > > Dne 4.8.2015 v 00:37 Emily Jiang napsal(a): > >> I am trying to use Weld to inject ManagedBean instance but got the >> following NPE. >> [javatest.batch] Caused by: java.lang.NullPointerException >> [javatest.batch] at >> >> org.jboss.weld.injection.AbstractResourceInjection.getResourceReference(AbstractResourceInjection.java:44) >> [javatest.batch] at >> >> org.jboss.weld.injection.AbstractResourceInjection.injectResourceReference(AbstractResourceInjection.java:53) >> [javatest.batch] at >> org.jboss.weld.util.Beans.injectEEFields(Beans.java:348) >> [javatest.batch] at >> >> org.jboss.weld.injection.producer.ResourceInjector$1.proceed(ResourceInjector.java:69) >> -- >> >> Is there anything wrong? For some reason, it does not call back to the >> ResourceReferenceFactory service to get hold of an instance of an factory. >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> >> >> _______________________________________________ >> weld-dev mailing list >> weld-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/weld-dev >> >> > -- > Martin Kouba > Software Engineer > Red Hat, Czech Republic > -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150804/42d88f8a/attachment.html From mkouba at redhat.com Wed Aug 5 05:30:11 2015 From: mkouba at redhat.com (Martin Kouba) Date: Wed, 05 Aug 2015 11:30:11 +0200 Subject: [weld-dev] Weld 3.0.0.Alpha12 - CDI 2.0 EDR1 reference implementation released! Message-ID: <55C1D7A3.4090004@redhat.com> Hello, Weld 3.0.0.Alpha12 - a CDI 2.0 EDR1 reference implementation - has been released: http://weld.cdi-spec.org/news/2015/08/05/weld-300Alpha12/ It's available in Maven Central Repository, in a zip bundle [1] and there is a patch for WildFly 10.0.0.Alpha6 [2]. Furthermore, we've released the next stable version - 2.2.15.Final. See also the changelog [3]. The target platform is WildFly 9.0.1.Final [4]. Martin [1] http://download.jboss.org/weld/3.0.0.Alpha12/weld-3.0.0.Alpha12.zip [2] http://download.jboss.org/weld/3.0.0.Alpha12/wildfly-10.0.0.Alpha6-weld-3.0.0.Alpha12-patch.zip [3] https://issues.jboss.org/secure/ReleaseNote.jspa?projectId=12310891&version=12327593 [4] http://download.jboss.org/weld/2.2.15.Final/wildfly-9.0.1.Final-weld-2.2.15.Final-patch.zip From emijiang6 at googlemail.com Thu Aug 6 06:16:59 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Thu, 6 Aug 2015 11:16:59 +0100 Subject: [weld-dev] fire process injection target event for non-cdi Interceptors Message-ID: According to the CDI 1.2 spec, the container must fire Processing Injection Target event for all Java EE component classes. The Java EE component classes are listed in the table EE-5.1, shown below. [image: Inline image 1] Weld provides an api WeldManager.fireProcessInjectionTarget, which can be used to fire events for all other JavaEE component classes except the interceptors . For EJB style interceptors, we have to use WeldInjectionTargetFactory.createInterceptorInjectionTarget() (creating a non-proxy instance) but it does not fire events. Are there any other API to fire processing injection targets for EJB-style interceptors? Am I missing something? -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150806/e9d9688b/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: image.png Type: image/png Size: 44180 bytes Desc: not available Url : http://lists.jboss.org/pipermail/weld-dev/attachments/20150806/e9d9688b/attachment-0001.png From jharting at redhat.com Mon Aug 10 11:20:16 2015 From: jharting at redhat.com (Jozef Hartinger) Date: Mon, 10 Aug 2015 17:20:16 +0200 Subject: [weld-dev] fire process injection target event for non-cdi Interceptors In-Reply-To: References: Message-ID: <55C8C130.80103@redhat.com> Hi Emily, there is an overloaded fireProcessInjectionTarget method here: http://docs.jboss.org/weld/javadoc/2.2/weld-spi/org/jboss/weld/manager/api/WeldManager.html#fireProcessInjectionTarget-javax.enterprise.inject.spi.AnnotatedType-javax.enterprise.inject.spi.InjectionTarget- that allows you to pass in any InjectionTarget instance. You can therefore build any InjectionTarget using WeldInjectionTargetFactory or WeldInjectionTargetBuilder and then fire the event using the aforementioned method. HTH, Jozef On 6.8.2015 12:16, Emily Jiang wrote: > According to the CDI 1.2 spec, the container must fire Processing > Injection Target event for all Java EE component classes. The Java EE > component classes are listed in the table EE-5.1, shown below. > > Inline image 1 > > Weld provides an api WeldManager.fireProcessInjectionTarget, which can > be used to fire events for all other JavaEE component classes except the > interceptors . For EJB style interceptors, we have to use > WeldInjectionTargetFactory.createInterceptorInjectionTarget() (creating > a non-proxy instance) but it does not fire events. Are there any other > API to fire processing injection targets for EJB-style interceptors? Am > I missing something? > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > _______________________________________________ > weld-dev mailing list > weld-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/weld-dev > From jharting at redhat.com Mon Aug 10 11:38:02 2015 From: jharting at redhat.com (Jozef Hartinger) Date: Mon, 10 Aug 2015 17:38:02 +0200 Subject: [weld-dev] NPE on AbstractResourceInjection In-Reply-To: References: <55C07099.4010007@redhat.com> Message-ID: <55C8C55A.8070908@redhat.com> After a quick look it seems that your ResourceInjectionServices implementation returns null sometimes from the registerResourceInjectionPoint() method? Is that possible? I'll add checks to Weld to validate the preconditions upfront instead of run time. Jozef On 4.8.2015 10:19, Emily Jiang wrote: > How can I verify whether the ResourceInjectionServices implemented > properly? I can verify it was called for other CDI bean resource > injection but not by ManagedBean resource injections. > Thanks > Emily > > On Tue, Aug 4, 2015 at 8:58 AM, Martin Kouba > wrote: > > Hi Emily, > > do you have ResourceInjectionServices implemented properly? > > Martin > > Dne 4.8.2015 v 00:37 Emily Jiang napsal(a): > > I am trying to use Weld to inject ManagedBean instance but got the > following NPE. > [javatest.batch] Caused by: java.lang.NullPointerException > [javatest.batch] at > org.jboss.weld.injection.AbstractResourceInjection.getResourceReference(AbstractResourceInjection.java:44) > [javatest.batch] at > org.jboss.weld.injection.AbstractResourceInjection.injectResourceReference(AbstractResourceInjection.java:53) > [javatest.batch] at > org.jboss.weld.util.Beans.injectEEFields(Beans.java:348) > [javatest.batch] at > org.jboss.weld.injection.producer.ResourceInjector$1.proceed(ResourceInjector.java:69) > -- > > Is there anything wrong? For some reason, it does not call back > to the > ResourceReferenceFactory service to get hold of an instance of > an factory. > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > > > _______________________________________________ > weld-dev mailing list > weld-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/weld-dev > > > -- > Martin Kouba > Software Engineer > Red Hat, Czech Republic > > > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > _______________________________________________ > weld-dev mailing list > weld-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/weld-dev > From emijiang6 at googlemail.com Mon Aug 10 12:28:05 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Mon, 10 Aug 2015 17:28:05 +0100 Subject: [weld-dev] NPE on AbstractResourceInjection In-Reply-To: <55C8C55A.8070908@redhat.com> References: <55C07099.4010007@redhat.com> <55C8C55A.8070908@redhat.com> Message-ID: Thanks Jozef and Martin! I did find out it returns a null sometimes and are fixing that. Yep. It will be good not to throw NPE. Emily On Mon, Aug 10, 2015 at 4:38 PM, Jozef Hartinger wrote: > After a quick look it seems that your ResourceInjectionServices > implementation returns null sometimes from the > registerResourceInjectionPoint() method? Is that possible? I'll add checks > to Weld to validate the preconditions upfront instead of run time. > > Jozef > > > On 4.8.2015 10:19, Emily Jiang wrote: > >> How can I verify whether the ResourceInjectionServices implemented >> properly? I can verify it was called for other CDI bean resource >> injection but not by ManagedBean resource injections. >> Thanks >> Emily >> >> On Tue, Aug 4, 2015 at 8:58 AM, Martin Kouba > > wrote: >> >> Hi Emily, >> >> do you have ResourceInjectionServices implemented properly? >> >> Martin >> >> Dne 4.8.2015 v 00:37 Emily Jiang napsal(a): >> >> I am trying to use Weld to inject ManagedBean instance but got the >> following NPE. >> [javatest.batch] Caused by: java.lang.NullPointerException >> [javatest.batch] at >> >> org.jboss.weld.injection.AbstractResourceInjection.getResourceReference(AbstractResourceInjection.java:44) >> [javatest.batch] at >> >> org.jboss.weld.injection.AbstractResourceInjection.injectResourceReference(AbstractResourceInjection.java:53) >> [javatest.batch] at >> org.jboss.weld.util.Beans.injectEEFields(Beans.java:348) >> [javatest.batch] at >> >> org.jboss.weld.injection.producer.ResourceInjector$1.proceed(ResourceInjector.java:69) >> -- >> >> Is there anything wrong? For some reason, it does not call back >> to the >> ResourceReferenceFactory service to get hold of an instance of >> an factory. >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> > >> >> >> _______________________________________________ >> weld-dev mailing list >> weld-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/weld-dev >> >> >> -- >> Martin Kouba >> Software Engineer >> Red Hat, Czech Republic >> >> >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> >> >> _______________________________________________ >> weld-dev mailing list >> weld-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/weld-dev >> >> -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150810/b3d19a0a/attachment.html From emijiang6 at googlemail.com Mon Aug 10 12:36:35 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Mon, 10 Aug 2015 17:36:35 +0100 Subject: [weld-dev] fire process injection target event for non-cdi Interceptors In-Reply-To: <55C8C130.80103@redhat.com> References: <55C8C130.80103@redhat.com> Message-ID: Thank you Jozef! ah. I failed to spot this particular method. Emily On Mon, Aug 10, 2015 at 4:20 PM, Jozef Hartinger wrote: > Hi Emily, > > there is an overloaded fireProcessInjectionTarget method here: > http://docs.jboss.org/weld/javadoc/2.2/weld-spi/org/jboss/weld/manager/api/WeldManager.html#fireProcessInjectionTarget-javax.enterprise.inject.spi.AnnotatedType-javax.enterprise.inject.spi.InjectionTarget- > that allows you to pass in any InjectionTarget instance. You can therefore > build any InjectionTarget using WeldInjectionTargetFactory or > WeldInjectionTargetBuilder and then fire the event using the aforementioned > method. > > HTH, > > Jozef > > On 6.8.2015 12:16, Emily Jiang wrote: > >> According to the CDI 1.2 spec, the container must fire Processing >> Injection Target event for all Java EE component classes. The Java EE >> component classes are listed in the table EE-5.1, shown below. >> >> Inline image 1 >> >> Weld provides an api WeldManager.fireProcessInjectionTarget, which can >> be used to fire events for all other JavaEE component classes except the >> interceptors . For EJB style interceptors, we have to use >> WeldInjectionTargetFactory.createInterceptorInjectionTarget() (creating >> a non-proxy instance) but it does not fire events. Are there any other >> API to fire processing injection targets for EJB-style interceptors? Am >> I missing something? >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> >> >> _______________________________________________ >> weld-dev mailing list >> weld-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/weld-dev >> >> -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150810/1b9f2e9c/attachment.html From emijiang6 at googlemail.com Tue Aug 18 05:36:56 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Tue, 18 Aug 2015 10:36:56 +0100 Subject: [weld-dev] archives containing a beans.xml with bean-discovery-mode=all Message-ID: >From CDI spec, An archive which: ? contains a beans.xml file with the bean-discovery-mode of none, or, ? contains an extension and no beans.xml file is not a bean archive. I think it is no need to create a bda for such bean archives, which implies JavaEE component classes cannot support injection in these archives. These archives are ignored basically. Right? The spec does say an extension can exist in a non-bean archive but it does not say anything about JavaEE component classes. -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150818/b2fa0adb/attachment.html From mkouba at redhat.com Tue Aug 18 09:36:17 2015 From: mkouba at redhat.com (Martin Kouba) Date: Tue, 18 Aug 2015 15:36:17 +0200 Subject: [weld-dev] archives containing a beans.xml with bean-discovery-mode=all In-Reply-To: References: Message-ID: <55D334D1.9040000@redhat.com> Hi Emily, Dne 18.8.2015 v 11:36 Emily Jiang napsal(a): > From CDI spec, > An archive which: > ? contains a beans.xml file with the bean-discovery-mode of none, or, > ? contains an extension and no beans.xml file > is not a bean archive. > > I think it is no need to create a bda for such bean archives, which > implies JavaEE component classes cannot support injection in these > archives. These archives are ignored basically. Right? Yes, these archives are ignored from the CDI container point of view. As regards the injection support for Java EE component classes - this is not clearly defined. Java EE spec states in "EE.5.2.5 Annotations and Injection": "The component classes listed in Table EE.5-1 with support level Standard all support Java EE resource injection, as well as PostConstruct and PreDestroy callbacks. In addition, if CDI is enabled?which it is by default?these classes also support CDI injection, as described in Section EE.5.24, Support for Dependency Injection, and the use of interceptors." However, it is not clear what "if CDI is enabled" means. One can argue that "CDI is enabled" if the component class resides in a bean archive. The other interpretation (the one I personally prefer) might be that "CDI is enabled" if a CDI container is initialized for the application (i.e. there's at least one CDI bean archive). I think we should check what Java EE RI (GlassFish) and other implementations (WildFly) do. > > The spec does say an extension can exist in a non-bean archive but it > does not say anything about JavaEE component classes. > > > -- > Thanks > Emily > ================= > Emily Jiang > ejiang at apache.org > > > _______________________________________________ > weld-dev mailing list > weld-dev at lists.jboss.org > https://lists.jboss.org/mailman/listinfo/weld-dev > -- Martin Kouba Software Engineer Red Hat, Czech Republic From emijiang6 at googlemail.com Tue Aug 18 18:39:24 2015 From: emijiang6 at googlemail.com (Emily Jiang) Date: Tue, 18 Aug 2015 23:39:24 +0100 Subject: [weld-dev] archives containing a beans.xml with bean-discovery-mode=all In-Reply-To: <55D334D1.9040000@redhat.com> References: <55D334D1.9040000@redhat.com> Message-ID: Hi Martin, I totally agree with you. In integrating CDI 1.2 to WebSphere Liberty profile, I interpreted the latter. e.g. In a war with bean-discovery-mod=none, if one of its libs is a bean archive, the cdi is enabled for the war module. The servlet in this war will support injections. However, it gives performance penalty, e.g. creating bda etc. I would like to know what the other application servers (GlassFish or WildFly) behave. It will be nice if the spec is clearer on this. I will raise a spec issue on this. Thanks Emily On Tue, Aug 18, 2015 at 2:36 PM, Martin Kouba wrote: > Hi Emily, > > Dne 18.8.2015 v 11:36 Emily Jiang napsal(a): > >> From CDI spec, >> An archive which: >> ? contains a beans.xml file with the bean-discovery-mode of none, or, >> ? contains an extension and no beans.xml file >> is not a bean archive. >> >> I think it is no need to create a bda for such bean archives, which >> implies JavaEE component classes cannot support injection in these >> archives. These archives are ignored basically. Right? >> > > Yes, these archives are ignored from the CDI container point of view. As > regards the injection support for Java EE component classes - this is not > clearly defined. Java EE spec states in "EE.5.2.5 > Annotations and Injection": > > "The component classes listed in Table EE.5-1 with support level Standard > all support Java EE resource injection, as well as PostConstruct and > PreDestroy callbacks. In addition, if CDI is enabled?which it is by > default?these classes also support CDI injection, as described in Section > EE.5.24, Support for Dependency Injection, and the use of interceptors." > > However, it is not clear what "if CDI is enabled" means. One can argue > that "CDI is enabled" if the component class resides in a bean archive. The > other interpretation (the one I personally prefer) might be that "CDI is > enabled" if a CDI container is initialized for the application (i.e. > there's at least one CDI bean archive). > > I think we should check what Java EE RI (GlassFish) and other > implementations (WildFly) do. > > >> The spec does say an extension can exist in a non-bean archive but it >> does not say anything about JavaEE component classes. >> >> >> -- >> Thanks >> Emily >> ================= >> Emily Jiang >> ejiang at apache.org >> >> >> _______________________________________________ >> weld-dev mailing list >> weld-dev at lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/weld-dev >> >> > -- > Martin Kouba > Software Engineer > Red Hat, Czech Republic > -- Thanks Emily ================= Emily Jiang ejiang at apache.org -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.jboss.org/pipermail/weld-dev/attachments/20150818/38beb5e9/attachment.html From jharting at redhat.com Fri Aug 21 08:25:12 2015 From: jharting at redhat.com (Jozef Hartinger) Date: Fri, 21 Aug 2015 14:25:12 +0200 Subject: [weld-dev] Weld 2.3.0.CR1 Message-ID: <55D718A8.60503@redhat.com> Weld 2.3.0.CR1 has been released and should appear in Maven shortly. Release notes: https://issues.jboss.org/secure/ReleaseNote.jspa?projectId=12310891&version=12327252 From jharting at redhat.com Fri Aug 28 09:29:18 2015 From: jharting at redhat.com (Jozef Hartinger) Date: Fri, 28 Aug 2015 15:29:18 +0200 Subject: [weld-dev] Weld 3.0.0.Alpha13 released Message-ID: <55E0622E.3010205@redhat.com> https://developer.jboss.org/thread/262306