[weld-dev] WIP fix for https://issues.jboss.org/browse/WELD-1130

[Martin Kouba]

Hi Benjamin,

I'm sorry but the Weld team is burried under some high priority issues. 
I've quickly went through your proposal and have few comments.

1. I think it would be more convenient to modify 
org.jboss.weld.module.web.context.beanstore.http.AbstractSessionBeanStore.getAttribute(String) 
which is used for both the HTTP session and the conversation contexts

2. +1 for config property, we probably need a better name though ;-)

3. You're probably aware that this would not solve the problem 
completely. It should trigger the replication when a @SessionScoped bean 
instance is obtained from the context, e.g. when a client proxy method 
is invoked. However, there are some optimizations in Weld which prevent 
the context lookup (see also 
org.jboss.weld.bean.ContextualInstanceStrategy). Also the replication 
may happen before the state is actually changed - it really depends on 
replication impl details. Still, I agree that this would improve the 
usability.

4. +10 for tests. But I guess it would be tricky to write an automated 
test for this.

Martin

Dne 13.4.2018 v 21:33 Benjamin Confino napsal(a):
> Hello
> 
> I posed 
> https://github.com/benjamin-confino/core/commit/35d055cd9a841cfbdf2bcb2aaa3e0d8d6116ec1cto 
> this lift list month but have not heard any feedback. When can I expect 
> to hear if this concept is good in principal? If the concept is good I 
> can begin investigating how to extend the idea to conversation scopes 
> and write a test.
> 
> Regards
> Benjamin
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number 
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
> 
> 
> _______________________________________________
> weld-dev mailing list
> weld-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/weld-dev
>