Btw, the build should fail if jboss.home is not pointing to a real JBoss AS instances (same with tomcat).<br><br><fail unless="jboss.home">jboss.home not set</fail><br><br>Though we should also check for a known file, such as bin/run.conf<br>
<br> <fail message="jboss.home not a valid JBoss AS installation"><br> <condition><br> <or><br> <length string="${jboss.home}" trim="true" length="0"/><br>
<not><available file="${jboss.home}/bin/run.conf"/></not><br> </or><br> </condition><br> </fail><br><br>This just avoids creating erroneous directories with the name "${jboss.home}" in the current directory, which is utterly confusing.<br>
<br>-Dan<br><br><div class="gmail_quote">On Wed, Dec 9, 2009 at 3:54 PM, Dan Allen <span dir="ltr"><<a href="mailto:dan.j.allen@gmail.com">dan.j.allen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Steven,<br><br>I see that you set jboss.home to ${env.JBOSS_HOME} in build.xml, but why not do this in build.properties? The reason I suggest that is because having the following in build.properties is just misleading and cruft (it's what has always been there, so I'm not implying you added it)<br>
<br>jboss.home=/Applications/jboss-5.2.0.Beta1<br>tomcat.home=/Applications/apache-tomcat-6.0.20<br><br>Better is for build.xml to simply read build.properties as defined here:<br><br>jboss.home=${env.JBOSS_HOME}<br>tomcat.home=${env.CATALINA_HOME}<br>
<br>Here are the lines you need in build.xml<br><br> <property environment="env"/><!-- assign OS environment variables to an object visible to ANT --><br><br> <!-- preserve local build.properties if they're still being used --><br>
<property file="${wbexamples.dir}/../jboss-as/local.build.properties" /><br> <property file="${wbexamples.dir}/local.build.properties" /><br><br> <property file="${wbexamples.dir}/../jboss-as/build.properties" /><br>
<property file="${wbexamples.dir}/build.properties" /><br><br>They can either setup jboss.home in the jboss-as directory or the root of the examples directory. It first uses local.build.properties overrides (for developers that do have multiple instances of JBoss AS that don't coincide w/ JBOSS_HOME), then we check build.properties, which should be as above.<br>
<br>-Dan<div><div></div><div class="h5"><br><br><div class="gmail_quote">On Wed, Dec 9, 2009 at 3:35 PM, Steven Boscarine <span dir="ltr"><<a href="mailto:steven.boscarine@childrens.harvard.edu" target="_blank">steven.boscarine@childrens.harvard.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">On 12/09/2009 06:18 AM, Pete Muir wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
Right, we have local.build.properties for this.<br>
<br>
But this is a good change overall, if you want to change it, that would be great :-) (affected are examples and TCK runs I think)<br>
</blockquote>
<br>
I made the change and left the local.build.properties reference, so no one will need to change their configs as long as they're not using the main build.properties file. Examples appear to work fine. The new build should work identically to the old one.<br>
<br>
How do I confirm this hasn't affected the TCK?<br>
<br>
Also, what do I have to do beyond confirm <a href="http://www.seamframework.org/Documentation/RunningWeldExamplesWithJBossApplicationServer6" target="_blank">http://www.seamframework.org/Documentation/RunningWeldExamplesWithJBossApplicationServer6</a> works w/ JBOSS_HOME to test the change?<br>
<br>
Thanks,<br><font color="#888888">
Steven<br>
</font></blockquote></div><br><br clear="all"><br></div></div><font color="#888888">-- <br>Dan Allen<br>Senior Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><a href="http://mojavelinux.com" target="_blank">http://mojavelinux.com</a><br>
<a href="http://mojavelinux.com/seaminaction" target="_blank">http://mojavelinux.com/seaminaction</a><br><a href="http://www.google.com/profiles/dan.j.allen" target="_blank">http://www.google.com/profiles/dan.j.allen</a><br>
</font></blockquote></div><br><br clear="all"><br>-- <br>Dan Allen<br>Senior Software Engineer, Red Hat | Author of Seam in Action<br>Registered Linux User #231597<br><br><a href="http://mojavelinux.com">http://mojavelinux.com</a><br>
<a href="http://mojavelinux.com/seaminaction">http://mojavelinux.com/seaminaction</a><br><a href="http://www.google.com/profiles/dan.j.allen">http://www.google.com/profiles/dan.j.allen</a><br>