Seam has a relatively small number of (mostly static) xml config files (thank God). I'm not sure it's even necessary to convert the pages.xml to a class or even if all users would want that. Yes, type safety is good, but it's easier to read in xml format sometimes. If you leave the option of class or xml then it's ok.<br>
<br>Is the Page class/enum going to be something that is extended or polymorphic, etc? Why convert to OO if the only reason is type-safety assurance in this case (plz don't beat this comment down, yes, maybe I'm missing something).<br>
<br>It would be pretty cool if there was a new utility that converted a pages.xml to class/OO format...<br><br><div class="gmail_quote">On Fri, Feb 19, 2010 at 12:35 PM, Stuart Douglas <span dir="ltr"><<a href="mailto:stuart@baileyroberts.com.au">stuart@baileyroberts.com.au</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> find . | grep xhtml | wc<br>
392 392 21192<br>
<br>
It's going to be a big enum... we would need to make sure that you could split it up.<br>
<br>
The only real problem I have with this approach is that all the metadata that is availible is hard coded into the page class, which means the page class has to know about every module that wants to use page level metadata. Also, you can't really configure it via xml, which I am not too worried about but may alienate some users.<br>
<br>
Stuart<br>
<br>
On 19/02/2010, at 4:40 PM, Gavin King wrote:<br>
<br>
> You should even be able to make this work:<br>
><br>
> @View(.....)<br>
> login {<br>
> @Inject Login loginBean;<br>
> public MyAppPage next(MyAppPage page, Object outcome) {<br>
> if ( loginBean.isLoggedIn() )<br>
> return main;<br>
> else<br>
> return login;<br>
> }<br>
> },<br>
><br>
> of course we would need a little infrastructure for injecting into enum values.<br>
><br>
> On Thu, Feb 18, 2010 at 11:37 PM, Gavin King <<a href="mailto:gavin.king@gmail.com">gavin.king@gmail.com</a>> wrote:<br>
>> Oops, this is a MUCH better way to write this code:<br>
>><br>
>><br>
>> public enum MyAppPage implements Page<MyAppPage> {<br>
>><br>
>> @View(.....)<br>
>> login {<br>
>> public MyAppPage next(MyAppPage page, Object outcome) {<br>
>> if (Boolean.TRUE.equals(outcome))<br>
>> return main;<br>
>> else<br>
>> return login;<br>
>> }<br>
>> },<br>
>><br>
>> @View(.....)<br>
>> main {<br>
>> public MyAppPage next(MyAppPage page, Object outcome) {<br>
>> return main;<br>
>> }<br>
>> },<br>
>><br>
>> @View(.....)<br>
>> logout {<br>
>> public MyAppPage next(MyAppPage page, Object outcome) {<br>
>> return login;<br>
>> }<br>
>> };<br>
>><br>
>> }<br>
>><br>
><br>
><br>
><br>
> --<br>
> Gavin King<br>
> <a href="mailto:gavin.king@gmail.com">gavin.king@gmail.com</a><br>
> <a href="http://in.relation.to/Bloggers/Gavin" target="_blank">http://in.relation.to/Bloggers/Gavin</a><br>
> <a href="http://hibernate.org" target="_blank">http://hibernate.org</a><br>
> <a href="http://seamframework.org" target="_blank">http://seamframework.org</a><br>
<br>
<br>
_______________________________________________<br>
weld-dev mailing list<br>
<a href="mailto:weld-dev@lists.jboss.org">weld-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/weld-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/weld-dev</a><br>
</blockquote></div><br>