<div dir="ltr"><div><div><div>The test applications we used were attached to the jira <a href="https://developer.jboss.org/message/926035#926035">https://developer.jboss.org/message/926035#926035</a>. <br><br>You can compare the responding time between two servlet requests.<br><br></div>Can you commit the current changes in the release 2.2.15.Final because I plan to consume this release for other jira fixes as well?<br></div>Thanks<br></div>Emily<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jul 20, 2015 at 11:15 AM, Martin Kouba <span dir="ltr"><<a href="mailto:mkouba@redhat.com" target="_blank">mkouba@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Emily,<br>
<br>
it's great to hear there is a performance improvement (although 1% is not that much). We're working on further performance improvements in this area [1].<br>
<br>
However, 23% additional overhead seems to me too much. Would it be possible to share your performance test case / test application? We could run similar tests in our environment and verify that there's no integration problem.<br>
<br>
Martin<br>
<br>
[1]<br>
<a href="https://issues.jboss.org/browse/WELD-1970" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/WELD-1970</a><br>
<br>
<br>
Dne 20.7.2015 v 11:12 Emily Jiang napsal(a):<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
Hi Jozef, Martin,<br>
<br>
Sorry for the delay! I have the performance figure collected eventually.<br>
With this Jira's changes, it shows 1% performance improvement. This is a<br>
step in the right direction but there is still a performance hit (23%<br>
worse) when turning on CDI. Would you like to commit this change so that<br>
I can reconsume this release? It will be great if a further performance<br>
improvement can be done. I am happy to collect the performance benchmark<br>
if needed.<br>
<br>
Thanks<br>
Emily<br>
<br>
On Thu, Jul 2, 2015 at 8:35 AM, Jozef Hartinger <<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a><br></span><span class="">
<mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a>>> wrote:<br>
<br>
Hi Emily,<br>
<br>
that should not be a problem. Would it be possible for you to test<br>
the performance improvement before we actually do the release? I can<br>
prepare a separate branch or send you a binary. I would like to see<br>
how much improvement this makes in your benchmark.<br>
<br>
Jozef<br>
<br>
<br>
On 07/01/2015 06:19 PM, Emily Jiang wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
Is it possible to get the following jira fix committed to<br>
2.2.15.Final?<br>
<br>
<a href="https://issues.jboss.org/browse/WELD-1931" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/WELD-1931</a><br>
<br>
I would like to consume this and see how much improvement has been<br>
made.<br>
<br>
--<br>
Thanks<br>
Emily<br>
=================<br>
Emily Jiang<br></span>
<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>><br>
</blockquote><span class="">
<br>
<br>
<br>
<br>
--<br>
Thanks<br>
Emily<br>
=================<br>
Emily Jiang<br>
</span><a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>><br>
</blockquote>
<br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">Thanks<br>Emily<br>=================<br>Emily Jiang<br><a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a><br></div>
</div>