<div dir="ltr"><div><div>Thanks Martin for your comments! The issue is that the current jira <a href="https://issues.jboss.org/browse/WELD-1931">https://issues.jboss.org/browse/WELD-1931</a> was not committed to 2.2.15.Final release. Is it possible for you to commit the jira and do another release?<br></div>Thank you very much!<br></div>Emily<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Aug 3, 2015 at 4:12 PM, Martin Kouba <span dir="ltr"><<a href="mailto:mkouba@redhat.com" target="_blank">mkouba@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Emily,<br>
<br>
Weld 2.2.15 has been released (available in maven central, see also <a href="http://weld.cdi-spec.org/download/" rel="noreferrer" target="_blank">http://weld.cdi-spec.org/download/</a>).<br>
<br>
Martin<br>
<br>
Dne 2.8.2015 v 23:45 Emily Jiang napsal(a):<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
Hi Jozef/Martin,<br>
Can you please commit the performance changes for this jar and release<br>
2.2.15.Final as soon as possible?<br>
Thanks<br>
Emily<br>
<br>
On Tue, Jul 21, 2015 at 12:31 PM, Emily Jiang <<a href="mailto:emijiang6@googlemail.com" target="_blank">emijiang6@googlemail.com</a><br></span><span class="">
<mailto:<a href="mailto:emijiang6@googlemail.com" target="_blank">emijiang6@googlemail.com</a>>> wrote:<br>
<br>
Thank you Jozef and Martin! I am looking forward to consume<br>
2.2.15.Final.<br>
<br>
On Mon, Jul 20, 2015 at 2:18 PM, Jozef Hartinger<br></span><span class="">
<<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a> <mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a>>> wrote:<br>
<br>
Hi Emily,<br>
<br></span><span class="">
thanks for the feedback. We're currently busy with other<br>
releases but I'll try to get 2.2.15.Final released soon.<br>
<br>
Jozef<br>
<br>
On 20.7.2015 14:43, Emily Jiang wrote:<br>
<br>
The test applications we used were attached to the jira<br>
<a href="https://developer.jboss.org/message/926035#926035" rel="noreferrer" target="_blank">https://developer.jboss.org/message/926035#926035</a>.<br>
<br>
You can compare the responding time between two servlet<br>
requests.<br>
<br>
Can you commit the current changes in the release<br>
2.2.15.Final because<br>
I plan to consume this release for other jira fixes as well?<br>
Thanks<br>
Emily<br>
<br>
On Mon, Jul 20, 2015 at 11:15 AM, Martin Kouba<br>
<<a href="mailto:mkouba@redhat.com" target="_blank">mkouba@redhat.com</a> <mailto:<a href="mailto:mkouba@redhat.com" target="_blank">mkouba@redhat.com</a>><br></span><div><div class="h5">
<mailto:<a href="mailto:mkouba@redhat.com" target="_blank">mkouba@redhat.com</a> <mailto:<a href="mailto:mkouba@redhat.com" target="_blank">mkouba@redhat.com</a>>>> wrote:<br>
<br>
Hi Emily,<br>
<br>
it's great to hear there is a performance improvement<br>
(although 1%<br>
is not that much). We're working on further performance<br>
improvements<br>
in this area [1].<br>
<br>
However, 23% additional overhead seems to me too much.<br>
Would it be<br>
possible to share your performance test case / test<br>
application? We<br>
could run similar tests in our environment and verify<br>
that there's<br>
no integration problem.<br>
<br>
Martin<br>
<br>
[1]<br>
<a href="https://issues.jboss.org/browse/WELD-1970" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/WELD-1970</a><br>
<br>
<br>
Dne 20.7.2015 v 11:12 Emily Jiang napsal(a):<br>
<br>
Hi Jozef, Martin,<br>
<br>
Sorry for the delay! I have the performance figure<br>
collected<br>
eventually.<br>
With this Jira's changes, it shows 1% performance<br>
improvement.<br>
This is a<br>
step in the right direction but there is still a<br>
performance hit<br>
(23%<br>
worse) when turning on CDI. Would you like to<br>
commit this change<br>
so that<br>
I can reconsume this release? It will be great if a<br>
further<br>
performance<br>
improvement can be done. I am happy to collect the<br>
performance<br>
benchmark<br>
if needed.<br>
<br>
Thanks<br>
Emily<br>
<br>
On Thu, Jul 2, 2015 at 8:35 AM, Jozef Hartinger<br>
<<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a> <mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a>><br>
<mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a> <mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a>>><br>
<mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a><br>
<mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a>> <mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a><br>
<mailto:<a href="mailto:jharting@redhat.com" target="_blank">jharting@redhat.com</a>>>>> wrote:<br>
<br>
Hi Emily,<br>
<br>
that should not be a problem. Would it be<br>
possible for you<br>
to test<br>
the performance improvement before we actually<br>
do the<br>
release? I can<br>
prepare a separate branch or send you a<br>
binary. I would<br>
like to see<br>
how much improvement this makes in your benchmark.<br>
<br>
Jozef<br>
<br>
<br>
On 07/01/2015 06:19 PM, Emily Jiang wrote:<br>
<br>
Is it possible to get the following jira<br>
fix committed to<br>
2.2.15.Final?<br>
<br>
<a href="https://issues.jboss.org/browse/WELD-1931" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/WELD-1931</a><br>
<br>
I would like to consume this and see how much<br>
improvement has been<br>
made.<br>
<br>
--<br>
Thanks<br>
Emily<br>
=================<br>
Emily Jiang<br>
<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>>><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>>>><br>
<br>
<br>
<br>
<br>
<br>
--<br>
Thanks<br>
Emily<br>
=================<br>
Emily Jiang<br>
<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>>><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>>>><br>
<br>
<br>
<br>
<br>
<br>
--<br>
Thanks<br>
Emily<br>
=================<br>
Emily Jiang<br>
<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>><br>
<mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>>><br>
<br>
<br>
<br>
<br>
--<br>
Thanks<br>
Emily<br>
=================<br>
Emily Jiang<br>
<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>><br>
<br>
<br>
<br>
<br>
--<br>
Thanks<br>
Emily<br>
=================<br>
Emily Jiang<br>
</div></div><a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a> <mailto:<a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a>><br>
</blockquote>
<br>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature">Thanks<br>Emily<br>=================<br>Emily Jiang<br><a href="mailto:ejiang@apache.org" target="_blank">ejiang@apache.org</a><br></div>
</div>