<font size=2 face="sans-serif">Hello Martin. <br>
<br>
Thank you for the feedback. <br>
<br>
Moving the change to AbstractSessionBeanStore.get(BeanIdentifier) sounds
like a good idea, and I am happy to change the config property name to
anything you would like. What did you have in mind? <br>
<br>
In regards to point 2, I believe my customer's configuration will afford
us some leeway. Providing that the caching still allows a call to get()
once every two minuets I think we will not have a problem. As always though,
the proof will be testing it, I was able to get the customer's test application
working with the WIP fix I wrote so hopefully their live application will
work too. <br>
<br>
If you can think of any strategy for writing an automated test let me know.
Apart from that I expect I will have new commits based on your suggestion
soom. <br>
<br>
Regards<br>
Benjamin<br>
<br>
</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Martin Kouba <mkouba@redhat.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">Benjamin Confino <BENJAMIC@uk.ibm.com>,
weld-dev@lists.jboss.org</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">18/04/2018 13:04</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [weld-dev]
WIP fix for </font><a href="https://issues.jboss.org/browse/WELD-1130"><font size=1 face="sans-serif">https://issues.jboss.org/browse/WELD-1130</font></a>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>Hi Benjamin,<br>
<br>
I'm sorry but the Weld team is burried under some high priority issues.
<br>
I've quickly went through your proposal and have few comments.<br>
<br>
1. I think it would be more convenient to modify <br>
org.jboss.weld.module.web.context.beanstore.http.AbstractSessionBeanStore.getAttribute(String)
<br>
which is used for both the HTTP session and the conversation contexts<br>
<br>
2. +1 for config property, we probably need a better name though ;-)<br>
<br>
3. You're probably aware that this would not solve the problem <br>
completely. It should trigger the replication when a @SessionScoped bean
<br>
instance is obtained from the context, e.g. when a client proxy method
<br>
is invoked. However, there are some optimizations in Weld which prevent
<br>
the context lookup (see also <br>
org.jboss.weld.bean.ContextualInstanceStrategy). Also the replication <br>
may happen before the state is actually changed - it really depends on
<br>
replication impl details. Still, I agree that this would improve the <br>
usability.<br>
<br>
4. +10 for tests. But I guess it would be tricky to write an automated
<br>
test for this.<br>
<br>
Martin<br>
<br>
Dne 13.4.2018 v 21:33 Benjamin Confino napsal(a):<br>
> Hello<br>
> <br>
> I posed <br>
> </font></tt><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_benjamin-2Dconfino_core_commit_35d055cd9a841cfbdf2bcb2aaa3e0d8d6116ec1cto&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=h44psnUUWe961Di4IEKfnHhsSfRzXKxVIpAMgp2r0LI&s=v_EHx3focK723Wv9TX7fVy4pYYq7or0XSJVFhVrezPo&e="><tt><font size=2>https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_benjamin-2Dconfino_core_commit_35d055cd9a841cfbdf2bcb2aaa3e0d8d6116ec1cto&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=h44psnUUWe961Di4IEKfnHhsSfRzXKxVIpAMgp2r0LI&s=v_EHx3focK723Wv9TX7fVy4pYYq7or0XSJVFhVrezPo&e=</font></tt></a><tt><font size=2>
<br>
> this lift list month but have not heard any feedback. When can I expect
<br>
> to hear if this concept is good in principal? If the concept is good
I <br>
> can begin investigating how to extend the idea to conversation scopes
<br>
> and write a test.<br>
> <br>
> Regards<br>
> Benjamin<br>
> Unless stated otherwise above:<br>
> IBM United Kingdom Limited - Registered in England and Wales with
number <br>
> 741598.<br>
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6 3AU<br>
> <br>
> <br>
> _______________________________________________<br>
> weld-dev mailing list<br>
> weld-dev@lists.jboss.org<br>
> </font></tt><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=h44psnUUWe961Di4IEKfnHhsSfRzXKxVIpAMgp2r0LI&s=zmOPLMTgosB3_X_zWg_rgSt6EgDlEZTmkAKbg6eRs-o&e="><tt><font size=2>https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=h44psnUUWe961Di4IEKfnHhsSfRzXKxVIpAMgp2r0LI&s=zmOPLMTgosB3_X_zWg_rgSt6EgDlEZTmkAKbg6eRs-o&e=</font></tt></a><tt><font size=2><br>
> <br>
<br>
</font></tt>
<br>
<br><font size=2 face="sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</font>