<font size=2 face="sans-serif">Hello<br>
<br>
Pull requests for the updated patch are up :) If anyone has a better name
for the property please let me know. <br>
<br>
Regards<br>
Benjamin</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Martin Kouba <mkouba@redhat.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">Benjamin Confino <BENJAMIC@uk.ibm.com>,
weld-dev@lists.jboss.org</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">18/04/2018 13:22</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [weld-dev]
WIP fix for </font><a href="https://issues.jboss.org/browse/WELD-1130"><font size=1 face="sans-serif">https://issues.jboss.org/browse/WELD-1130</font></a>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>Dne 18.4.2018 v 14:02 Martin Kouba napsal(a):<br>
> Hi Benjamin,<br>
> <br>
> I'm sorry but the Weld team is burried under some high priority issues.
<br>
> I've quickly went through your proposal and have few comments.<br>
> <br>
> 1. I think it would be more convenient to modify <br>
> org.jboss.weld.module.web.context.beanstore.http.AbstractSessionBeanStore.getAttribute(String)
<br>
<br>
Sorry, I meant <br>
org.jboss.weld.module.web.context.beanstore.http.AbstractSessionBeanStore.get(BeanIdentifier)<br>
<br>
> which is used for both the HTTP session and the conversation contexts<br>
> <br>
> 2. +1 for config property, we probably need a better name though ;-)<br>
> <br>
> 3. You're probably aware that this would not solve the problem <br>
> completely. It should trigger the replication when a @SessionScoped
bean <br>
> instance is obtained from the context, e.g. when a client proxy method
<br>
> is invoked. However, there are some optimizations in Weld which prevent
<br>
> the context lookup (see also <br>
> org.jboss.weld.bean.ContextualInstanceStrategy). Also the replication
<br>
> may happen before the state is actually changed - it really depends
on <br>
> replication impl details. Still, I agree that this would improve the
<br>
> usability.<br>
> <br>
> 4. +10 for tests. But I guess it would be tricky to write an automated
<br>
> test for this.<br>
> <br>
> Martin<br>
> <br>
> Dne 13.4.2018 v 21:33 Benjamin Confino napsal(a):<br>
>> Hello<br>
>><br>
>> I posed <br>
>> </font></tt><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_benjamin-2Dconfino_core_commit_35d055cd9a841cfbdf2bcb2aaa3e0d8d6116ec1cto&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=-ZUKVCrQQ5XNALx_gpYc6uHtIB2aBo3vfdvhPFMyGq4&s=8MGYr6cF9UfBNJIHJLA4qMWaJNF5zfqmbTsMLN6LMjY&e="><tt><font size=2>https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_benjamin-2Dconfino_core_commit_35d055cd9a841cfbdf2bcb2aaa3e0d8d6116ec1cto&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=-ZUKVCrQQ5XNALx_gpYc6uHtIB2aBo3vfdvhPFMyGq4&s=8MGYr6cF9UfBNJIHJLA4qMWaJNF5zfqmbTsMLN6LMjY&e=</font></tt></a><tt><font size=2>
<br>
>> this lift list month but have not heard any feedback. When can
I <br>
>> expect to hear if this concept is good in principal? If the concept
is <br>
>> good I can begin investigating how to extend the idea to conversation
<br>
>> scopes and write a test.<br>
>><br>
>> Regards<br>
>> Benjamin<br>
>> Unless stated otherwise above:<br>
>> IBM United Kingdom Limited - Registered in England and Wales with
<br>
>> number 741598.<br>
>> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6 <br>
>> 3AU<br>
>><br>
>><br>
>> _______________________________________________<br>
>> weld-dev mailing list<br>
>> weld-dev@lists.jboss.org<br>
>> </font></tt><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=-ZUKVCrQQ5XNALx_gpYc6uHtIB2aBo3vfdvhPFMyGq4&s=V5hOUdwYU955kSnYhICFsY4JC-dIfRT_9wxy9_cAsVo&e="><tt><font size=2>https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.jboss.org_mailman_listinfo_weld-2Ddev&d=DwIC-g&c=jf_iaSHvJObTbx-siA1ZOg&r=hl8XiFr1UrTSgyXVc4KO_i51sM3Gyhlu1KZ4TkyseEQ&m=-ZUKVCrQQ5XNALx_gpYc6uHtIB2aBo3vfdvhPFMyGq4&s=V5hOUdwYU955kSnYhICFsY4JC-dIfRT_9wxy9_cAsVo&e=</font></tt></a><tt><font size=2><br>
>><br>
<br>
-- <br>
Martin Kouba<br>
Senior Software Engineer<br>
Red Hat, Czech Republic<br>
<br>
</font></tt>
<br>
<br><font size=2 face="sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</font>