<font size=2 face="sans-serif">Good morning. <br>
<br>
No worries about Weld 2 releases, I've already informed the team of the
situation regarding that branch, but I thought it was no trouble to submit
a PR anyway.<br>
<br>
Regarding your question about verification, my understanding of where things
are is that we shifted to looking for a more general solution to make liberty
more resilient as we promptly uncovered a different upstream component
that had a stream without a closing statement. Tom Bitonti will be taking
the lead on that. <br>
<br>
Regards<br>
Benjamin</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Matej Novotny <manovotn@redhat.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">Benjamin Confino <BENJAMIC@uk.ibm.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">Cc:
</font><font size=1 face="sans-serif">weld-dev@lists.jboss.org,
Thomas Bitonti <bitonti@us.ibm.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">09/12/2019 10:12</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">[EXTERNAL] Re:
[weld-dev] Pull Request to close weld.properties file sooner</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>Hello,<br>
<br>
thanks for the PR. We're totally missing the stream closing statement there.<br>
I take it you verified that this fixes the problem in Liberty?<br>
<br>
Otherwise, master branch (Weld 3.1) is totally where these PRs should go.<br>
As for 3.0, we do not plan any releases there, we are going forward with
just 3.1 branch.<br>
So I don't really see much value in merging it there.<br>
Last but not least, Weld 2 is not actively developed anymore and doesn't
have a set release schedule.<br>
Therefore, we can merge it there, but with no promises on release dates.<br>
<br>
I've created a tracking JIRA for this - </font></tt><a href="https://issues.redhat.com/browse/WELD-2606"><tt><font size=2>https://issues.redhat.com/browse/WELD-2606</font></tt></a><tt><font size=2>
<br>
<br>
Regards<br>
Matej<br>
<br>
----- Original Message -----<br>
> From: "Benjamin Confino" <BENJAMIC@uk.ibm.com><br>
> To: weld-dev@lists.jboss.org<br>
> Cc: "Thomas Bitonti" <bitonti@us.ibm.com><br>
> Sent: Saturday, December 7, 2019 12:34:17 PM<br>
> Subject: [weld-dev] Pull Request to close weld.properties file sooner<br>
> <br>
> Hello<br>
> <br>
> We encountered a bug in liberty which we think is caused by the<br>
> weld.properties file remaining open for longer than liberty expects
files to<br>
> be held open. To resolve this I have submitted a trio of small pull
requests<br>
> that will close the InputStream in a finally block after weld.properties
is<br>
> read. You can find them at:<br>
> <br>
> </font></tt><a href="https://github.com/weld/core/pull/1953"><tt><font size=2>https://github.com/weld/core/pull/1953</font></tt></a><tt><font size=2>
<br>
> </font></tt><a href="https://github.com/weld/core/pull/1954"><tt><font size=2>https://github.com/weld/core/pull/1954</font></tt></a><tt><font size=2>
<br>
> </font></tt><a href="https://github.com/weld/core/pull/1955"><tt><font size=2>https://github.com/weld/core/pull/1955</font></tt></a><tt><font size=2>
<br>
> <br>
> I hope these PRs meet with your approval.<br>
> <br>
> Regards<br>
> Benjamin<br>
> Unless stated otherwise above:<br>
> IBM United Kingdom Limited - Registered in England and Wales with
number<br>
> 741598.<br>
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6 3AU<br>
> <br>
> _______________________________________________<br>
> weld-dev mailing list<br>
> weld-dev@lists.jboss.org<br>
> </font></tt><a href="https://lists.jboss.org/mailman/listinfo/weld-dev"><tt><font size=2>https://lists.jboss.org/mailman/listinfo/weld-dev</font></tt></a><tt><font size=2>
<br>
<br>
<br>
</font></tt>
<br>
<br><font size=2 face="sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</font>