<font size=2 face="sans-serif">Hello, two PRs coming right up: <br>
<br>
</font><a href="https://github.com/weld/core/pull/1967"><font size=2 color=blue face="sans-serif">https://github.com/weld/core/pull/1967</font></a><font size=2 face="sans-serif"><br>
</font><a href="https://github.com/weld/core/pull/1966"><font size=2 color=blue face="sans-serif">https://github.com/weld/core/pull/1966</font></a><font size=2 face="sans-serif"><br>
<br>
I tested it locally by compiling the class and pasting it into my liberty
server, it all looks good.<br>
<br>
Regards<br>
Benjamin </font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Matej Novotny <manovotn@redhat.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">Benjamin Confino <BENJAMIC@uk.ibm.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">Cc:
</font><font size=1 face="sans-serif">weld-dev@lists.jboss.org,
Takayuki T Ishii <EBB0F3L@jp.ibm.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">21/02/2020 07:52</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">[EXTERNAL] Re:
[weld-dev] Follow up to WELD-2611</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>Hi,<br>
<br>
good catch! Go ahead and send the PRs, I'll reopen that WELD issue and
link them to it.<br>
Also, please add a test for this (basically just enhance the one I had
in </font></tt><a href="https://github.com/weld/core/pull/1962/files"><tt><font size=2>https://github.com/weld/core/pull/1962/files</font></tt></a><tt><font size=2>
).<br>
<br>
Matej<br>
<br>
----- Original Message -----<br>
> From: "Benjamin Confino" <BENJAMIC@uk.ibm.com><br>
> To: weld-dev@lists.jboss.org<br>
> Cc: "Takayuki T Ishii" <EBB0F3L@jp.ibm.com><br>
> Sent: Thursday, February 20, 2020 10:20:25 PM<br>
> Subject: [weld-dev] Follow up to WELD-2611<br>
> <br>
> Hello<br>
> <br>
> I heard back from my excellent L2 support colleague who has tested
the weld<br>
> fix and he says that it works perfect when you append something like<br>
> "?cid=100000" to the url but not if you append "?cid="
I debugged into the<br>
> code and I believe that what is happening is that:<br>
> <br>
> AbstractConversationContext .initilize treats a null or an isEmpty()
cid as<br>
> as a trigger to enter the else block and call<br>
> associateRequestWithNewConversation()<br>
> <br>
> However LazyHttpConversationContextImpl .checkContextInitialized()
only calls<br>
> fireInitEvent() for a null cid or in the catch block for a<br>
> ConversationNotActiveException.<br>
> <br>
> The two methods have differing understandings of what's triggers a
new<br>
> conversation, so the "?cid=" case falls through the gap.
I think this can be<br>
> fixed by adding an "|| cid.isEmpty()" to LazyHttpConversationContextImpl<br>
> .checkContextInitialized() above the non-catch block call to<br>
> fireInitEvent(), if you agree I can spin up a couple of pull requests.<br>
> <br>
> Regards<br>
> Benjamin<br>
> Unless stated otherwise above:<br>
> IBM United Kingdom Limited - Registered in England and Wales with
number<br>
> 741598.<br>
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6 3AU<br>
> <br>
> _______________________________________________<br>
> weld-dev mailing list<br>
> weld-dev@lists.jboss.org<br>
> </font></tt><a href="https://lists.jboss.org/mailman/listinfo/weld-dev"><tt><font size=2>https://lists.jboss.org/mailman/listinfo/weld-dev</font></tt></a><tt><font size=2>
<br>
<br>
</font></tt>
<br>
<br><font size=2 face="sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</font>