<font size=2 face="sans-serif">You're welcome<br>
<br>
Regards<br>
Benjamin</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Matej Novotny <manovotn@redhat.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">Benjamin Confino <BENJAMIC@uk.ibm.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">Cc:
</font><font size=1 face="sans-serif">Takayuki T Ishii <EBB0F3L@jp.ibm.com>,
weld-dev@lists.jboss.org</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">21/02/2020 11:58</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">[EXTERNAL] Re:
[weld-dev] Follow up to WELD-2611</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>Thanks!<br>
<br>
Matej<br>
<br>
----- Original Message -----<br>
> From: "Benjamin Confino" <BENJAMIC@uk.ibm.com><br>
> To: "Matej Novotny" <manovotn@redhat.com><br>
> Cc: "Takayuki T Ishii" <EBB0F3L@jp.ibm.com>, weld-dev@lists.jboss.org<br>
> Sent: Friday, February 21, 2020 11:35:26 AM<br>
> Subject: RE: [weld-dev] Follow up to WELD-2611<br>
> <br>
> Hello, two PRs coming right up:<br>
> <br>
> </font></tt><a href="https://github.com/weld/core/pull/1967"><tt><font size=2>https://github.com/weld/core/pull/1967</font></tt></a><tt><font size=2>
<br>
> </font></tt><a href="https://github.com/weld/core/pull/1966"><tt><font size=2>https://github.com/weld/core/pull/1966</font></tt></a><tt><font size=2>
<br>
> <br>
> I tested it locally by compiling the class and pasting it into my
liberty<br>
> server, it all looks good.<br>
> <br>
> Regards<br>
> Benjamin<br>
> <br>
> <br>
> <br>
> From: Matej Novotny <manovotn@redhat.com><br>
> To: Benjamin Confino <BENJAMIC@uk.ibm.com><br>
> Cc: weld-dev@lists.jboss.org, Takayuki T Ishii <EBB0F3L@jp.ibm.com><br>
> Date: 21/02/2020 07:52<br>
> Subject: [EXTERNAL] Re: [weld-dev] Follow
up to WELD-2611<br>
> <br>
> <br>
> <br>
> Hi,<br>
> <br>
> good catch! Go ahead and send the PRs, I'll reopen that WELD issue
and<br>
> link them to it.<br>
> Also, please add a test for this (basically just enhance the one I
had in<br>
> </font></tt><a href="https://github.com/weld/core/pull/1962/files"><tt><font size=2>https://github.com/weld/core/pull/1962/files</font></tt></a><tt><font size=2><br>
> ).<br>
> <br>
> Matej<br>
> <br>
> ----- Original Message -----<br>
> > From: "Benjamin Confino" <BENJAMIC@uk.ibm.com><br>
> > To: weld-dev@lists.jboss.org<br>
> > Cc: "Takayuki T Ishii" <EBB0F3L@jp.ibm.com><br>
> > Sent: Thursday, February 20, 2020 10:20:25 PM<br>
> > Subject: [weld-dev] Follow up to WELD-2611<br>
> > <br>
> > Hello<br>
> > <br>
> > I heard back from my excellent L2 support colleague who has tested
the<br>
> weld<br>
> > fix and he says that it works perfect when you append something
like<br>
> > "?cid=100000" to the url but not if you append "?cid="
I debugged into<br>
> the<br>
> > code and I believe that what is happening is that:<br>
> > <br>
> > AbstractConversationContext .initilize treats a null or an isEmpty()
cid<br>
> as<br>
> > as a trigger to enter the else block and call<br>
> > associateRequestWithNewConversation()<br>
> > <br>
> > However LazyHttpConversationContextImpl .checkContextInitialized()
only<br>
> calls<br>
> > fireInitEvent() for a null cid or in the catch block for a<br>
> > ConversationNotActiveException.<br>
> > <br>
> > The two methods have differing understandings of what's triggers
a new<br>
> > conversation, so the "?cid=" case falls through the
gap. I think this<br>
> can be<br>
> > fixed by adding an "|| cid.isEmpty()" to LazyHttpConversationContextImpl<br>
> > .checkContextInitialized() above the non-catch block call to<br>
> > fireInitEvent(), if you agree I can spin up a couple of pull
requests.<br>
> > <br>
> > Regards<br>
> > Benjamin<br>
> > Unless stated otherwise above:<br>
> > IBM United Kingdom Limited - Registered in England and Wales
with number<br>
> > 741598.<br>
> > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6<br>
> 3AU<br>
> > <br>
> > _______________________________________________<br>
> > weld-dev mailing list<br>
> > weld-dev@lists.jboss.org<br>
> > <br>
> </font></tt><a href="https://lists.jboss.org/mailman/listinfo/weld-dev"><tt><font size=2>https://lists.jboss.org/mailman/listinfo/weld-dev</font></tt></a><tt><font size=2><br>
> <br>
> <br>
> <br>
> <br>
> <br>
> Unless stated otherwise above:<br>
> IBM United Kingdom Limited - Registered in England and Wales with
number<br>
> 741598.<br>
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6 3AU<br>
> <br>
<br>
</font></tt>
<br>
<br><font size=2 face="sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</font>