<div dir="ltr">Ok, looking at comments. Yes, I would think we have to break the circularity with a weld release first so arq can be put out.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 20, 2020 at 10:06 AM Matej Novotny <<a href="mailto:manovotn@redhat.com">manovotn@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Delved into this a bit more.<br>
I've added several comments to relevant issues and filed some more PRs myself.<br>
<br>
I've also released Weld API 4.0.Alpha1 just now, so we can upgrade that in the core PR and Arq. Weld container PR.<br>
<br>
I am not quite sure how to handle that Weld <-> Arq. Weld container dependency. Apparently, they both need each other.<br>
I suppose we will have to get out Weld build that just skips tests for the first Alpha so that we can upgrade it there?<br>
Similar situation happens with CDI TCK, we cannot test them since we need GF to have Weld version first... chickens and eggs everywhere :)<br>
<br>
Matej<br>
<br>
----- Original Message -----<br>
> From: "Matej Novotny" <<a href="mailto:manovotn@redhat.com" target="_blank">manovotn@redhat.com</a>><br>
> To: "Scott Stark" <<a href="mailto:sstark@redhat.com" target="_blank">sstark@redhat.com</a>><br>
> Cc: "weld-dev" <<a href="mailto:weld-dev@lists.jboss.org" target="_blank">weld-dev@lists.jboss.org</a>><br>
> Sent: Friday, April 17, 2020 5:04:31 PM<br>
> Subject: Re: [weld-dev] [cdi-dev] How would I go about getting a snapshot build of Weld out?<br>
> <br>
> Awesome, thanks a lot!<br>
> I'll soon be going off for the weekend, so on Mon I can pick that up and try<br>
> to put it all together locally and see what's the issue.<br>
> <br>
> Matej<br>
> <br>
> ----- Original Message -----<br>
> > From: "Scott Stark" <<a href="mailto:sstark@redhat.com" target="_blank">sstark@redhat.com</a>><br>
> > To: "Matej Novotny" <<a href="mailto:manovotn@redhat.com" target="_blank">manovotn@redhat.com</a>><br>
> > Cc: "weld-dev" <<a href="mailto:weld-dev@lists.jboss.org" target="_blank">weld-dev@lists.jboss.org</a>><br>
> > Sent: Friday, April 17, 2020 4:38:16 PM<br>
> > Subject: Re: [cdi-dev] How would I go about getting a snapshot build of<br>
> > Weld out?<br>
> > <br>
> > I just replaced the previous PR with one that targets master. I seemed to<br>
> > need to update quite a few more things or somehow did not notice their<br>
> > impact when being based off the 3.0 branch. It is relying on snapshot<br>
> > builds of weld-api, arquillian-core, and arquillian-weld-embedded. I<br>
> > believe I have all of this documented in the root JakartaEE9.adoc.<br>
> > <br>
> > The current failures look like that the weld-se test classpath is not<br>
> > including the weld-spi classes, but I have not had time to look into the<br>
> > details.<br>
> > <br>
> > <br>
> > On Thu, Apr 16, 2020 at 9:28 AM Matej Novotny <<a href="mailto:manovotn@redhat.com" target="_blank">manovotn@redhat.com</a>> wrote:<br>
> > <br>
> > > Hmm, I am not sure I am on that list, even though I am pretty sure I<br>
> > > applied earlier. Will try again.<br>
> > ><br>
> > > ----- Original Message -----<br>
> > > > From: "Scott Stark" <<a href="mailto:sstark@redhat.com" target="_blank">sstark@redhat.com</a>><br>
> > > > To: "Matej Novotny" <<a href="mailto:manovotn@redhat.com" target="_blank">manovotn@redhat.com</a>><br>
> > > > Cc: "weld-dev" <<a href="mailto:weld-dev@lists.jboss.org" target="_blank">weld-dev@lists.jboss.org</a>><br>
> > > > Sent: Thursday, April 16, 2020 3:32:07 PM<br>
> > > > Subject: Re: [cdi-dev] How would I go about getting a snapshot build of<br>
> > > Weld out?<br>
> > > ><br>
> > > > Ok, I'll look at the comments.<br>
> > > ><br>
> > > > There is someone on the jakartaee redhat list who can do the Arq<br>
> > > > release.<br>
> > > ><br>
> > > > On Thu, Apr 16, 2020 at 8:29 AM Matej Novotny <<a href="mailto:manovotn@redhat.com" target="_blank">manovotn@redhat.com</a>><br>
> > > wrote:<br>
> > > ><br>
> > > > > I've added comments to both PRs.<br>
> > > > ><br>
> > > > > Meanwhile, on weld core and api I created 3.1 branches so master can<br>
> > > move<br>
> > > > > on to 4.x snapshots.<br>
> > > > > Weld JIRA now also holds a version for 4.0.0.Alpha1 the date being<br>
> > > > > tentative based on other releases we need to do.<br>
> > > > > I also plan to look into CI and other setups that will be needed to<br>
> > > have<br>
> > > > > some testing enabled (currently with pack. changes all PRs will<br>
> > > inevitably<br>
> > > > > fail since they run against WFLY).<br>
> > > > ><br>
> > > > > We also need to find someone who has the power to release Arq and<br>
> > > > > align<br>
> > > > > the release with them.<br>
> > > > > I can see us going for (1) Arq. core release, then (2)weld-arq.<br>
> > > container<br>
> > > > > and then (3) weld api and core.<br>
> > > > ><br>
> > > > > Matej<br>
> > > > ><br>
> > > > > ----- Original Message -----<br>
> > > > > > From: "Scott Stark" <<a href="mailto:sstark@redhat.com" target="_blank">sstark@redhat.com</a>><br>
> > > > > > To: "Matej Novotny" <<a href="mailto:manovotn@redhat.com" target="_blank">manovotn@redhat.com</a>><br>
> > > > > > Cc: "weld-dev" <<a href="mailto:weld-dev@lists.jboss.org" target="_blank">weld-dev@lists.jboss.org</a>><br>
> > > > > > Sent: Thursday, April 16, 2020 2:34:02 AM<br>
> > > > > > Subject: Re: [cdi-dev] How would I go about getting a snapshot<br>
> > > > > > build<br>
> > > of<br>
> > > > > Weld out?<br>
> > > > > ><br>
> > > > > > I have a fork of the arq core that I have created a PR from to add<br>
> > > > > Jakarta<br>
> > > > > > EE 9 based testenrichers:<br>
> > > > > > <a href="https://github.com/arquillian/arquillian-core/pull/238" rel="noreferrer" target="_blank">https://github.com/arquillian/arquillian-core/pull/238</a><br>
> > > > > ><br>
> > > > > > The updated weld 4.0 branch PR has just been created as well:<br>
> > > > > > <a href="https://github.com/weld/core/pull/1979" rel="noreferrer" target="_blank">https://github.com/weld/core/pull/1979</a><br>
> > > > > ><br>
> > > > > > On Wed, Apr 15, 2020 at 7:11 PM Matej Novotny <<a href="mailto:manovotn@redhat.com" target="_blank">manovotn@redhat.com</a>><br>
> > > > > wrote:<br>
> > > > > ><br>
> > > > > > > Hmm, arq. test enricher has some ancient dependencies. In fact,<br>
> > > they<br>
> > > > > rely<br>
> > > > > > > on CDI 1.0 (and therefore Weld 1.x). Looking closely at the code,<br>
> > > it<br>
> > > > > looks<br>
> > > > > > > like Weld dependency is only needed for tests, for actual impl,<br>
> > > > > > > CDI<br>
> > > > > will<br>
> > > > > > > do.<br>
> > > > > > > And the test can be re-written to avoid using Weld internal<br>
> > > completely<br>
> > > > > > > assuming we are on CDI 2.0+, here is how -<br>
> > > > > > > <a href="https://github.com/arquillian/arquillian-core/pull/239" rel="noreferrer" target="_blank">https://github.com/arquillian/arquillian-core/pull/239</a>. With this<br>
> > > > > change<br>
> > > > > > > you only need to pass in CDI SE impl as test dependency and it<br>
> > > > > > > will<br>
> > > > > work<br>
> > > > > > > (still means you need one release for another though, so one has<br>
> > > > > > > to<br>
> > > > > release<br>
> > > > > > > without tests passing).<br>
> > > > > > > However, the actual issue in Arq. is that it now looks for now<br>
> > > outdated<br>
> > > > > > > annotation[1].<br>
> > > > > > > Which I presume is something you have fixed locally? I did check<br>
> > > your<br>
> > > > > > > repos but couldn't find fork of Arq. core. I can fix that as well<br>
> > > if<br>
> > > > > you<br>
> > > > > > > don't have it already.<br>
> > > > > > ><br>
> > > > > > > I've also checked other repos:<br>
> > > > > > > * The core PR[2] you closed was built from Weld's 3.0 branch<br>
> > > which is<br>
> > > > > > > wrong, we need that against current master to be up to date<br>
> > > > > > > - on the PR you said you have something else already, can you<br>
> > > push it<br>
> > > > > > > please? If you don't have it, I can do that as well; I just don't<br>
> > > want<br>
> > > > > to<br>
> > > > > > > duplicate work<br>
> > > > > > > * API PR[3] misses one commit from current master, otherwise<br>
> > > > > > > it's<br>
> > > good<br>
> > > > > > ><br>
> > > > > > > Regards<br>
> > > > > > > Matej<br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > ><br>
> > > ______________________________________________________________________________________________<br>
> > > > > > > [1]<br>
> > > > > > ><br>
> > > > ><br>
> > > <a href="https://github.com/arquillian/arquillian-core/blob/master/testenrichers/cdi/src/main/java/org/jboss/arquillian/testenricher/cdi/CDIInjectionEnricher.java#L37" rel="noreferrer" target="_blank">https://github.com/arquillian/arquillian-core/blob/master/testenrichers/cdi/src/main/java/org/jboss/arquillian/testenricher/cdi/CDIInjectionEnricher.java#L37</a><br>
> > > > > > > [2] <a href="https://github.com/weld/core/pull/1956" rel="noreferrer" target="_blank">https://github.com/weld/core/pull/1956</a><br>
> > > > > > > [3] <a href="https://github.com/weld/api/pull/91" rel="noreferrer" target="_blank">https://github.com/weld/api/pull/91</a><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > > ><br>
> > > > > ><br>
> > > > ><br>
> > > > ><br>
> > > ><br>
> > ><br>
> > ><br>
> > <br>
> _______________________________________________<br>
> weld-dev mailing list<br>
> <a href="mailto:weld-dev@lists.jboss.org" target="_blank">weld-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/weld-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/weld-dev</a><br>
> <br>
<br>
</blockquote></div>