<font size=2 face="sans-serif">Thank you for the heads up. When it's time
to think about delivery I'll be sure to create a PR against 3.1 and I presume
you'd like me to leave master alone for now? <br>
<br>
Regards<br>
Benjamin</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Matej Novotny <manovotn@redhat.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">Benjamin Confino <BENJAMIC@uk.ibm.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">Cc:
</font><font size=1 face="sans-serif">weld-dev@lists.jboss.org,
Allan Zhang <zhang@ca.ibm.com>, Shinji Ohtsuka <EB92769@jp.ibm.com>,
Emily Jiang <EMIJIANG@uk.ibm.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">29/04/2020 09:51</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">[EXTERNAL] Re:
[weld-dev] Propagation of org.jboss.weld.context.ConversationContext.conversations
through session failover</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>Hi,<br>
<br>
I'll take a look later today.<br>
Note that master branch is no longer Weld 3.x, it is 4.x (Jakarta EE 9)
and the CI there is going bonkers yet as I am in the middle of changing
it.<br>
If you want to file a PR against Weld 3, you can use 3.1 branch for that.<br>
<br>
Regards<br>
Matej<br>
<br>
----- Original Message -----<br>
> From: "Benjamin Confino" <BENJAMIC@uk.ibm.com><br>
> To: weld-dev@lists.jboss.org<br>
> Cc: "Allan Zhang" <zhang@ca.ibm.com>, "Shinji
Ohtsuka" <EB92769@jp.ibm.com>, "Emily Jiang" <EMIJIANG@uk.ibm.com><br>
> Sent: Tuesday, April 28, 2020 2:31:44 PM<br>
> Subject: [weld-dev] Propagation of org.jboss.weld.context.ConversationContext.conversations
through session failover<br>
> <br>
> Hello weld<br>
> <br>
> I had a customer report that they were getting conversation not found<br>
> exceptions when restarting their server and visiting a url with a
?cid=1<br>
> suffix.<br>
> <br>
> After investigation I believe the issue is that weld was acquiring
it's<br>
> ConversationContext.conversations from the session database via<br>
> com.ibm.ws.session.store.db.DatabaseSession.getMultiRowAppData().
Once weld<br>
> had retrieved the conversations map it would then decide that since
the map<br>
> was already in the session attributes there was no need to put it
back into<br>
> the attributes.<br>
> <br>
> This means that Liberty did not realise the conversations map had
been<br>
> updated, and did not store it's updated state into the database when
the<br>
> server shut down again.<br>
> <br>
> I have submitted a pair of pull requests that asks weld to mark the<br>
> conversation map as dirty upon access - this behaviour is gated behind<br>
> ConfigurationKey.RESET_HTTP_SESSION_ATTR_ON_BEAN_ACCESS - I have tested
it<br>
> locally and it works. The next step is to prepare a test fix for the<br>
> customer to verify. However I wanted to send you this quick note to
keep you<br>
> in the loop.<br>
> <br>
> Regards<br>
> Benjamin<br>
> Unless stated otherwise above:<br>
> IBM United Kingdom Limited - Registered in England and Wales with
number<br>
> 741598.<br>
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire
PO6 3AU<br>
> <br>
> _______________________________________________<br>
> weld-dev mailing list<br>
> weld-dev@lists.jboss.org<br>
> </font></tt><a href="https://lists.jboss.org/mailman/listinfo/weld-dev"><tt><font size=2>https://lists.jboss.org/mailman/listinfo/weld-dev</font></tt></a><tt><font size=2>
<br>
<br>
</font></tt>
<br>
<br><font size=2 face="sans-serif"><br>
Unless stated otherwise above:<br>
IBM United Kingdom Limited - Registered in England and Wales with number
741598. <br>
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU<br>
</font>