<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3b4d64" style="background-color:#3b4d64;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://issues.jboss.org/s/en_US-g3yjjf/733/58/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://community.jboss.org/people/kennardconsulting/avatar/16.png" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="kennardconsulting" id="email_kennardconsulting" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=kennardconsulting" style="color:#003366;">Richard Kennard</a>
commented on <img src="https://issues.jboss.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#003366;text-decoration:none;' href='https://issues.jboss.org/browse/WELD-1144'>WELD-1144</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#003366;text-decoration:none;' href='https://issues.jboss.org/browse/WELD-1144'><strong>Superclass of processed AnnotationType is ignored</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>As discussed on IRC:</p>
<p><luksa> kennardconsult: the thing is, I did post a message to weld-dev mailing list asking why weld sets Object.class as the superclass for some beans (ths is what's causing your problem)<br/>
<kennardconsult> luksa: there was no response?<br/>
<luksa> kennardconsult: and I haven't really received any useful info on that yet. Supposedly, it needs to be so... <br/>
<luksa> <a href="http://lists.jboss.org/pipermail/weld-dev/2012-July/003046.html">http://lists.jboss.org/pipermail/weld-dev/2012-July/003046.html</a><br/>
...<br/>
<alesj> kennardconsult: I think the superclass behavior is defined by the spec, as Stuart suggested<br/>
...<br/>
<pmuir> luksa: it probably is, but unlesss you are 100% sure, i woudn't change the behavior<br/>
<pmuir> e.g gf might be using it, or wls<br/>
<kennardconsult> alesj: okay, so can somebody reconcile the spec with what I'm trying to do in <a href="https://issues.jboss.org/browse/WELD-1144" title="Superclass of processed AnnotationType is ignored">WELD-1144</a>. Is what I'm attempting illegal?<br/>
<alesj> kennardconsult: pmuir is best there, wrt spec - but I do rememebr I was looking at that superclass before, and it made sense at the end not to change the behavior<br/>
<kennardconsult> But in that case you can never do 1144, right? luksa, having looked at 1144, is what I'm trying to do unreasonable?<br/>
<alesj> kennardconsult: it can be done, afair - but your a bit stuck with less portable code, e.g. you need to use Weld's custom classes -<br/>
<alesj> - if I still rememeber correctly - <img class="emoticon" src="https://issues.jboss.org/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/><br/>
<kennardconsult> alesj: my code in 1144 is basically the same code as in the CDI Reference Guide. So I think something is broken here<br/>
<alesj> pmuir: ^ broken ref guide? <br/>
<pmuir> looking<br/>
<kennardconsult> pmuir: chapter 16.7 "Wrapping an AnnotatedType". You basically need to put a disclaimer saying 'this code will not work if any of your CDI beans have superclasses" <img class="emoticon" src="https://issues.jboss.org/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/><br/>
<luksa> kennardconsult: alesj: I really don't see how setting the superclass to Object.class could ever be OK. <br/>
<pmuir> luksa: so the issue is that annotatedType.getFields() doesn't return the fields on the super class, but then weld ignores the super class?<br/>
<pmuir> the idea is that the AnnotatedField list should contain <b>all</b> fields to inject in the entire class hierarchy<br/>
<pmuir> otherwise this can't work in any consistent way<br/>
<luksa> pmuir: yes, Beans.getFieldInjectionPoints only gets the declared fields of a WeldClass and then moves on to the superclass (which is Object.class in some cases)... therefore, it completely skips the declared fields of the actual superclass<br/>
<luksa> pmuir: and yes, since AnnotatedType.getFields() can be whatever someone wants, Beans.getFieldInjectionPoints() should not bypass it (by walking up the hierarchy itself)<br/>
<luksa> pmuir: ops, there are two Beans.getFieldInjectionPoints() methods.. I'm talking about the one at around line 189: public static List<Set<FieldInjectionPoint<?, ?>>> getFieldInjectionPoints(Bean<?> declaringBean, WeldClass<?> weldClass) {<br/>
<pmuir> luksa: yeah, I think that is more the problem<br/>
<pmuir> than the fact that Object.class is the superclass<br/>
<pmuir> ie. i would try to fix Beans<br/>
<pmuir> to do the correct injections<br/>
<pmuir> and basically that if someone has overridden getFields on AnnotatedType<br/>
<pmuir> they should be canonical<br/>
<luksa> mhm<br/>
<luksa> pmuir: ok, I'll go along that route...<br/>
<luksa> pmuir: tnx for the help<br/>
<kennardconsult> Thanks luksa, pmuir! I'll keep an eye on the JIRA<br/>
<pmuir> luksa: np</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your <a style='color:#003366;' href='https://issues.jboss.org/secure/ContactAdministrators!default.jspa'>JIRA administrators</a>.<br />
For more information on JIRA, see: <a style='color:#003366;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->