<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3b4d64" style="background-color:#3b4d64;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://issues.jboss.org/s/en_USss71tj/786/58/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://community.jboss.org/people/sarah.g/avatar/16.png" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="sarah.g" id="email_sarah.g" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=sarah.g" style="color:#003366;">Sarah Gerweck</a>
commented on <img src="https://issues.jboss.org/images/icons/bug.gif" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#003366;text-decoration:none;' href='https://issues.jboss.org/browse/WELD-1081'>WELD-1081</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#003366;text-decoration:none;' href='https://issues.jboss.org/browse/WELD-1081'><strong>Weld crashes when attempting to read malformed class names</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td colspan="2" style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 16px 0;width:100%;">
<div class="comment-block" style="background-color:#edf5ff;border:1px solid #dddddd;color:#000000;padding:12px;"><p>I would strongly urge you to reconsider your take on this. </p>
<p>Good frameworks follow the Robustness Principle, aka Postel's Law: </p>
<blockquote><p>Be conservative in what you do; be liberal in what you accept from others.</p></blockquote>
<p>Utilization of Scala and other non-Java languages on the JVM is rapidly growing. If somebody has an isolated little bit of Scala in their application, even if it has nothing to do with any injectable beans, Weld currently fails completely. I would argue that this is a serious flaw in Weld, even if it's being triggered by a serious flaw in these other languages' compilers.</p>
<p>This is doubly true given that, other than Weld, I haven't come across any other tool that has this problem. I can deploy my application fine in TomEE. The rest of JBoss's detection works fine, including Servlets & EJB 3.1. Given that this issue has a pretty big impact and quite a lot of people use Scala these days, it seems that it would be worthwhile for Weld to be robust against this particular issue—even if it shouldn't have to be in an ideal world. </p>
<p>If you look at the code for Java's <tt>getSimpleName</tt>, it's clear that there is absolutely no danger in catching this error. It seems perfectly reasonable to me to catch this particular <tt>Error</tt> with this exact message <tt>"Malformed class name"</tt> and log a warning, treating the class as anonymous. There <b>are</b> some limited cases where catching an <tt>Error</tt> is both appropriate and safe. <img class="emoticon" src="https://issues.jboss.org/images/icons/emoticons/smile.gif" height="20" width="20" align="absmiddle" alt="" border="0"/></p>
<p>I haven't read the Weld code yet, but I imagine that you want to exclude both anonymous and local classes. There's a simple and reliable test: </p>
<div class="code panel" style="border-width: 1px;"><div class="codeContent panelContent">
<pre class="code-java">clazz.getEnclosingMethodInfo() != <span class="code-keyword">null</span></pre>
</div></div>
<p>The JLS guarantees that this is true if and only if the class is either anonymous or local.</p>
<p>The Scala team has an open bug on this, but this is not a simple issue and impacts binary compatibility. It may not see a resolution soon, but Weld could seemingly mitigate the problem quite easily.</p></div>
<div style="color:#505050;padding:4px 0 0 0;"> </div>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#003366;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->