<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
#email-body { min-width: 30em !important; }
#email-page { padding: 8px !important; }
#email-banner { padding: 8px 8px 0 8px !important; }
#email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
#email-fields { padding: 0 8px 8px 8px !important; }
#email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
<tr valign="top">
<td id="email-page" style="padding:16px !important;">
<table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
<tr valign="top">
<td bgcolor="#3b4d64" style="background-color:#3b4d64;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://issues.jboss.org/s/en_USgzf77d-418945332/852/58/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
</tr><tr valign="top">
<td id="email-banner" style="padding:32px 32px 0 32px;">
<table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
<img id="email-avatar" src="https://community.jboss.org/people/pikachu/avatar/16.png" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
<div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
<a class="user-hover" rel="pikachu" id="email_pikachu" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=pikachu" style="color:#326ca6;">yi gong</a>
updated <img src="https://issues.jboss.org/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://issues.jboss.org/browse/WELD-1418'>WELD-1418</a>
</div>
<div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
<a style='color:#326ca6;text-decoration:none;' href='https://issues.jboss.org/browse/WELD-1418'><strong>NonexistentConversationException: WELD-000321 No conversation found to restore for id 1</strong></a>
</div>
</td>
</tr>
</table>
</td>
</tr>
<tr valign="top">
<td id="email-fields" style="padding:0 32px 32px 32px;">
<table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
<tr valign="top">
<td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
<td>
<table border="0" cellpadding="0" cellspacing="0" width="100%">
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Change By:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<a class="user-hover" rel="pikachu" id="email_pikachu" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=pikachu" style="color:#326ca6;">yi gong</a>
(27/Apr/13 12:22 PM)
</td>
</tr>
<tr valign="top">
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
<strong style="font-weight:normal;color:#505050;">Description:</strong>
</td>
<td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
<span class="diffcontext">There's a race condition in AbstractConversationContext when create first conversation scope if it's the first request of one session.<br>Suppose such scenario<br># User</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> request</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> requests</span>
<span class="diffcontext"> a jsf page<br># weld</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> create</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> creates</span>
<span class="diffcontext"> a conversations map in the AbstractConversationContext.associate()<br># Because it is the first request, there's no session. Weld keep this map in request<br>#</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> Then</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> In</span>
<span class="diffcontext"> somewhere, a session is created<br># In the render phase, server sends</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> piratical</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> partial</span>
<span class="diffcontext"> response back. The page need some jsf resource, eg, jsf2 ajax or</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> jsf</span>
<span class="diffcontext"> resource<br># Browser</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> request</span>
<span class="diffaddedchars" style="background-color:#ddfade;"> requests</span>
<span class="diffcontext"> the new jsf resource<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">#</span>
<span class="diffcontext">At this time</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br></span>
<span class="diffcontext"> The first request has not finished. So it doesn't reach dissociate() and doesn't put conversations map in the session.<br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">#</span>
<span class="diffcontext">Meanwhile</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br></span>
<span class="diffcontext"> The second request reach associate(). There's no conversations map in the session, and the session is existing. It puts its new map! <====<br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"><br></span>
<span class="diffaddedchars" style="background-color:#ddfade;">#</span>
<span class="diffcontext">Then, even the first request finishes it's response and reach dissociate(), because there's already a map, it doesn't put its owner anymore. <====<br><br>A quick and dirty fix is always create session before associate(). However, it's better to merge the map in the dissociate()<br><br><br></span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">Such page reference a conversation scoped bean</span>
<span class="diffcontext"><br><br><br></span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td><!-- End #email-page -->
</tr>
<tr valign="top">
<td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
This message is automatically generated by JIRA.<br />
If you think it was sent incorrectly, please contact your JIRA administrators<br />
For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
</td>
</tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->