<style>
/* Changing the layout to use less space for mobiles */
@media screen and (max-device-width: 480px), screen and (-webkit-min-device-pixel-ratio: 2) {
    #email-body { min-width: 30em !important; }
    #email-page { padding: 8px !important; }
    #email-banner { padding: 8px 8px 0 8px !important; }
    #email-avatar { margin: 1px 8px 8px 0 !important; padding: 0 !important; }
    #email-fields { padding: 0 8px 8px 8px !important; }
    #email-gutter { width: 0 !important; }
}
</style>
<div id="email-body">
<table id="email-wrap" align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#f0f0f0;color:#000000;width:100%;">
    <tr valign="top">
        <td id="email-page" style="padding:16px !important;">
            <table align="center" border="0" cellpadding="0" cellspacing="0" style="background-color:#ffffff;border:1px solid #bbbbbb;color:#000000;width:100%;">
                <tr valign="top">
                    <td bgcolor="#3b4d64" style="background-color:#3b4d64;color:#ffffff;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;line-height:1;"><img src="https://issues.jboss.org/s/en_USd3nf01-418945332/852/58/_/jira-logo-scaled.png" alt="" style="vertical-align:top;" /></td>
                </tr><tr valign="top">
    <td id="email-banner" style="padding:32px 32px 0 32px;">

                
        
        
            <table align="left" border="0" cellpadding="0" cellspacing="0" width="100%" style="width:100%;">
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;padding:0;">
                                        <img id="email-avatar" src="https://community.jboss.org/people/luksa/avatar/16.png" alt="" height="48" width="48" border="0" align="left" style="padding:0;margin: 0 16px 16px 0;" />
                        <div id="email-action" style="padding: 0 0 8px 0;font-size:12px;line-height:18px;">
                                    <a class="user-hover" rel="luksa" id="email_luksa" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=luksa" style="color:#326ca6;">Marko Lukša</a>
     updated <img src="https://issues.jboss.org/images/icons/issuetypes/bug.png" height="16" width="16" border="0" align="absmiddle" alt="Bug"> <a style='color:#326ca6;text-decoration:none;' href='https://issues.jboss.org/browse/WELD-1467'>WELD-1467</a>
            </div>
                        <div id="email-summary" style="font-size:16px;line-height:20px;padding:2px 0 16px 0;">
                <a style='color:#326ca6;text-decoration:none;' href='https://issues.jboss.org/browse/WELD-1467'><strong>Weld 2.0 breaks request character encoding</strong></a>
            </div>
                    </td>
    </tr>
</table>
        
    </td>
</tr>
<tr valign="top">
    <td id="email-fields" style="padding:0 32px 32px 32px;">
        <table border="0" cellpadding="0" cellspacing="0" style="padding:0;text-align:left;width:100%;" width="100%">
            <tr valign="top">
                <td id="email-gutter" style="width:64px;white-space:nowrap;"></td>
                <td>
                    <table border="0" cellpadding="0" cellspacing="0" width="100%">
                                                    <tr valign="top">
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
            <strong style="font-weight:normal;color:#505050;">Change By:</strong>
        </td>
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                                <a class="user-hover" rel="luksa" id="email_luksa" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=luksa" style="color:#326ca6;">Marko Lukša</a>
                            (22/Jul/13 4:50 AM)
        </td>
    </tr>
            <tr valign="top">
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 10px 10px 0;white-space:nowrap;">
            <strong style="font-weight:normal;color:#505050;">Description:</strong>
        </td>
        <td style="color:#000000;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:12px;padding:0 0 10px 0;width:100%;">
                                    <span class="diffcontext">Since&nbsp;Weld&nbsp;2.0&nbsp;reads&nbsp;request&nbsp;parameters&nbsp;{{cid}}&nbsp;and&nbsp;{{conversationPropagation}}&nbsp;at&nbsp;the&nbsp;start&nbsp;of&nbsp;each&nbsp;request&nbsp;(it&nbsp;does&nbsp;this&nbsp;in&nbsp;a&nbsp;ServletListener),&nbsp;applications&nbsp;lose&nbsp;the&nbsp;ability&nbsp;to&nbsp;call&nbsp;{{request.setCharacterEncoding()}}</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">.<br><br>Setting</span>
<span class="diffaddedchars" style="background-color:#ddfade;">,&nbsp;since&nbsp;setting</span>
<span class="diffcontext">&nbsp;the&nbsp;character&nbsp;encoding&nbsp;has&nbsp;an&nbsp;effect&nbsp;only&nbsp;until&nbsp;the&nbsp;web&nbsp;container&nbsp;parses&nbsp;the&nbsp;query&nbsp;string&nbsp;(or&nbsp;POST&nbsp;request&nbsp;body).&nbsp;<br><br>Applications&nbsp;that&nbsp;do&nbsp;not&nbsp;use&nbsp;CDI&nbsp;have&nbsp;full&nbsp;control&nbsp;over&nbsp;this.&nbsp;It&nbsp;is&nbsp;their&nbsp;responsibility&nbsp;to&nbsp;make&nbsp;sure&nbsp;to&nbsp;call&nbsp;{{setCharacterEncoding()}}&nbsp;and&nbsp;only&nbsp;then&nbsp;read&nbsp;request&nbsp;parameters.&nbsp;But&nbsp;as&nbsp;soon&nbsp;as&nbsp;an&nbsp;application&nbsp;uses&nbsp;CDI/Weld2.0,&nbsp;the&nbsp;only&nbsp;way&nbsp;for&nbsp;an&nbsp;application&nbsp;to&nbsp;set&nbsp;the&nbsp;character&nbsp;encoding&nbsp;is&nbsp;to&nbsp;add&nbsp;a&nbsp;servlet&nbsp;filter&nbsp;that&nbsp;sets&nbsp;it,&nbsp;and&nbsp;also&nbsp;manually&nbsp;add&nbsp;Weld&#39;s&nbsp;ConversationFilter&nbsp;(to&nbsp;prevent&nbsp;WeldListener&nbsp;from&nbsp;reading&nbsp;the&nbsp;parameters</span>
<span class="diffaddedchars" style="background-color:#ddfade;">&nbsp;before&nbsp;any&nbsp;filter&nbsp;is&nbsp;called</span>
<span class="diffcontext">).<br><br>Ideally,&nbsp;Weld&nbsp;should&nbsp;not&nbsp;interfere&nbsp;with&nbsp;the&nbsp;application.&nbsp;This&nbsp;means&nbsp;Weld&nbsp;should&nbsp;not&nbsp;read&nbsp;the&nbsp;parameters&nbsp;until&nbsp;after&nbsp;the&nbsp;application&nbsp;has&nbsp;had&nbsp;a&nbsp;chance&nbsp;to&nbsp;set&nbsp;the&nbsp;encoding&nbsp;(actually,&nbsp;until&nbsp;after&nbsp;the&nbsp;application&nbsp;itself&nbsp;has&nbsp;caused&nbsp;the&nbsp;parameters/body&nbsp;to&nbsp;be&nbsp;parsed).&nbsp;This&nbsp;is&nbsp;not&nbsp;achievable,&nbsp;because&nbsp;the&nbsp;application&nbsp;can&nbsp;invoke&nbsp;a&nbsp;conversation&nbsp;scoped&nbsp;bean&nbsp;before&nbsp;it&nbsp;has&nbsp;read&nbsp;any&nbsp;parameters.&nbsp;So,&nbsp;the&nbsp;best&nbsp;we&nbsp;can&nbsp;possibly&nbsp;do&nbsp;is&nbsp;read&nbsp;the&nbsp;{{cid}}&nbsp;parameter&nbsp;only&nbsp;when&nbsp;we&nbsp;need&nbsp;to&nbsp;access&nbsp;the&nbsp;conversation.&nbsp;The&nbsp;application&nbsp;then&nbsp;needs&nbsp;to&nbsp;make&nbsp;sure&nbsp;it&nbsp;has&nbsp;set&nbsp;the&nbsp;encoding&nbsp;before&nbsp;that.<br><br>Another&nbsp;option&nbsp;would&nbsp;be&nbsp;for&nbsp;Weld&nbsp;to</span>
<span class="diffaddedchars" style="background-color:#ddfade;">&nbsp;do</span>
<span class="diffcontext">&nbsp;the&nbsp;parsing&nbsp;itself,&nbsp;but&nbsp;this&nbsp;would&nbsp;only&nbsp;help&nbsp;in&nbsp;situations&nbsp;where&nbsp;the&nbsp;{{cid}}&nbsp;is&nbsp;in&nbsp;the&nbsp;query&nbsp;string,&nbsp;not&nbsp;in&nbsp;the&nbsp;POST&nbsp;request&nbsp;body.&nbsp;If&nbsp;the&nbsp;CDI&nbsp;spec&nbsp;demanded&nbsp;the&nbsp;{{cid}}&nbsp;to&nbsp;always&nbsp;be&nbsp;in&nbsp;the&nbsp;query&nbsp;string,&nbsp;this&nbsp;would&nbsp;be&nbsp;the&nbsp;way&nbsp;to&nbsp;go</span>
<span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">.</span>
<span class="diffaddedchars" style="background-color:#ddfade;">,&nbsp;but&nbsp;currently&nbsp;the&nbsp;spec&nbsp;uses&nbsp;the&nbsp;term&nbsp;&quot;request&nbsp;parameter&quot;&nbsp;for&nbsp;both&nbsp;{{cid}}&nbsp;and&nbsp;{{conversationPropagation}}</span>
<span class="diffcontext"><br><br><br></span>

        </td>
    </tr>
                            </table>
                </td>
            </tr>
        </table>
    </td>
</tr>













            </table>
        </td><!-- End #email-page -->
    </tr>
    <tr valign="top">
        <td style="color:#505050;font-family:Arial,FreeSans,Helvetica,sans-serif;font-size:10px;line-height:14px;padding: 0 16px 16px 16px;text-align:center;">
            This message is automatically generated by JIRA.<br />
            If you think it was sent incorrectly, please contact your JIRA administrators<br />
            For more information on JIRA, see: <a style='color:#326ca6;' href='http://www.atlassian.com/software/jira'>http://www.atlassian.com/software/jira</a>
        </td>
    </tr>
</table><!-- End #email-wrap -->
</div><!-- End #email-body -->