<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://issues.jboss.org" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://community.jboss.org/gravatar/4517c516e47a37b2745ed5b12fdecaac?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="mjobanek" id="email_mjobanek" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=mjobanek" style="color:#3b73af;; color: #3b73af; text-decoration: none">Matous Jobanek</a> <strong>commented</strong> on <a href="https://issues.jboss.org/browse/WELD-1623" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-7fc37e5e-4673-4b3b-8680-08b1793e9c6f" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> WELD-1623</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-1623" style="color: #3b73af; text-decoration: none">Re: Cleanup of expired conversations should be synchronized</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">Hi, <br /> I've tested the patch and I found out, that there is another problem. When there are many conversation at once this exception is thrown: </p>
<div class="panel" style="border-width: 1px;; border: 1px solid #ccc; -moz-border-radius: 3px 3px 3px 3px; border-radius: 3px 3px 3px 3px; margin: 9px 0">
<div class="panelContent" style="padding: 9px 12px">
<p style="margin: 10px 0 0 0">15:29:11,610 ERROR [org.apache.catalina.core.ContainerBase.<span class="error">[jboss.web]</span>.<span class="error">[default-host]</span>.<span class="error">[/test-red-hat-web]</span>.<span class="error">[Faces Servlet]</span>] (http-/127.0.0.1:8080-82) JBWEB000236: Servlet.service() for servlet Faces Servlet threw exception: java.util.ConcurrentModificationException<br /> at java.util.HashMap$HashIterator.nextEntry(HashMap.java:926) <span class="error">[rt.jar:1.7.0_45]</span><br /> at java.util.HashMap$ValueIterator.next(HashMap.java:954) <span class="error">[rt.jar:1.7.0_45]</span><br /> at org.jboss.weld.context.AbstractConversationContext.invalidate(AbstractConversationContext.java:291) <span class="error">[weld-core-1.1.24.Final-redhat-1.jar:2014-08-07 14:55]</span><br /> at org.jboss.weld.jsf.WeldPhaseListener.deactivateConversations(WeldPhaseListener.java:146) <span class="error">[weld-core-1.1.24.Final-redhat-1.jar:2014-08-07 14:55]</span><br /> at org.jboss.weld.jsf.WeldPhaseListener.afterPhase(WeldPhaseListener.java:91) <span class="error">[weld-core-1.1.24.Final-redhat-1.jar:2014-08-07 14:55]</span><br /> at com.sun.faces.lifecycle.Phase.handleAfterPhase(Phase.java:189) <span class="error">[jsf-impl-2.1.28-jbossorg-3.jar:]</span><br /> at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:107) <span class="error">[jsf-impl-2.1.28-jbossorg-3.jar:]</span><br /> at com.sun.faces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:139) <span class="error">[jsf-impl-2.1.28-jbossorg-3.jar:]</span><br /> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:594) <span class="error">[jboss-jsf-api_2.1_spec-2.1.28.Final-redhat-1.jar:2.1.28.Final-redhat-1]</span><br /> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:295) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.omnifaces.filter.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:115) <span class="error">[omnifaces-1.5.jar:1.5]</span><br /> at org.omnifaces.filter.HttpFilter.doFilter(HttpFilter.java:75) <span class="error">[omnifaces-1.5.jar:1.5]</span><br /> at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:246) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:214) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:231) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:149) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.jboss.as.web.session.ClusteredSessionValve.handleRequest(ClusteredSessionValve.java:134) <span class="error">[jboss-as-web-7.4.0.Final-redhat-19.jar:7.4.0.Final-redhat-19]</span><br /> at org.jboss.as.web.session.ClusteredSessionValve.invoke(ClusteredSessionValve.java:99) <span class="error">[jboss-as-web-7.4.0.Final-redhat-19.jar:7.4.0.Final-redhat-19]</span><br /> at org.jboss.as.web.session.JvmRouteValve.invoke(JvmRouteValve.java:92) <span class="error">[jboss-as-web-7.4.0.Final-redhat-19.jar:7.4.0.Final-redhat-19]</span><br /> at org.jboss.as.web.session.LockingValve.invoke(LockingValve.java:64) <span class="error">[jboss-as-web-7.4.0.Final-redhat-19.jar:7.4.0.Final-redhat-19]</span><br /> at org.jboss.as.web.security.SecurityContextAssociationValve.invoke(SecurityContextAssociationValve.java:169) <span class="error">[jboss-as-web-7.4.0.Final-redhat-19.jar:7.4.0.Final-redhat-19]</span><br /> at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:145) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:97) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:102) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:344) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:856) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:653) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:926) <span class="error">[jbossweb-7.4.8.Final-redhat-4.jar:7.4.8.Final-redhat-4]</span><br /> at java.lang.Thread.run(Thread.java:744) <span class="error">[rt.jar:1.7.0_45]</span></p>
</div>
</div>
<p style="margin: 10px 0 0 0">It is because Weld iterates over a collection of ManagedConversation without any synchronization. This should be synchronized even if it is synchronized map:<br /> <a href="http://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#synchronizedMap%28java.util.Map%29" class="external-link" rel="nofollow" style="color: #3b73af; text-decoration: none">http://docs.oracle.com/javase/7/docs/api/java/util/Collections.html#synchronizedMap%28java.util.Map%29</a></p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-1623#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-2cdcd98b-428b-4649-9928-48e614f661c7" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/WELD-1623#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.2.6#6264-<span title="ee7642271310c09537d01e5848a003c4498a0eed" data-commit-id="ee7642271310c09537d01e5848a003c4498a0eed}">sha1:ee76422</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-ea6ecdd8-4b06-4565-9b72-5be0d84a99cf" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>