<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://issues.jboss.org" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/f2174ca26fe64a3ee115a510de06830d?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="kobogianhitis" id="email_kobogianhitis" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=kobogianhitis" style="color:#3b73af;; color: #3b73af; text-decoration: none">kobogian hitis</a> <strong>commented</strong> on <a href="https://issues.jboss.org/browse/WELD-2133" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-06e7bdcb-317d-4f14-8b65-bba1f5af0421" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> WELD-2133</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2133" style="color: #3b73af; text-decoration: none">Re: ClassHierarchyComparator implementation seems wrong</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0">
<p style="margin: 10px 0 0 0">An implementation of the class comparator that seems to work is:</p>
<p style="margin: 10px 0 0 0">class ClassHierarchyComparator implements Comparator<Class<?>> {<br /> @Override<br /> public int compare(Class<?> c1, Class<?> c2) {<br /> if (c1.equals(c2)) </p> { return 0; }
<p style="margin: 10px 0 0 0"> else if (Object.class.equals(c1) || Object.class.equals(c2)) </p> { return c1.isAssignableFrom(c2) ? 1 : -1; }
<p style="margin: 10px 0 0 0"> else if (c1.isAssignableFrom(c2)) </p> { return 1; }
<p style="margin: 10px 0 0 0"> else if (c2.isAssignableFrom(c1)) </p> { return -1; }
<p style="margin: 10px 0 0 0"> else </p> { return compare(c1.getSuperclass(), c2.getSuperclass()); }
<p style="margin: 10px 0 0 0"> }<br /> }</p>
<p style="margin: 10px 0 0 0">But works only for classes. However from what you have described the specific comparator is used to sort Interfaces, (should be called InterfaceHierarchyComparator). <br /> IMHO this task is more complex due to the following facts:</p>
<ul class="alternate" type="square">
<li>
interfaces can extend multiple interfaces
</li>
<li>
an interface can extend the same subset of interfaces with some of its superinterface(s).
</li>
</ul>
<p style="margin: 10px 0 0 0">This means that the interfaces hierarchy is not a tree, but a graph (with no circular references).</p>
<p style="margin: 10px 0 0 0">I've created an implementation that seems to work fine for interfaces, but I'm not sure whether it is efficient.</p>
<p style="margin: 10px 0 0 0">class InterfaceHierarchyComparator implements Comparator<Class<?>> {<br /> /<b>Interface whose class is used in recursion to mark the parent of an interface that does not extend any other interface</b>/<br /> private static interface RootInterface{}</p>
<p style="margin: 10px 0 0 0"> @Override<br /> public int compare(Class<?> c1, Class<?> c2) {<br /> int retVal;<br /> if (c1.equals(c2)) </p> { retVal = 0; }
<p style="margin: 10px 0 0 0"> else if (c1.equals(RootInterface.class)) </p> { retVal = 1; } else if (c2.equals(RootInterface.class)) { retVal = -1; } else if (c1.isAssignableFrom(c2)) { retVal = 1; }
<p style="margin: 10px 0 0 0"> else if (c2.isAssignableFrom(c1)) </p> { retVal = -1; }
<p style="margin: 10px 0 0 0"> else </p> { /*in this case we will compare the most deep the most deep from the parents of from each of the two interfaces.*/ List<Class<?>> c1Interfaces = Arrays.asList(c1.getInterfaces()); List<Class<?>> c2Interfaces = Arrays.asList(c2.getInterfaces()); Collections.sort(c1Interfaces, new InterfaceHierarchyComparator()); Collections.sort(c2Interfaces, new InterfaceHierarchyComparator()); Class<?> c1ParentInterfaceToCompare = c1Interfaces.isEmpty() ? RootInterface.class : c1Interfaces.get(0); Class<?> c2ParentInterfaceToCompare = c2Interfaces.isEmpty() ? RootInterface.class : c2Interfaces.get(0); retVal = compare(c1ParentInterfaceToCompare, c2ParentInterfaceToCompare); }
<p style="margin: 10px 0 0 0"> return retVal;<br /> }<br /> }</p>
<p style="margin: 10px 0 0 0">//Examples used:<br /> interface IfaceL {}<br /> interface IfaceK extends IfaceL{}<br /> interface IfaceA1 {}<br /> interface IfaceA2 {}<br /> interface IfaceB extends IfaceA1, IfaceA2 {}<br /> interface IfaceC extends IfaceB, IfaceA1 {}<br /> interface IfaceD extends IfaceK, IfaceA1, IfaceC {}<br /> interface IfaceE extends IfaceC, IfaceA1, IfaceA2 ,IfaceD , IfaceK{}</p>
<p style="margin: 10px 0 0 0"> List list = new ArrayList();<br /> list.add(IfaceA1.class);<br /> list.add(IfaceL.class);<br /> list.add(IfaceK.class);<br /> list.add(IfaceC.class);<br /> list.add(IfaceE.class);<br /> list.add(IfaceB.class);<br /> list.add(IfaceA2.class);<br /> list.add(IfaceD.class);<br /> Collections.shuffle(list, new Random(System.currentTimeMillis()));<br /> Collections.sort(list, new InterfaceHierarchyComparator());<br /> System.out.println(list);</p>
<p style="margin: 10px 0 0 0">Result:<br /> IfaceE,IfaceD,IfaceC,IfaceB,IfaceK,IfaceA1,IfaceA2,IfaceL</p>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2133#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-f5ce704c-1981-493b-ad27-05bcc1da9a4c" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/WELD-2133#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.4.11#64026-<span title="78f6ec473a3f058bd5d6c30e9319c7ab376bdb9c" data-commit-id="78f6ec473a3f058bd5d6c30e9319c7ab376bdb9c}">sha1:78f6ec4</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-14b21d12-d9e0-498d-886e-63f02d697027" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>