<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0" /> <base href="https://issues.jboss.org" />
<title>Message Title</title>
</head>
<body class="jira" style="color: #333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<!-- header here -->
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/ae9fa963f3481692bd397ec1a85aa770?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top" />
</td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="puntogil" id="email_puntogil" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=puntogil" style="color:#3b73af;; color: #3b73af; text-decoration: none">gil cattaneo</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/WELD-2177" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-static-bug-056a824a-e8d3-4c9c-bd31-864c4c75cb8d" height="16" width="16" border="0" align="absmiddle" alt="Bug" /> WELD-2177</a>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 15px; background-color: #fff; border-left: 1px solid #ccc; border-top: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly">
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2177" style="color: #3b73af; text-decoration: none">Re: Build problems</a> </span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff; border-bottom: none; padding-bottom: 0">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">hi<br />we use jboss-logging-tools 2.0.1.Final for Wildfly 10+ upgrading. <br /><br />i used:<br />openjdk version "1.8.0_91"<br />OpenJDK Runtime Environment (build 1.8.0_91-b14)<br />OpenJDK Server VM (build 25.91-b14, mixed mode)<br />Apache Maven 3.3.3<br />javax.enterprise:cdi-api:jar:1.2<br />javax.inject:javax.inject:jar:1<br />org.jboss.weld:weld-api:jar:2.3.Final<br />org.jboss.weld:weld-spi:jar:2.3.Final<br />org.jboss.classfilewriter:jboss-classfilewriter:jar:1.1.2.Final<br />org.jboss.spec.javax.ejb:jboss-ejb-api_3.2_spec:jar:1.0.0.Final<br />org.jboss.spec.javax.servlet:jboss-servlet-api_3.1_spec:jar:1.0.0.Final<br />org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec:jar:1.0.0.Final<br />org.jboss.spec.javax.annotation:jboss-annotations-api_1.2_spec:jar:1.0.0.Final<br />org.hibernate.javax.persistence:hibernate-jpa-2.1-api:jar:1.0.0.Final<br />com.google.guava:guava:jar:18.0<br />org.jboss.spec.javax.el:jboss-el-api_3.0_spec:jar:1.0.5.Final<br />org.jboss.spec.javax.interceptor:jboss-interceptors-api_1.2_spec:jar:1.0.0.Final<br />org.jboss.logging:jboss-logging-processor:jar:2.0.1.Final<br />org.jboss.logging:jboss-logging-annotations:jar:2.0.1.Final<br />org.jboss.jdeparser:jdeparser:jar:2.0.0.Final<br />org.jboss.logging:jboss-logging:jar:3.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">2</span> <span class="diffaddedchars" style="background-color:#ddfade;">3</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;">1</span> <span class="diffaddedchars" style="background-color:#ddfade;">0</span> <span class="diffcontext">.Final<br />net.sourceforge.findbugs:annotations:jar:1.3.2<br /><br />I applied these patch:<br /><br />--- a/environments/common/src/main/java/org/jboss/weld/environment/logging/WeldEnvironmentLogger.java<br />+++ b/environments/common/src/main/java/org/jboss/weld/environment/logging/WeldEnvironmentLogger.java<br />@@ -1,17 +1,20 @@<br /> package org.jboss.weld.environment.logging;<br /> <br />+import static org.jboss.weld.environment.logging.WeldEnvironmentLogger.WELD_ENV_PROJECT_CODE;<br /> <br /> import org.jboss.logging.BasicLogger;<br /> import org.jboss.logging.Logger.Level;<br /> import org.jboss.logging.annotations.Cause;<br /> import org.jboss.logging.annotations.LogMessage;<br /> import org.jboss.logging.annotations.Message;<br />+import org.jboss.logging.annotations.MessageLogger;<br /> <br /> /**<br /> *<br /> * @author Matej Briškár<br /> * @author Martin Kouba<br /> */<br />+@MessageLogger(projectCode = WELD_ENV_PROJECT_CODE)<br /> public interface WeldEnvironmentLogger extends BasicLogger {<br /> <br /> String CATCHING_MARKER = "Catching";<br />diff --git a/impl/src/main/java/org/jboss/weld/logging/WeldLogger.java b/impl/src/main/java/org/jboss/weld/logging/WeldLogger.java<br />index 184d3d7..f4a0778 100644<br />--- a/impl/src/main/java/org/jboss/weld/logging/WeldLogger.java<br />+++ b/impl/src/main/java/org/jboss/weld/logging/WeldLogger.java<br />@@ -16,17 +16,21 @@<br /> */<br /> package org.jboss.weld.logging;<br /> <br />+import static org.jboss.weld.logging.WeldLogger.WELD_PROJECT_CODE;<br />+<br /> import org.jboss.logging.BasicLogger;<br /> import org.jboss.logging.Logger.Level;<br /> import org.jboss.logging.annotations.Cause;<br /> import org.jboss.logging.annotations.LogMessage;<br /> import org.jboss.logging.annotations.Message;<br />+import org.jboss.logging.annotations.MessageLogger;<br /> <br /> /**<br /> * A source of localized log/bundle messages and exceptions. Note that this interface extends {@link BasicLogger} so that regular logger methods are available.<br /> *<br /> * @author Martin Kouba<br /> */<br />+@MessageLogger(projectCode = WELD_PROJECT_CODE)<br /> public interface WeldLogger extends BasicLogger {<br /> <br /> String CATCHING_MARKER = "Catching";<br />-- <br /><br />we don't have (use) Jetty 6 in Fedora<br /><br />--- core-2.3.2.Final/environments/servlet/core/src/main/java/org/jboss/weld/environment/servlet/WeldServletLifecycle.java 2015-12-08 16:06:29.000000000 +0100<br />+++ core-2.3.2.Final.gwtdev/environments/servlet/core/src/main/java/org/jboss/weld/environment/servlet/WeldServletLifecycle.java 2016-06-07 21:18:05.466473052 +0200<br />@@ -56,7 +56,6 @@<br /> import org.jboss.weld.environment.deployment.discovery.DiscoveryStrategy;<br /> import org.jboss.weld.environment.deployment.discovery.DiscoveryStrategyFactory;<br /> import org.jboss.weld.environment.deployment.discovery.jandex.Jandex;<br />-import org.jboss.weld.environment.gwtdev.GwtDevHostedModeContainer;<br /> import org.jboss.weld.environment.jetty.JettyContainer;<br /> import org.jboss.weld.environment.logging.CommonLogger;<br /> import org.jboss.weld.environment.servlet.deployment.ServletContextBeanArchiveHandler;<br />@@ -362,7 +361,7 @@<br /> container = checkContainers(ctx, dump, extContainers);<br /> if (container == null) {<br /> // 3. Built-in containers in predefined order<br />- container = checkContainers(ctx, dump, Arrays.asList(TomcatContainer.INSTANCE, JettyContainer.INSTANCE, UndertowContainer.INSTANCE, GwtDevHostedModeContainer.INSTANCE));<br />+ container = checkContainers(ctx, dump, Arrays.asList(TomcatContainer.INSTANCE, JettyContainer.INSTANCE, UndertowContainer.INSTANCE));<br /> }<br /> }<br /> return container;<br /><br /></span>
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #ccc; border-right: 1px solid #ccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #fff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2177#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-31ab8ae9-0750-43a2-93f8-94ed70720fbe" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle" /> </a>
</td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/WELD-2177#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a>
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #fff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #fff; border-top: 0; border-left: 1px solid #ccc; border-bottom: 1px solid #ccc; border-right: 1px solid #ccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly">
</td>
</tr>
</table>
</td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px">
This message was sent by Atlassian JIRA <span id="footer-build-information">(v6.4.11#64026-<span title="78f6ec473a3f058bd5d6c30e9319c7ab376bdb9c" data-commit-id="78f6ec473a3f058bd5d6c30e9319c7ab376bdb9c}">sha1:78f6ec4</span>)</span>
</td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-80a8c401-8c53-40ea-907d-fe6dba8673c6" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix" />
</td>
</tr>
</table>
</td>
</tr>
</table>
</td>
</tr>
</table>
</body>
</html>