<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/98d0697142b0d75568acf12b2767b01c?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="antoinesabot-durand" id="email_antoinesabot-durand" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=antoinesabot-durand" style="color:#3b73af;; color: #3b73af; text-decoration: none">Antoine Sabot-Durand</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/WELD-2416" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-a2b3c6ff-379f-41d6-8f1c-f26dd1dcdc8d" height="16" width="16" border="0" align="absmiddle" alt="Bug"> WELD-2416</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2416" style="color: #3b73af; text-decoration: none">Re: Memory behaviour of of javax.enterprise.inject.Instance<?>.iterator().next vs. of javax.enterprise.inject.Instance<?>.get() in Weld 1.1.18 vs. Weld 2.3.5</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">Nowhere in the CDI spec it is said that bean instances retrieved from {{Instance.get()}} and from iterating with {{Instance.iterator()}} should be treated differently regarding their destruction. In other words, it's normal that {{Instance.get()}} and {{Instance.iterator().next()}} behave the same. So your trick is exploiting a bug in Weld 1.1<br><br>Weld 2.3 is behaving correctly according to CDI 1.2 spec. You're using {{Instance}} to request instances for dependent beans. [Section 6.4.2 of the spec|http://docs.jboss.org/cdi/spec/1.2/cdi-spec.html#dependent_destruction] reads:<br><br>{quote}Dependent objects of a contextual instance are destroyed when {{Contextual.destroy()}} calls {{CreationalContext.release()}}, as defined in The {{CreationalContext}} interface.<br><br>Additionally, the container must ensure that:<br><br>* all dependent objects of a non-contextual instance of a bean or other Java EE component class are destroyed when the instance is destroyed by the container,{quote}<br><br>We are in this case. The CDI container doesn't guarantee that all instances will be destroyed with the destruction of injecting servlet. So don't expect it to happen during your servlet life. You have to use {{Instance.destroy()}} method to explicitly cleanup your dependent instances.<br><br>Now, why don't you experience memory leak when {{CDIBean2}} is injected directly and not thru {{Instance<CDIBean2>}}?<br><br>Probably because Weld use an optimisation allowed by the spec (end of section 6.4.2):<br><br>bq. Finally, the container is permitted to destroy any {{@Dependent}} scoped contextual instance at any time if the instance is no longer referenced by the application (excluding weak, soft and phantom references).<br><br>But as you see it's not guarantee: Weld is doing you a favour here.<br><br>So to comply CDI code, your example should be</span> <span class="diffremovedchars" style="background-color:#ffe7e7;text-decoration:line-through;"> ;edified</span> <span class="diffaddedchars" style="background-color:#ddfade;"> modified</span> <span class="diffcontext"> like this:<br><br>{code:java}<br>@WebServlet("/Servlet")<br>public class Servlet extends HttpServlet {<br> private static final long serialVersionUID = 1L;<br><br> @Inject<br> private Instance<CDIInterface> cdi;<br> /**<br> * @see HttpServlet#service(HttpServletRequest request, HttpServletResponse response)<br> */<br> protected void service(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException {<br> CDIInterface myInterface = cdi.get();<br> response.getWriter().write("Here " + Servlet.class.getName() + " - " + myInterface.sayHello());<br> cdi.destroy(myInterface);<br> }<br><br>}<br><br>public interface CDIInterface {<br><br> public abstract String sayHello();<br>}<br><br>@Default<br>public class CDIBean implements CDIInterface{<br><br> @Inject<br> private Instance<CDIBean2> bean2;<br> <br> public String sayHello() {<br> CDIBean2 myBean2 = bean2.get();<br> return "Here " + CDIBean.class.getName() + " - " + myBean2.get().testHello();<br> bean2.destroy(myBean2);<br> }<br><br>}<br><br>public class CDIBean2 {<br><br> public String testHello() {<br> return "Here " + CDIBean2.class.getName();<br> }<br>}<br>{code}<br><br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0px; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2416#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-a2878804-ac4d-4893-bc99-564ccf71a75e" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/WELD-2416#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.2.3#72005-<span title="73be91d2b96fc29303a7eb6820acf420e5d0ed65" data-commit-id="73be91d2b96fc29303a7eb6820acf420e5d0ed65}">sha1:73be91d</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-43e3528e-97dd-4148-80df-f84d6a14035b" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>