<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/46deeb7ca7f4f95b5d42307b992c85f2?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="steappe" id="email_steappe" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=steappe" style="color:#3b73af;; color: #3b73af; text-decoration: none">Stéphane Appercel</a> <strong>edited a comment</strong> on <a href="https://issues.jboss.org/browse/WELD-2443" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-26c620bd-8ec1-4ee7-9e05-62fa39d4c666" height="16" width="16" border="0" align="absmiddle" alt="Bug"> WELD-2443</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2443" style="color: #3b73af; text-decoration: none">Re: Weld fails to invoke an observer method with a private access</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="text-paragraph-pattern-top" class="email-content-main mobile-expand comment-top-special-margin comment-top-pattern" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; border-bottom: none; padding-bottom: 0" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0; padding-top: 10px"> <span class="diffcontext">I don't see much difference with the reproducer you made.<br><br>I've debugged the invocation of the private observer method and the exception is thrown when the proxy method created by WELD tries to invoke my private method:<br><br>{code:java}<br>private void steappe.preparation.infra.PreparationPresentationCache$Proxy$_$$_WeldSubclass.onUpdate(steappe.preparation.event.PreparationAreaPopulated) <br>{code}<br><br>invokes:<br><br>{code:java}<br>private void steappe.preparation.infra.PreparationPresentationCache.onUpdate(steappe.preparation.event.PreparationAreaPopulated)<br>{code}<br><br>The invocation is made on the method returned by the following code in WELD (class VirtualMethodInjectionPoint)<br><br>{code:java}<br> @Override<br> protected Method getMethod(Object receiver) throws NoSuchMethodException {<br> final Map<Class<?>, Method> methods = this.methods;<br> Method method = this.methods.get(receiver.getClass());<br> if (method == null) {<br> // the same method may be written to the map twice, but that is ok<br> // lookupMethod is very slow<br> Method delegate = getAnnotated().getJavaMember();<br> if ((hasDecorators() || MethodInjectionPointType.INITIALIZER.equals(type)) && (isPrivate(delegate) || isPackagePrivate(delegate.getModifiers())<br> && !Objects.equals(delegate.getDeclaringClass().getPackage(), receiver.getClass().getPackage()))) {<br> // Initializer methods and decorated beans - overriding does not apply to private methods and package-private methods where the subclass is in a different package<br> method = accessibleMethod;<br> } else {<br> method = SecurityActions.lookupMethod(receiver.getClass(), delegate.getName(), delegate.getParameterTypes());<br> SecurityActions.ensureAccessible(method);<br> }<br> final Map<Class<?>, Method> newMethods = ImmutableMap.<Class<?>, Method>builder().putAll(methods).put(receiver.getClass(), method).build();<br> this.methods = newMethods;<br> }<br> return method;<br> }<br><br>{code}<br><br>In the code above, the else statement is executed:<br><br><br>{code:java}<br> method = SecurityActions.lookupMethod(receiver.getClass(), delegate.getName(), delegate.getParameterTypes());<br> SecurityActions.ensureAccessible(method);<br>{code}<br><br>During the execution of ensureAccessible:<br><br>{code:java}<br> static void ensureAccessible(AccessibleObject accessibleObject) {<br> if (accessibleObject != null) {<br> if (!accessibleObject.isAccessible()) {<br> if (System.getSecurityManager() != null) {<br> AccessController.doPrivileged(SetAccessibleAction.of(accessibleObject));<br> } else {<br> accessibleObject.setAccessible(true);<br> }<br> }<br> }<br> }<br>{code}<br>The else statement is executed.<br><br>Then the returned WELD proxy method is invoked by the NativeMethodAccessorImpl class:<br><br>{code:java}<br> public Object invoke(Object obj, Object[] args)<br> throws IllegalArgumentException, InvocationTargetException<br> {<br> // We can't inflate methods belonging to vm-anonymous classes because<br> // that kind of class can't be referred to by name, hence can't be<br> // found from the generated bytecode.<br> if (++numInvocations > ReflectionFactory.inflationThreshold()<br> && !ReflectUtil.isVMAnonymousClass(method.getDeclaringClass())) {<br> MethodAccessorImpl acc = (MethodAccessorImpl)<br> new MethodAccessorGenerator().<br> generateMethod(method.getDeclaringClass(),<br> method.getName(),<br> method.getParameterTypes(),<br> method.getReturnType(),<br> method.getExceptionTypes(),<br> method.getModifiers());<br> parent.setDelegate(acc);<br> }<br><br> return invoke0(method, obj, args);<br> }<br>{code}<br><br>During the execution of invoke0 the illegal access exception is raised, apparently because the proxy generated class cannot access my private method, despite the call to setAccessible(true). This is weird.<br><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">There is a noticeable difference with the observer method that is successfully invoked. The observer method of my class is directly invoked, i.e. not through a WELD proxy. So the problem occurs when a WELD proxy invokes a private observer method.<br><br>However I don't know why one observer method is invoked directly while the other observer method is invoked through a proxy.<br><br><br><br></span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2443#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-4ebc99f2-1e44-4b7a-a4c1-be5d0994e1b9" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/WELD-2443#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.5.0#75005-<span title="fd8c849d4e278dd8bbaccc61e707a716ad697024" data-commit-id="fd8c849d4e278dd8bbaccc61e707a716ad697024}">sha1:fd8c849</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-3820d7a9-2928-46b0-b52a-7f3b88d5d8bd" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>