<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0">
<base href="https://issues.jboss.org">
<title>Message Title</title>
</head>
<body class="jira" style="color: #333333; font-family: Arial, sans-serif; font-size: 14px; line-height: 1.429">
<table id="background-table" cellpadding="0" cellspacing="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; background-color: #f5f5f5; border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt" bgcolor="#f5f5f5">
<!-- header here -->
<tbody>
<tr>
<td id="header-pattern-container" style="padding: 0px; border-collapse: collapse; padding: 10px 20px">
<table id="header-pattern" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="header-avatar-image-container" valign="top" style="padding: 0px; border-collapse: collapse; vertical-align: top; width: 32px; padding-right: 8px" width="32"> <img id="header-avatar-image" class="image_fix" src="https://static.jboss.org/developer/gravatar/645210977b379b537aae4a2d7e9103b7?d=mm&s=48" height="32" width="32" border="0" style="border-radius: 3px; vertical-align: top"> </td>
<td id="header-text-container" valign="middle" style="padding: 0px; border-collapse: collapse; vertical-align: middle; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px"> <a class="user-hover" rel="manovotn" id="email_manovotn" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=manovotn" style="color:#3b73af;; color: #3b73af; text-decoration: none">Matej Novotny</a> <strong>updated</strong> an issue </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="email-content-container" style="padding: 0px; border-collapse: collapse; padding: 0 20px">
<table id="email-content-table" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; border-spacing: 0; border-collapse: separate">
<tbody>
<tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<td class="email-content-rounded-top mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 15px; background-color: #ffffff; border-left: 1px solid #cccccc; border-top: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom: 0; border-top-right-radius: 5px; border-top-left-radius: 5px; height: 10px; line-height: 10px; padding: 0 15px 0 16px; mso-line-height-rule: exactly" height="10" bgcolor="#ffffff"> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table class="page-title-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="page-title-pattern-first-line " style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; padding-top: 10px"> <a href="https://issues.jboss.org/browse/WELD" style="color: #3b73af; text-decoration: none">Weld</a> / <a href="https://issues.jboss.org/browse/WELD-2460" style="color: #3b73af; text-decoration: none"><img src="cid:jira-generated-image-avatar-0dbb67db-5656-47d3-9e6e-0dcbd55d8ee1" height="16" width="16" border="0" align="absmiddle" alt="Bug" style="vertical-align: text-bottom"></a> <a href="https://issues.jboss.org/browse/WELD-2460" style="color: #3b73af; text-decoration: none">WELD-2460</a> </td>
</tr>
<tr>
<td style="vertical-align: top;; padding: 0px; border-collapse: collapse; padding-right: 5px; font-size: 20px; line-height: 30px; mso-line-height-rule: exactly" class="page-title-pattern-header-container"> <span class="page-title-pattern-header" style="font-family: Arial, sans-serif; padding: 0; font-size: 20px; line-height: 30px; mso-text-raise: 2px; mso-line-height-rule: exactly; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2460" style="color: #3b73af; text-decoration: none">JDK 9 - reflection usage, multirelease jar, testing</a> </span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand wrapper-special-margin" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 10px; padding-bottom: 5px" bgcolor="#ffffff">
<table class="keyvalue-table" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<th style="color: #707070; font: normal 14px/20px Arial, sans-serif; text-align: left; vertical-align: top; padding: 2px 0">Change By:</th>
<td style="padding: 0px; border-collapse: collapse; font: normal 14px/20px Arial, sans-serif; padding: 2px 0 2px 5px; vertical-align: top"> <a class="user-hover" rel="manovotn" id="email_manovotn" href="https://issues.jboss.org/secure/ViewProfile.jspa?name=manovotn" style="color:#3b73af;; color: #3b73af; text-decoration: none">Matej Novotny</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand issue-description-container" style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff; padding-top: 5px; padding-bottom: 10px" bgcolor="#ffffff">
<table class="text-paragraph-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 2px">
<tbody>
<tr>
<td class="text-paragraph-pattern-container mobile-resize-text " style="padding: 0px; border-collapse: collapse; padding: 0 0 10px 0"> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">We need to inspect and rework our calls to JDK internal libs - with JDK 9 this</span> <span class="diffaddedchars" style="background-color:#ddfade;">Our main problem</span> <span class="diffcontext"> is</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> permitted but throws warnings in logs</span> <span class="diffaddedchars" style="background-color:#ddfade;"> {{ClassFileUtils}} which use CL to invoke {{defineClass()}}</span> <span class="diffcontext">. In</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> JDK 10</span> <span class="diffaddedchars" style="background-color:#ddfade;"> order to do</span> <span class="diffcontext"> this</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> is</span> <span class="diffaddedchars" style="background-color:#ddfade;">, you need</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> be forbidden and</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">Handles</span> <span class="diffaddedchars" style="background-color:#ddfade;">setAccessible()</span> <span class="diffcontext">}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> anr/or</span> <span class="diffaddedchars" style="background-color:#ddfade;"> those methods which is a no-go for JDK 9+.<br>There are two approaches that we can take:<br><br>1. Use</span> <span class="diffcontext"> {{Unsafe}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> needs</span> <span class="diffcontext"> to</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> be used. Once done,</span> <span class="diffaddedchars" style="background-color:#ddfade;"> crack open the CL's methods and keep the code as it is<br>* This is a "safe" way in that</span> <span class="diffcontext"> we</span> <span class="diffaddedchars" style="background-color:#ddfade;"> know all</span> <span class="diffcontext"> will</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> likely need to java a multirelease JARs</span> <span class="diffaddedchars" style="background-color:#ddfade;"> work</span> <span class="diffcontext"> as</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> the new solution won't</span> <span class="diffaddedchars" style="background-color:#ddfade;"> it did up to this point<br>* We cannot</span> <span class="diffcontext"> be</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> available</span> <span class="diffaddedchars" style="background-color:#ddfade;"> sure when/if/whether Oracle guys wake up one morning and say "Hey, we are removing those {{Unsafe}} methods!" (case of {{Unsafe.defineClass()}}</span> <span class="diffcontext"> in</span> <span class="diffaddedchars" style="background-color:#ddfade;"> EA</span> <span class="diffcontext"> JDK</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> 8.</span> <span class="diffaddedchars" style="background-color:#ddfade;"> 11)</span> <span class="diffcontext"><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">Note that it does not matter whether you</span> <span class="diffaddedchars" style="background-color:#ddfade;"><br>2. We can</span> <span class="diffcontext"> use</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> classpath or module path</span> <span class="diffaddedchars" style="background-color:#ddfade;"> {{MethodHandles</span> <span class="diffcontext">.</span> <span class="diffaddedchars" style="background-color:#ddfade;">Lookup}}, namely {{privateLookupIn()}} to define new classes</span> <span class="diffcontext"><br></span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"><br>One such case of our reflection usage</span> <span class="diffaddedchars" style="background-color:#ddfade;">* This</span> <span class="diffcontext"> is the</span> <span class="diffaddedchars" style="background-color:#ddfade;"> intended</span> <span class="diffcontext"> way</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> we create proxies by calling</span> <span class="diffaddedchars" style="background-color:#ddfade;">, but it has limitations:<br>**</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">ClassLoader</span> <span class="diffaddedchars" style="background-color:#ddfade;">Lookup</span> <span class="diffcontext">.defineClass()}}</span> <span class="diffaddedchars" style="background-color:#ddfade;"> has no way to specify {{ProtectionDomain}} which is something we currently do, we enrich it, so that newly added classes always have "getDeclaredFields</span> <span class="diffcontext"> (</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">protected method on CL</span> <span class="diffcontext">)</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> in</span> <span class="diffaddedchars" style="background-color:#ddfade;">" rights<br>** In WFLY, proxies built from JDK classes (</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">ClassFileUtils</span> <span class="diffaddedchars" style="background-color:#ddfade;">Map</span> <span class="diffcontext">}}</span> <span class="diffaddedchars" style="background-color:#ddfade;">,</span> <span class="diffcontext">.</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> This could instead be done via either</span> <span class="diffaddedchars" style="background-color:#ddfade;">..) use (top level) CL of the deployment's module<br>*** Hence on undeploy those proxies are tossed away (no leaks)<br>*** We cannot (easily) get such</span> <span class="diffcontext"> {{</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">Unsafe</span> <span class="diffaddedchars" style="background-color:#ddfade;">MethodHandle.Lookup</span> <span class="diffcontext">}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> or</span> <span class="diffaddedchars" style="background-color:#ddfade;"> from WFLY and if we define those classes on our CL, we have a memory leak<br>*** This also entails change to our API where WFLY hands us over _some_</span> <span class="diffcontext"> {{</span> <span class="diffaddedchars" style="background-color:#ddfade;">MethodHandles.</span> <span class="diffcontext">Lookup}}</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;">.</span> <span class="diffaddedchars" style="background-color:#ddfade;"> which we can work with</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">** In WFLY, static modules w/o Weld dependency use (top level) CL of the deployment's module</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">*** Same problem as above<br>* This approach implies the need for *multi-release JAR* of at least {{core-impl}} artifact<br>** Easy to do, nuisance to maintain and test (and bothersome with the current state of IDE support for those JDKs) <br><br><br></span> <span class="diffcontext">There might be some changes required in classfilewriter itself which is to be discovered (likely related to https://github.com/jbossas/jboss-classfilewriter/issues/14)<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">* Newest version uses {{Unsafe.defineClass()}} so we need to update to that one for the time being (1.2.2.Final)</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;"><br></span> <span class="diffcontext">Another part of this issue is to ensure we are continuously testing on JDK 9 (or 10, doesn't matter) as well as JDK 8.<br></span> <span class="diffaddedchars" style="background-color:#ddfade;">* Releases will be tested on JDK 8 + latest fully released JDK (9/10/11)</span> <span class="diffcontext"><br></span> <span class="diffaddedchars" style="background-color:#ddfade;">* All PRs will be tested on JDK 8 + latest fully released JDK (9/10/11)<br>** In the future with illegal access _denied_<br><br></span> <span class="diffcontext">Goal is to be able to execute all our tests with JDK 9</span> <span class="diffremovedchars" style="background-color: #ffe7e7; text-decoration:line-through;"> without any WARN messages related to</span> <span class="diffaddedchars" style="background-color:#ddfade;">+ with {{--</span> <span class="diffcontext"> illegal</span> <span class="diffaddedchars" style="background-color:#ddfade;">-</span> <span class="diffcontext"> access</span> <span class="diffaddedchars" style="background-color:#ddfade;">=deny}} switch</span> <span class="diffcontext">.</span> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td class="email-content-main mobile-expand " style="padding: 0px; border-collapse: collapse; border-left: 1px solid #cccccc; border-right: 1px solid #cccccc; border-top: 0; border-bottom: 0; padding: 0 15px 0 16px; background-color: #ffffff" bgcolor="#ffffff">
<table id="actions-pattern" cellspacing="0" cellpadding="0" border="0" width="100%" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 1px">
<tbody>
<tr>
<td id="actions-pattern-container" valign="middle" style="padding: 0px; border-collapse: collapse; padding: 10px 0 10px 24px; vertical-align: middle; padding-left: 0">
<table align="left" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td class="actions-pattern-action-icon-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 0; vertical-align: middle"> <a href="https://issues.jboss.org/browse/WELD-2460#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none"> <img class="actions-pattern-action-icon-image" src="cid:jira-generated-image-static-comment-icon-b45fa2c3-8564-4118-bfae-f24df9418d7a" alt="Add Comment" title="Add Comment" height="16" width="16" border="0" style="vertical-align: middle"> </a> </td>
<td class="actions-pattern-action-text-container" style="padding: 0px; border-collapse: collapse; font-family: Arial, sans-serif; font-size: 14px; line-height: 20px; mso-line-height-rule: exactly; mso-text-raise: 4px; padding-left: 5px"> <a href="https://issues.jboss.org/browse/WELD-2460#add-comment" target="_blank" title="Add Comment" style="color: #3b73af; text-decoration: none">Add Comment</a> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
<!-- there needs to be content in the cell for it to render in some clients -->
<tr>
<td class="email-content-rounded-bottom mobile-expand" style="padding: 0px; border-collapse: collapse; color: #ffffff; padding: 0 15px 0 16px; height: 5px; line-height: 5px; background-color: #ffffff; border-top: 0; border-left: 1px solid #cccccc; border-bottom: 1px solid #cccccc; border-right: 1px solid #cccccc; border-bottom-right-radius: 5px; border-bottom-left-radius: 5px; mso-line-height-rule: exactly" height="5" bgcolor="#ffffff"> </td>
</tr>
</tbody>
</table> </td>
</tr>
<tr>
<td id="footer-pattern" style="padding: 0px; border-collapse: collapse; padding: 12px 20px">
<table id="footer-pattern-container" cellspacing="0" cellpadding="0" border="0" style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-text" class="mobile-resize-text" width="100%" style="padding: 0px; border-collapse: collapse; color: #999999; font-size: 12px; line-height: 18px; font-family: Arial, sans-serif; mso-line-height-rule: exactly; mso-text-raise: 2px"> This message was sent by Atlassian JIRA <span id="footer-build-information">(v7.5.0#75005-<span title="fd8c849d4e278dd8bbaccc61e707a716ad697024" data-commit-id="fd8c849d4e278dd8bbaccc61e707a716ad697024}">sha1:fd8c849</span>)</span> </td>
<td id="footer-pattern-logo-desktop-container" valign="top" style="padding: 0px; border-collapse: collapse; padding-left: 20px; vertical-align: top">
<table style="border-collapse: collapse; mso-table-lspace: 0pt; mso-table-rspace: 0pt">
<tbody>
<tr>
<td id="footer-pattern-logo-desktop-padding" style="padding: 0px; border-collapse: collapse; padding-top: 3px"> <img id="footer-pattern-logo-desktop" src="cid:jira-generated-image-static-footer-desktop-logo-5e0ff065-5c04-427b-86ff-84c817232460" alt="Atlassian logo" title="Atlassian logo" width="169" height="36" class="image_fix"> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table> </td>
</tr>
</tbody>
</table>
</body>
</html>