[wildfly-dev] TODO Comments

Darran Lofthouse darran.lofthouse at jboss.com
Thu Jul 31 07:31:30 EDT 2014


On 30/07/14 21:19, Sebastian Łaskawiec wrote:
> I'm just thinking out laud - perhaps it would be better to add some
> rules to checkstyle plugin? This way all commits would have to obey this
> kind of coding standards.
>
> Of course there are some drawbacks... we'd need to fix all violations in
> existing code base. But this also may be considered as a something good :)

A quick search and I believe we have over 400 files in WildFly and 400 
in WildFly Core containing TODO comments.

> Best regards
> Sebastian
>
>
> 2014-07-30 22:03 GMT+02:00 Anil Saldhana <Anil.Saldhana at redhat.com
> <mailto:Anil.Saldhana at redhat.com>>:
>
>     Darran - very good suggestion.
>
>     Also, don't merge if there is no javadoc on public methods and
>     classes. :-)
>
>     On 07/30/2014 02:46 PM, Darran Lofthouse wrote:
>      > Just a random idea.
>      >
>      > Can we block merging pull requests if they contain a TODO comment
>     that
>      > don't reference a Jira issue?
>      >
>      > The views in GitHub are easy to see if a TODO is involved so quite
>      > simple to double check - and if no Jira is justified maybe the TODO
>      > isn't either.
>      >
>      > Regards,
>      > Darran Lofthouse.
>      > _______________________________________________
>      > wildfly-dev mailing list
>      > wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>      > https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>     _______________________________________________
>     wildfly-dev mailing list
>     wildfly-dev at lists.jboss.org <mailto:wildfly-dev at lists.jboss.org>
>     https://lists.jboss.org/mailman/listinfo/wildfly-dev
>
>
>
>
> --
> Sebastian Łaskawiec
>
>
> _______________________________________________
> wildfly-dev mailing list
> wildfly-dev at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/wildfly-dev
>


More information about the wildfly-dev mailing list