<div dir="ltr">I agree. I don't think mapping a datasource in jboss-web.xml is such an exotic use case. I should just work. Also, there is no hint anywere that there is a property you can set to make it work.<div><br></div>
<div>The proprietary jboss namespace is not an option since I want to be vendor neutral, but ear/java:app is definitely an option.</div><div><br></div><div><div class="gmail_extra">Br,<br>Martin Andersson<br>Java EE developer at <a href="http://www.purplescout.se">www.purplescout.se</a></div>
<div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jan 31, 2014 at 3:03 PM, Eduardo Martins <span dir="ltr"><<a href="mailto:emartins@redhat.com" target="_blank">emartins@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">IMHO this hint should not be needed, a PU referencing a java:comp or java:module datasource is already a hint that the PU will need a resource bound by another component bundled in same jar/war.<br>
<br>
By the way I’m not really a fan of using java:comp in a PU, it sets an dependency on a EE component, and that doesn’t seem right. Wouldn't be preferable to use the original java:jboss/datasources/ExampleDS JNDI name, or use an ear and define a java:app bind at application.xml, to be shared by all modules and components?<br>
<br>
—E<br>
<div><div class="h5"><br>
<br>
On 31 Jan 2014, at 13:13, Scott Marlow <<a href="mailto:smarlow@redhat.com">smarlow@redhat.com</a>> wrote:<br>
<br>
> Great, thanks for reporting the issue Martin! Great to bring more<br>
> awareness of the deployment problem and workaround.<br>
><br>
> Scott<br>
> On 01/31/2014 08:04 AM, Martin Andersson wrote:<br>
>> Thanks a lot!<br>
>><br>
>> I can confirm that the app works now.<br>
>><br>
>> Br,<br>
>> Martin Andersson<br>
>> Java EE developer at <a href="http://www.purplescout.se" target="_blank">www.purplescout.se</a> <<a href="http://www.purplescout.se" target="_blank">http://www.purplescout.se</a>><br>
>><br>
>><br>
>> On Fri, Jan 31, 2014 at 1:55 PM, Scott Marlow <<a href="mailto:smarlow@redhat.com">smarlow@redhat.com</a><br>
>> <mailto:<a href="mailto:smarlow@redhat.com">smarlow@redhat.com</a>>> wrote:<br>
>><br>
>> Hi Arjan,<br>
>><br>
>> Great catch! Your change and adding an persistence unit hint that the<br>
>> persistence unit doesn't need to be started early:<br>
>><br>
>> <property name="wildfly.jpa.twophasebootstrap" value="false"/><br>
>><br>
>> Helps the deployment succeed.<br>
>><br>
>> It looks like ResourceReferenceProcessor is running during the<br>
>> Phase.POST_MODULE deployment phase, so we need to add a hint to the<br>
>> persistence.xml, that helps the persistence unit deploy later.<br>
>><br>
>> [6]<br>
>> <a href="https://github.com/wildfly/wildfly/blob/master/ee/src/main/java/org/jboss/as/ee/subsystem/EeSubsystemAdd.java#L194" target="_blank">https://github.com/wildfly/wildfly/blob/master/ee/src/main/java/org/jboss/as/ee/subsystem/EeSubsystemAdd.java#L194</a><br>
>><br>
>> Scott<br>
>><br>
>> On 01/31/2014 06:25 AM, arjan tijms wrote:<br>
>>> Hi,<br>
>>><br>
>>> I looks like there's one bug in the example.<br>
>>><br>
>>> jboss-web.xml defines jdbc/MyDS<br>
>>><br>
>>> But persistence.xml references java:comp/env/MyDS<br>
>>><br>
>>> Shouldn't the last one be at least java:comp/env/jdbc/MyDS?<br>
>> Regardless,<br>
>>> even with matching names it indeed doesn't work.<br>
>>><br>
>>> Kind regards,<br>
>>> Arjan Tijms<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>><br>
>>> On Thu, Jan 30, 2014 at 9:52 PM, Scott Marlow <<a href="mailto:smarlow@redhat.com">smarlow@redhat.com</a><br>
>> <mailto:<a href="mailto:smarlow@redhat.com">smarlow@redhat.com</a>><br>
>>> <mailto:<a href="mailto:smarlow@redhat.com">smarlow@redhat.com</a> <mailto:<a href="mailto:smarlow@redhat.com">smarlow@redhat.com</a>>>> wrote:<br>
>>><br>
>>> WFLY-2841 reports a deployment failure that occurs when a<br>
>> deployments<br>
>>> [1] persistence.xml, tries to use a resource reference [2]<br>
>> for the<br>
>>> datasource [3]. The error [4] mentions an unresolved<br>
>> (DataSource)<br>
>>> service dependency that is added to the persistence unit<br>
>> service [5],<br>
>>> instead of resolving the resource reference (and using the<br>
>> underlying<br>
>>> DataSource).<br>
>>><br>
>>> How should we handle resource references for this case? Is<br>
>> there a way<br>
>>> to resolve the resource reference directly from deployers?<br>
>> Or do we<br>
>>> represent the resource reference as a service?<br>
>>><br>
>>> Scott<br>
>>><br>
>>> [1] test app is at <a href="https://github.com/umartin/wfds/" target="_blank">https://github.com/umartin/wfds/</a><br>
>>><br>
>>> [2] jboss-web.xml<br>
>>> <jboss-web><br>
>>> <context-root>/wfds</context-root><br>
>>> <resource-ref><br>
>>> <res-ref-name>jdbc/MyDS</res-ref-name><br>
>>> <res-type>javax.sql.DataSource</res-type><br>
>>><br>
>>> <jndi-name>java:jboss/datasources/ExampleDS</jndi-name><br>
>>> </resource-ref><br>
>>> </jboss-web><br>
>>><br>
>>> [3] persistence.xml pu def<br>
>>> <persistence-unit name="wfdsPU" transaction-type="JTA"><br>
>>> <jta-data-source>java:comp/env/MyDS</jta-data-source><br>
>>> </persistence-unit><br>
>>><br>
>>> [4] {"JBAS014771: Services with missing/unavailable<br>
>> dependencies" =><br>
>>><br>
>> ["jboss.persistenceunit.\"wfds-1.0-SNAPSHOT.war#wfdsPU\".__FIRST_PHASE__<br>
>>> is missing<br>
>>><br>
>> [jboss.naming.context.java.module.\"wfds-1.0-SNAPSHOT\".\"wfds-1.0-SNAPSHOT\".env.MyDS]"]}<br>
>>><br>
>>><br>
>>> [5]<br>
>>><br>
>> <a href="https://github.com/wildfly/wildfly/blob/master/jpa/core/src/main/java/org/jboss/as/jpa/processor/PersistenceUnitServiceHandler.java#L358" target="_blank">https://github.com/wildfly/wildfly/blob/master/jpa/core/src/main/java/org/jboss/as/jpa/processor/PersistenceUnitServiceHandler.java#L358</a><br>
>>> _______________________________________________<br>
>>> wildfly-dev mailing list<br>
>>> <a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a> <mailto:<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a>><br>
>> <mailto:<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
>> <mailto:<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a>>><br>
>>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
>>><br>
>>><br>
>><br>
>> _______________________________________________<br>
>> wildfly-dev mailing list<br>
>> <a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a> <mailto:<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a>><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
>><br>
>><br>
>><br>
>><br>
>> --<br>
>> Hälsningar,<br>
>> Martin Andersson<br>
>> Purple Scout AB<br>
>> <a href="tel:%2B46%20732%2005%2014%2001" value="+46732051401">+46 732 05 14 01</a><br>
><br>
> _______________________________________________<br>
> wildfly-dev mailing list<br>
> <a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
</div></div>> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Hälsningar,<div>Martin Andersson</div><div>Purple Scout AB</div><div>+46 732 05 14 01</div></div>
</div></div></div>