<div dir="ltr"><div><div><div><div><div><div>Thanks for tips but actually it does not change anything :)<br><br></div>Still there is only the reader that is non-blocking. If you check my updated example you will see that in the EchoHandler class I added a writer task which is the only way I found at the moment to have an asynchronous (yet BLOCKING) way of sending responses to the (telnet) client.<br>
<br></div>What I noticed is that Read and Write listeners are kind of mutually exclusive i.e. when I set a WriteListener and ReadListener, the read part will be NEVER called. When I set only ReadListener it's OK but then I'm not able to write ServletOutputStream in a non-blocking way. I checked the Servlet 3.1 specification, which documents Upgrade part very poorly and they do not say anything about such limitations. I could try to set the WriterListener from within ReadListener but subsequent calls to setWriteListener throw IllegalStateException, which does not follow strictly the specification:<br>
<br>Section 3.7:<br>"A subsequent call to setReadListener in the scope of the current request is illegal and an IllegalStateException MUST be thrown."<br><br></div><div>Section 5.3 (symmetrical to 3.7 but regarding the write):<br>
</div><div>says nothing about IllegalStateExceptionin in case of subsequent calls to setWriteListener</div><div><br></div>There was a presentation during JavaOne 2013 showing the upgrade mechanism, but of course Oracle guys did not show the good pieces: <a href="https://www.youtube.com/watch?v=LX8tchFSpnA">https://www.youtube.com/watch?v=LX8tchFSpnA</a><br>
<br></div>In conclusion, I am able to read in a non-blocking manner and write in a blocking way. Anyone has an example how to use non-blocking read and write streams?<br><br></div>Cheers,<br></div>Przemyslaw<br><div><div>
<div><br><br></div></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 28, 2014 at 9:31 PM, Jim McGuinness <span dir="ltr"><<a href="mailto:dador92@gmail.com" target="_blank">dador92@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">So here's what I'm getting (my source code is attached) ...<div><br></div><div><br></div><div>__Telnet__</div>
<div><p style="margin:0px;font-size:11px;font-family:Menlo">dador-iMac:~ dador$ telnet 10.0.1.14 8080</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">Trying 10.0.1.14...</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">Connected to 10.0.1.14.</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">Escape character is '^]'.</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">GET /wildfly-debug/upgrade HTTP/1.1</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">Connection: upgrade</p><div class="">
<p style="margin:0px;font-size:11px;font-family:Menlo;min-height:13px"><br></p>
<p style="margin:0px;font-size:11px;font-family:Menlo">HTTP/1.1 101 Switching Protocols</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">Connection: Upgrade</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">X-Powered-By: Undertow 1</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">Server: Wildfly 8</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">Content-Length: 0</p>
</div><p style="margin:0px;font-size:11px;font-family:Menlo">Date: Fri, 28 Mar 2014 20:22:36 GMT</p>
<p style="margin:0px;font-size:11px;font-family:Menlo;min-height:13px"><br></p>
<p style="margin:0px;font-size:11px;font-family:Menlo">the quick brown fox blah, blah, blah</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">^]</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">telnet> quit</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">Connection closed.</p>
<p style="margin:0px;font-size:11px;font-family:Menlo">dador-iMac:~ dador$ </p></div><div><br></div><div><br></div><div>__console___</div><div><p style="margin:0px;font-size:16px;font-family:Monaco">15:22:36,825 INFO [stdout] (default task-15) servlet doGet() received 'upgrade'</p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:46,488 INFO [stdout] (default I/O-3) listener onDataAvailable() called</p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:46,488 INFO [stdout] (default I/O-3) listener read 'the quick brown fox blah, blah, blah'; successfully offered to queue</p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:46,489 INFO [stdout] (default I/O-3) listener read ''; successfully offered to queue</p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:56,824 INFO [stdout] (default I/O-3) listener onDataAvailable() called</p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:56,824 INFO [stdout] (default I/O-3) listener onAllDataRead() called</p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:56,824 INFO [stdout] (default I/O-3) here is data queued ...</p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:56,825 INFO [stdout] (default I/O-3) the quick brown fox blah, blah, blah</p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:56,825 INFO [stdout] (default I/O-3) </p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:56,825 INFO [stdout] (default I/O-3) </p>
<p style="margin:0px;font-size:16px;font-family:Monaco">15:22:56,825 INFO [stdout] (default I/O-3) now do something</p></div><div><br></div><div><br></div><div>So the queue is getting the data as it's being piped in (the blanks in the queued data are telnet line feeds). But I have to send a signal to the servlet that all of the data has been sent (I simply close the telnet connection). Then the listener's onAllDataRead() method gets called.</div>
<div><br></div><div>So maybe this is a configuration issue. By the way, it made a difference for me in the telnet session when I specified the Connection as "upgrade" versus "Upgrade".</div><div><br></div>
<div>Just a suggestion, but you may also want to take a look at the non-blocking I/O if you input stream is a long one.</div><div><br></div><div>Good luck,</div><div><br></div><div>--Jim.</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote"><div><div class="h5">On Fri, Mar 28, 2014 at 3:05 PM, PB <span dir="ltr"><<a href="mailto:pbielicki@gmail.com" target="_blank">pbielicki@gmail.com</a>></span> wrote:<br></div></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">
<div dir="ltr"><div><div><div>Hi,<br><br></div>I dare to say that my code is correct ;) The problem is that it is NEVER called - this condition (even if it's wrong, however it's not) is never checked. When I remove this line:<br>
<br>out.setWriteListener(new EchoWriteListener(queue, out));<br><br></div><div>it seems to work. However, I have no writer, so it should be rather called SwallowListener... It's not my goal.<br><br></div><div>Maybe I should initialize WriteListener from the ReadListener after the first read? Or maybe, when I want to send back the response I should do this directly from the read listener? e.g. <a href="https://java.net/projects/tyrus/sources/source-code-repository/content/trunk/containers/servlet/src/main/java/org/glassfish/tyrus/servlet/TyrusHttpUpgradeHandler.java" target="_blank">https://java.net/projects/tyrus/sources/source-code-repository/content/trunk/containers/servlet/src/main/java/org/glassfish/tyrus/servlet/TyrusHttpUpgradeHandler.java</a><br>
<br></div><div>Thanks,<br></div><div>Przemyslaw<br></div></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Mar 28, 2014 at 5:14 PM, Heiko Braun <span dir="ltr"><<a href="mailto:hbraun@redhat.com" target="_blank">hbraun@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">At a first glance, I'd say your while{} block never returns. Is ServletInputStream.isFinished() what you've been looking for, instead of isReady()<div>
<br><div><div>On 28 Mar 2014, at 16:26, PB <<a href="mailto:pbielicki@gmail.com" target="_blank">pbielicki@gmail.com</a>> wrote:</div><br><blockquote type="cite"><span style="font-family:'courier new',monospace;font-size:16px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">while (in.isReady()) {</span></blockquote>
</div><br><div>
<div style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;text-transform:none;white-space:normal;font-family:Helvetica;word-wrap:break-word;word-spacing:0px">
<span style="border-spacing:0px;text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="border-spacing:0px;text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="border-spacing:0px;text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<div>--</div><div><br></div><div><a href="http://about.me/hbraun" target="_blank">http://about.me/hbraun</a></div><div><br></div></div></span><br></div></span><br></div></span><br></div><br><br>
</div>
<br></div></div></blockquote></div><br></div>
</div></div><br></div></div>_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br></blockquote></div><br></div>
</blockquote></div><br></div>