<div dir="ltr">I'm just thinking out laud - perhaps it would be better to add some rules to checkstyle plugin? This way all commits would have to obey this kind of coding standards.<div><br><div>Of course there are some drawbacks... we'd need to fix all violations in existing code base. But this also may be considered as a something good :)<br>
</div><div><br></div><div>Best regards</div><div>Sebastian</div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-07-30 22:03 GMT+02:00 Anil Saldhana <span dir="ltr"><<a href="mailto:Anil.Saldhana@redhat.com" target="_blank">Anil.Saldhana@redhat.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Darran - very good suggestion.<br>
<br>
Also, don't merge if there is no javadoc on public methods and classes. :-)<br>
<div class="HOEnZb"><div class="h5"><br>
On 07/30/2014 02:46 PM, Darran Lofthouse wrote:<br>
> Just a random idea.<br>
><br>
> Can we block merging pull requests if they contain a TODO comment that<br>
> don't reference a Jira issue?<br>
><br>
> The views in GitHub are easy to see if a TODO is involved so quite<br>
> simple to double check - and if no Jira is justified maybe the TODO<br>
> isn't either.<br>
><br>
> Regards,<br>
> Darran Lofthouse.<br>
> _______________________________________________<br>
> wildfly-dev mailing list<br>
> <a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
<br>
_______________________________________________<br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/wildfly-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Sebastian Łaskawiec
</div>