<div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Scott,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 5 August 2014 17:45, Scott Marlow <span dir="ltr"><<a href="mailto:smarlow@redhat.com" target="_blank">smarlow@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the complements Andrej! :-)<br>
<br>
Sanne, please see in-line below.<div class=""><br>
<br>
On 08/05/2014 09:49 AM, Sanne Grinovero wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Andrej,<br>
that's an excellent point.<br>
<br>
I also don't want to make it harder for users to play with the latest<br>
versions we'll be releasing - normally at a higher pace than WildFly.<br>
</blockquote>
<br></div>
I'm not sure that you need to sync up with WildFly as much as the Hibernate ORM project. For example,<div class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
I guess I'll need learn more about writing a subsystem to make sure<br>
these options are covered.<br>
</blockquote>
<br></div>
If Hibernate Search is a part of the Hibernate ORM module, like Envers is, that could make integration easy enough for Hibernate Search and users that want to package Hibernate ORM with their application. They either also include Hibernate Search or not. If applications include Hibernate ORM but no Hibernate Search, they can't use Hibernate Search.<br>
</blockquote><div><br></div><div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">There are no problems for people packaging it as long as they don't enable conflicting modules, my point is that I want to encourage the modules usage to take advantage of its many benefits. Not least, that you don't need to deploy many jars which are already included in the server.</div>
</div><div><br></div><div class="gmail_default" style="font-size:small"></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
A bigger problem though is that bundling Hibernate Search with the application, likely means that the application server version of Infinispan (already configured and ready to work with clustering), will not be usable.<br>
<br>
<tangent><br>
Another related issue is that Hibernate 3.x depends on an older version of Infinispan, so when Hibernate 3.x is used on WildFly, clustering of the second level cache will not work (even when Hibernate 3.x is used as a wildfly/modules (static) module). The same will occur with other versions of Hibernate as well.<br>
<br>
In theory, we could externalize clustering integration to be external to the Hibernate ORM codebase (in Jipijapa). I've done some experimentation with that but not too far (more for EclipseLink/OpenJpa 2lc clustering but we could see some benefit to Hibernate also).<br>
</tangent></blockquote><div><br></div><div><div class="gmail_default" style="font-size:small">Hibernate Search integrates with the latest versions of ORM and Infinispan, Hibernate 3 is unrelated to this?</div><div class="gmail_default" style="font-size:small">
The versions of Hibernate Search libraries included in WildFly are released and tested specifically to be fully aligned with the other versions of libraries in WildFly: keeps the modules lean and avoids lots of trouble. No idea why you think I might depend on years old versions :)</div>
<div class="gmail_default" style="font-size:small">Also Search doesn't depend on clustering, it's some code of clustering which depends on it (so the other way around), but via this path of the dependency graph you are completely isolated from ORM (the Hibernate Search Engine module does NOT depend on Hibernate ORM).</div>
<div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">What I'd like is to have this functionality exposed to deployments who need it without them having to reconfigure/enable modules, but I certainly don't want to expose the clustering dependencies as well.</div>
<div class="gmail_default" style="font-size:small">I understand now that I need to learn about the subsystems, got it :)</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">
Thanks for all the ideas, I'll certainly ping you to learn about subsystem development.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">Sanne</div>
<br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888"><br>
<br>
Scott<br>
<br>
</font></span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="">
<br>
Thanks all,<br>
Sanne<br>
<br>
On 4 August 2014 20:43, Andrej Golovnin <<a href="mailto:golovnin@gmx.net" target="_blank">golovnin@gmx.net</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Sanne,<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I see no reasons to not enable it by default, following the same<br>
activation rules of other Hibernate dependencies: it's very<br>
conservative about not auto-enabling itself when not needed.<br>
<br>
</blockquote>
<br>
It is OK as long as it will be still possible to bundle Hibernate Search<br>
within an application and Hibernate would use the bundled version of<br>
Hibernate Search.<br>
<br>
Not all users want to use Hibernate and Hibernate Search,<br>
which are delivered with WildFly.<br>
<br>
For Hibernate we have a perfect solution developed by Scott, which<br>
allows WildFly to use Hibernate packaged inside of an application.<br>
At this place a big thanks to Scott for this wonderful solution! It works great!<br>
The same should be possible with Hibernate Search.<br>
<br>
Best regards,<br>
Andrej Golovnin<br>
</blockquote></div>
______________________________<u></u>_________________<div class=""><br>
wildfly-dev mailing list<br>
<a href="mailto:wildfly-dev@lists.jboss.org" target="_blank">wildfly-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/wildfly-dev" target="_blank">https://lists.jboss.org/<u></u>mailman/listinfo/wildfly-dev</a><br>
<br>
</div></blockquote>
<br>
</blockquote></div><br></div></div>